Simplify l2pop driver code

Bug #1535392 reported by venkata anil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Expired
Undecided
Unassigned

Bug Description

Simplify l2pop driver code.

l2pop driver unable to properly decide about port add/remove notifications when it gets called with different port status from nova and l2 agents through different workers during instance migrations.
There were many suggestions to modify the port status in plugin(some suggested to change it to BUILD, some reviewers to DOWN, etc ..) during migration(see the comments in https://review.openstack.org/#/c/215467/ ), so that l2pop can properly decide about port's binding host based on status. Deciding about which status to set to port in plugin and using the same in l2pop driver is confusing, and reviewers giving different opinion(comments in https://review.openstack.org/#/c/215467/ ).

Kevin suggested that l2pop shouldn't depend on port status for deciding about host. Instead it should use binding info in db, which reviewers of the patch( https://review.openstack.org/#/c/215467/) agreed.

note: There was a separate bug https://bugs.launchpad.net/neutron/+bug/1555600 reported for "agents fail to create flood flows with multiple workers"

Tags: l2-pop
Changed in neutron:
assignee: nobody → venkata anil (anil-venkata)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/269212

Changed in neutron:
status: New → In Progress
Assaf Muller (amuller)
tags: added: l2-pop
summary: - l2pop should use only binding info in db and not port status for db
- entries.
+ Simplify l2pop driver code
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/288284

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by venkata anil (<email address hidden>) on branch: master
Review: https://review.openstack.org/269212

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

This bug is > 180 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in neutron:
assignee: venkata anil (anil-venkata) → nobody
status: In Progress → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for neutron because there has been no activity for 60 days.]

Changed in neutron:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.