a level binding implement issue in _check_driver_to_bind

Bug #1524356 reported by RaoFei
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Hong Hui Xiao

Bug Description

in the function of _check_driver_to_bind, the below row 3 condition will never be satisfied.
the type of Level.segment_id is string, but Segment_to_bind is a list dict.

1 for level in binding_levels:
2 if (level.driver == driver and
3 level.segment_id in segments_to_bind):
4 return False

Tags: ml2
Revision history for this message
RaoFei (milo-frao) wrote :
RaoFei (milo-frao)
tags: added: ml2
Henry Gessau (gessau)
Changed in neutron:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/271959

Changed in neutron:
assignee: nobody → Hong Hui Xiao (xiaohhui)
status: Confirmed → In Progress
Changed in neutron:
assignee: Hong Hui Xiao (xiaohhui) → Federico Ressi (federico-ressi-9)
Changed in neutron:
assignee: Federico Ressi (federico-ressi-9) → Hong Hui Xiao (xiaohhui)
Changed in neutron:
assignee: Hong Hui Xiao (xiaohhui) → Federico Ressi (federico-ressi-9)
Changed in neutron:
assignee: Federico Ressi (federico-ressi-9) → Hong Hui Xiao (xiaohhui)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/271959
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9db81351ed8ddeeb279f640eccbdf539945bde7f
Submitter: Jenkins
Branch: master

commit 9db81351ed8ddeeb279f640eccbdf539945bde7f
Author: Hong Hui Xiao <email address hidden>
Date: Mon Jan 25 04:09:48 2016 -0500

    Fix wrong use of list of dict in _check_driver_to_bind

    From [1], the segments_to_bind should be a list of dict, so the
    "level.segment_id in segments_to_bind" will never work.

    This patch extracts a set of segment ids and uses the set in the
    if condition.

    [1] https://goo.gl/yKYSTA

    Change-Id: I58f1d128e6cd79546d84f7d5bfcb026affc4fc5e
    Closes-bug: #1524356

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b1

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.