Pip package 'ovs' needed but not present in requirements.txt

Bug #1523845 reported by John Schwarz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Russell Bryant

Bug Description

As the title mentions, the 'ovs' pip package is needed for [1], but is not present in the requirements.txt [2] and it should be changed to reflect this dependency.

[1]: https://github.com/openstack/neutron/blob/7a5ebc171f9ff342d7526808b1063b58cc631fec/neutron/agent/ovsdb/impl_idl.py#L21
[2]: https://github.com/openstack/neutron/blob/7a5ebc171f9ff342d7526808b1063b58cc631fec/requirements.txt

John Schwarz (jschwarz)
Changed in neutron:
assignee: nobody → John Schwarz (jschwarz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/254645

Changed in neutron:
status: New → In Progress
Revision history for this message
Henry Gessau (gessau) wrote :

I believe this is invalid because it is not needed by installations that don't use OVS. Perhaps this should be changed to a bug to improve documentation?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Doug Wiegley (<email address hidden>) on branch: master
Review: https://review.openstack.org/254645
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Restored. @Henry: what about ryu? :P

This is not invalid IMO

Changed in neutron:
importance: Undecided → Low
Changed in neutron:
assignee: John Schwarz (jschwarz) → Russell Bryant (russellb)
Revision history for this message
Henry Gessau (gessau) wrote :

I will stop commenting and leave this to the experts.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/254645
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9605617ec729d83e67f00dabb84784abd7515a88
Submitter: Jenkins
Branch: master

commit 9605617ec729d83e67f00dabb84784abd7515a88
Author: John Schwarz <email address hidden>
Date: Tue Dec 8 11:52:36 2015 +0200

    Add 'ovs' to requirements.txt

    It is needed by neutron/agent/ovsdb/impl_idl.py.

    Closes-Bug: #1523845
    Change-Id: If44b649949c686b589859fc1d4d2bb510afb64fd

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/268373

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0b2

This issue was fixed in the openstack/neutron 8.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.