Remove the gateway of external net won't affect router

Bug #1520775 reported by Hong Hui Xiao on 2015-11-28
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Medium
Hong Hui Xiao

Bug Description

I found this one when build up a test env.

Steps to reproduce:
1) I create a set of external network, internal network and router. The external network has gateway ip in its subnet.
2) connect the external, internal network and router, by using router-gateway-set, router-interface-add.
3) Then I realize my physical network doesn't have a gateway. So I update the subnet of external network with --no-gateway.
4) I can't see the default route be deleted in router namespace, even if I restart l3-agent.

I try it in legacy router and DVR, they both have this problem, and I believe HA router will have this problem.

Hong Hui Xiao (xiaohhui) on 2015-11-28
Changed in neutron:
assignee: nobody → Hong Hui Xiao (xiaohhui)
Changed in neutron:
importance: Undecided → Medium
Doug Wiegley (dougwig) on 2015-12-03
Changed in neutron:
status: New → Confirmed
Hong Hui Xiao (xiaohhui) on 2015-12-08
description: updated

Fix proposed to branch: master
Review: https://review.openstack.org/254750

Changed in neutron:
status: Confirmed → In Progress

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/254750
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Please restore if you intend to continue working on it.

Changed in neutron:
status: In Progress → Incomplete
assignee: Hong Hui Xiao (xiaohhui) → nobody
Launchpad Janitor (janitor) wrote :

[Expired for neutron because there has been no activity for 60 days.]

Changed in neutron:
status: Incomplete → Expired
tags: added: l3-dvr-backlog
Changed in neutron:
assignee: nobody → Hong Hui Xiao (xiaohhui)
status: Expired → In Progress
Oleg Bondarev (obondarev) wrote :

Should the title be "Remove the gateway.." rather then "Update the gateway.."? Update should've been fixed by https://bugs.launchpad.net/neutron/+bug/1317363

Hong Hui Xiao (xiaohhui) wrote :

Yes, you are right. The title has been updated.

summary: - Update the gateway of external net won't affect router
+ Remove the gateway of external net won't affect router

Reviewed: https://review.openstack.org/254750
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f9d0dd39e6b3b14244e0a185c4a1f7f35f48f3e7
Submitter: Jenkins
Branch: master

commit f9d0dd39e6b3b14244e0a185c4a1f7f35f48f3e7
Author: root <email address hidden>
Date: Thu Jul 7 13:32:44 2016 +0000

    Delete default route if no gateway in external net

    Currently, when the default route is added to device, there is no
    way to delete it. Even if user clear the gateway ip of external
    net, there is still a default route present in router namespace.

    This patch will check the default route in namespace first. If its
    gateway ip is not one of the gateway ips in external net. This
    default route will be deleted.

    Change-Id: If2ab88b392f3935306d73e3c2de0a35548567464
    Closes-Bug: #1520775

Changed in neutron:
status: In Progress → Fix Released
tags: added: neutron-proactive-backport-potential

This issue was fixed in the openstack/neutron 9.0.0.0b3 development milestone.

tags: removed: neutron-proactive-backport-potential
tags: added: mitaka-backport-potential

Reviewed: https://review.openstack.org/413746
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a66af420914aa4c45b7c61daf36e36cff28d75b2
Submitter: Jenkins
Branch: stable/mitaka

commit a66af420914aa4c45b7c61daf36e36cff28d75b2
Author: root <email address hidden>
Date: Thu Jul 7 13:32:44 2016 +0000

    Delete default route if no gateway in external net

    Currently, when the default route is added to device, there is no
    way to delete it. Even if user clear the gateway ip of external
    net, there is still a default route present in router namespace.

    This patch will check the default route in namespace first. If its
    gateway ip is not one of the gateway ips in external net. This
    default route will be deleted.

    Change-Id: If2ab88b392f3935306d73e3c2de0a35548567464
    Closes-Bug: #1520775
    (cherry picked from commit f9d0dd39e6b3b14244e0a185c4a1f7f35f48f3e7)

tags: added: in-stable-mitaka

This issue was fixed in the openstack/neutron 8.4.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers