neutron

tox 2.2.0+ breaks neutron due to :api setenv section

Bug #1515335 reported by Ihar Hrachyshka
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Critical
Armando Migliaccio
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

The line that breaks it is:

https://github.com/openstack/neutron/blob/master/tox.ini#L26

Once removed, all goes well.

Changed in neutron:
importance: Undecided → Critical
status: New → Confirmed
tags: added: gate-failure
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Reported in tox tracker: https://bitbucket.org/hpk42/tox/issues/285/tox-220-breaks-some-toxini-config-files

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/244259

Changed in neutron:
assignee: nobody → Rossella Sblendido (rossella-o)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/244277

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lbaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/244284

Changed in neutron:
assignee: Rossella Sblendido (rossella-o) → Armando Migliaccio (armando-migliaccio)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/244259
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a32e31a624cf5190ed267effed8f7db2c9919949
Submitter: Jenkins
Branch: master

commit a32e31a624cf5190ed267effed8f7db2c9919949
Author: rossella <email address hidden>
Date: Wed Nov 11 19:08:36 2015 +0000

    Remove TEMPEST_CONFIG_DIR in the api tox env

    Setting TEMPEST_CONFIG_DIR in tox.ini is breaking the gate,
    probably because of a tox bug [1].
    Removing the line to unblock the gate. This implies that
    for local execution of the tests TEMPEST_CONFIG_DIR
    should be set manually.

    [1] https://bitbucket.org/hpk42/tox/issues/285/tox-220-breaks-some-toxini-config-files

    Change-Id: If3742b6eabe295a5aaeb4901c55909a70c451698
    Closes-bug: #1515335

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lbaas (master)

Reviewed: https://review.openstack.org/244284
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=ad815651de98580afeca6d56319f8c8a50a357e7
Submitter: Jenkins
Branch: master

commit ad815651de98580afeca6d56319f8c8a50a357e7
Author: armando-migliaccio <email address hidden>
Date: Wed Nov 11 11:40:13 2015 -0800

    Remove TEMPEST_CONFIG_DIR in the api tox env

    Setting TEMPEST_CONFIG_DIR in tox.ini is breaking the gate,
    probably because of a tox bug [1].
    Removing the line to unblock the gate. This implies that
    for local execution of the tests TEMPEST_CONFIG_DIR
    should be set manually.

    [1] https://bitbucket.org/hpk42/tox/issues/285/tox-220-breaks-some-toxini-config-files

    Closes-bug: #1515335

    Change-Id: I62f7985b034d17626a45ad965265111b671a5974

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lbaas (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/244358

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-lbaas (stable/liberty)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/244358
Reason: This ain't needed anymore.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/244277
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a3154b03ac60df586bd8fd67f03c20327f2dde41
Submitter: Jenkins
Branch: master

commit a3154b03ac60df586bd8fd67f03c20327f2dde41
Author: Ihar Hrachyshka <email address hidden>
Date: Wed Nov 11 20:16:44 2015 +0100

    Revert "Remove TEMPEST_CONFIG_DIR in the api tox env"

    This reverts commit a32e31a624cf5190ed267effed8f7db2c9919949.

    We should be able to merge the revert back once tox project fixes the
    bug* on their side.

    * https://bitbucket.org/hpk42/tox/issues/285/tox-220-breaks-some-toxini-config-files

    Change-Id: Ic1f5391c687b2683cbaab210c543022aa1f26e83
    Related-Bug: #1515335

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/244868

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lbaas (stable/liberty)

Reviewed: https://review.openstack.org/244358
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=11f16be9721c264deb2aa6be9cd0c0716af5cc33
Submitter: Jenkins
Branch: stable/liberty

commit 11f16be9721c264deb2aa6be9cd0c0716af5cc33
Author: armando-migliaccio <email address hidden>
Date: Wed Nov 11 11:40:13 2015 -0800

    Remove TEMPEST_CONFIG_DIR in the api tox env

    Setting TEMPEST_CONFIG_DIR in tox.ini is breaking the gate,
    probably because of a tox bug [1].
    Removing the line to unblock the gate. This implies that
    for local execution of the tests TEMPEST_CONFIG_DIR
    should be set manually.

    [1] https://bitbucket.org/hpk42/tox/issues/285/tox-220-breaks-some-toxini-config-files

    Closes-bug: #1515335

    Change-Id: I62f7985b034d17626a45ad965265111b671a5974
    (cherry picked from commit ad815651de98580afeca6d56319f8c8a50a357e7)

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/244868
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=074ccb94a9c237bd8d5ef235b66b0a2ba7ae546a
Submitter: Jenkins
Branch: stable/liberty

commit 074ccb94a9c237bd8d5ef235b66b0a2ba7ae546a
Author: rossella <email address hidden>
Date: Wed Nov 11 19:08:36 2015 +0000

    Remove TEMPEST_CONFIG_DIR in the api tox env

    Setting TEMPEST_CONFIG_DIR in tox.ini is breaking the gate,
    probably because of a tox bug [1].
    Removing the line to unblock the gate. This implies that
    for local execution of the tests TEMPEST_CONFIG_DIR
    should be set manually.

    [1] https://bitbucket.org/hpk42/tox/issues/285/tox-220-breaks-some-toxini-config-files

    Change-Id: If3742b6eabe295a5aaeb4901c55909a70c451698
    Closes-bug: #1515335
    (cherry picked from commit a32e31a624cf5190ed267effed8f7db2c9919949)

Doug Hellmann (doug-hellmann)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/263841

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/263841
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=380e384f180c1b70082891f9818dc3973dd5335a
Submitter: Jenkins
Branch: master

commit 380e384f180c1b70082891f9818dc3973dd5335a
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Jan 5 19:36:42 2016 +0100

    Revert "Revert "Revert "Remove TEMPEST_CONFIG_DIR in the api tox env"""

    This reverts commit be63289c273fa02159a6958e0b456d5fda217431.

    Yes, it's a third order revert. Ain't it cool?

    Now that tox 2.3.1 is used in gate, and it is expected to fix the issue
    that we originally hacked around here, let's revert to the previous
    code.

    For the least, it makes API target executable locally without the need
    to set TEMPEST_CONFIG_DIR in the external environment.

    Also bump minimal tox version to 2.3 to avoid users hitting the old
    issue with their tox 2.2.* package.

    Change-Id: Ic64cb466d117ad39436cb1d079c8f5657260da2c
    Related-Bug: #1515335

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/liberty)

Related fix proposed to branch: stable/liberty
Review: https://review.openstack.org/271035

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/271035
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ed7ad25b15dd1ce260cc4842a88660d0bbeaf019
Submitter: Jenkins
Branch: stable/liberty

commit ed7ad25b15dd1ce260cc4842a88660d0bbeaf019
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Jan 5 19:36:42 2016 +0100

    Revert "Revert "Revert "Remove TEMPEST_CONFIG_DIR in the api tox env"""

    This reverts commit be63289c273fa02159a6958e0b456d5fda217431.

    Yes, it's a third order revert. Ain't it cool?

    Now that tox 2.3.1 is used in gate, and it is expected to fix the issue
    that we originally hacked around here, let's revert to the previous
    code.

    For the least, it makes API target executable locally without the need
    to set TEMPEST_CONFIG_DIR in the external environment.

    Also bump minimal tox version to 2.3 to avoid users hitting the old
    issue with their tox 2.2.* package.

    Related-Bug: #1515335

    Conflicts:
     tox.ini
    Change-Id: Ic64cb466d117ad39436cb1d079c8f5657260da2c

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.