functional job for py34 stalls

Bug #1515118 reported by Armando Migliaccio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Ihar Hrachyshka

Bug Description

If I look at the runs that involve functional-py34, I can see that it takes forever to complete [1,2]. Typically it shouldn't take more than 10 minutes and instead it takes nearly 2 hours. That's killing us.

[1] https://review.openstack.org/#/c/243860/
[2] https://review.openstack.org/#/c/242259/

Changed in neutron:
importance: Undecided → Critical
assignee: nobody → Armando Migliaccio (armando-migliaccio)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243975

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

It's getting late...if someone picks it up during my nights, I wouldn't mind ;)

Changed in neutron:
assignee: Armando Migliaccio (armando-migliaccio) → nobody
Revision history for this message
Miguel Angel Ajo (mangelajo) wrote :

Pinging around to see if anybody can take over it, thanks @armax!.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/244089

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/244122

Changed in neutron:
assignee: nobody → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Reducing importance: it's not like we're on fire, it simply takes longer to merge stuff, and one might argue that's not a bad thing...that said, if what needs to merge is a gate failure fix, then we're in trouble.

Changed in neutron:
importance: Critical → High
importance: High → Medium
tags: added: py34
tags: added: functional-tests
tags: added: gate-failure
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/244122
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d24df91ebfe1a944ea087dce45c0257d11d7df51
Submitter: Jenkins
Branch: master

commit d24df91ebfe1a944ea087dce45c0257d11d7df51
Author: Ihar Hrachyshka <email address hidden>
Date: Wed Nov 11 15:13:00 2015 +0100

    Don't use duplicate filter names for functional testing

    They are not supported by Python 3.x configparser module (you get
    DuplicateOptionError if duplicate names are present).

    This makes tests relying on rootwrap daemon to get stuck, because the daemon
    fails to spawn, while we wait for results from the process.

    Change-Id: I1628bb87b235a6b4bac53afda37402e986520f39
    Related-Bug: #1515118

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/244089
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e30d8cead155c119ee2ffde074312591f7938fb0
Submitter: Jenkins
Branch: master

commit e30d8cead155c119ee2ffde074312591f7938fb0
Author: Ihar Hrachyshka <email address hidden>
Date: Wed Nov 11 13:59:22 2015 +0100

    Make sure we return unicode strings for process output

    Process output is supposed to be represented with lines, so we should
    put Python strings in the queue (not bytes). Just in case, we do it only
    for Python 3 environment.

    To fix that, we reuse code from utils.execute() linux/windows
    implementations.

    This fixes the TestAsyncProcess.test_async_process_respawns functional
    test for Python 3 environment.

    Related-Bug: #1515118
    Change-Id: I9efec2290003add44909aab33a0026372a580016

Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

I believe the issue of long runs is fixed by those two patches, so marked as Fixed.

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.