Linux bridge agent "interface_exists_on_bridge" can be optimized

[Cedric Brandily]

Currently, when lb agent needs to check if an interface exists on a bridge, it will get all interfaces on the bridge and looks for the interface:

 for filename in os.listdir(BRIDGE_INTERFACES_FS):
   if filename == interface:
     return True
   return False

when we can directly check os.path.join(BRIDGE_INTERFACE_FS, interface) existence.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/239299

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/239299
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0f471be1de5aadc935c3b48625193dc23360e467
Submitter: Jenkins
Branch: master

commit 0f471be1de5aadc935c3b48625193dc23360e467
Author: Cedric Brandily <email address hidden>
Date: Mon Oct 26 09:19:26 2015 +0900

    Optimize interface_exists_on_bridge

    Currently interface_exists_on_bridge[1] lists all files in a folder and
    searchs for the file associated to the interface.

    This change proposes to look for the file existence directly.

    [1] neutron.plugins.ml2.drivers.linuxbridge.agent.linuxbridge_neutron_agent

    Closes-Bug: #1509890
    Change-Id: I23cd1edc92912b35bdc23ba0af2318b86f2cfd48

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.