Remove deadcode from neutron.common.utils

Bug #1508430 reported by Bogdan Tabor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Bogdan Tabor

Bug Description

neutron.common.utils contains methods not used anywhere withing neutron projects:

neutron/neutron/common/utils.py:def read_cached_file(filename, cache_info, reload_func=None):
neutron/neutron/common/utils.py:def find_config_file(options, config_file):
neutron/neutron/common/utils.py:def get_keystone_url(conf):

Remove them all.

Information on how to reproduce the fault is in attachements.

Revision history for this message
Bogdan Tabor (bogdan-tabor) wrote :
Changed in neutron:
assignee: nobody → Bogdan Tabor (bogdan-tabor)
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Note they may be used in external repos. So deprecation period is justified.

Changed in neutron:
importance: Undecided → Low
Revision history for this message
Bogdan Tabor (bogdan-tabor) wrote :

What external repos?
I checked:

neutron
neutron-fwaas
neutron-lbaas
neutron-lbaas-dashboard
neutron-specs
neutron-vpnaas
puppet-neutron
python-neutronclient
python-neutron-pd-driver

What else do I need to check?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/238086

Changed in neutron:
status: New → In Progress
Revision history for this message
Kevin Benton (kevinbenton) wrote :

This needs to go through deprecation. These could be used by any of the tons of drivers/plugins/services that vendors and operators could be running.

tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/238086
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8022adb7342b09886f53c91c12d0b37986fbf35c
Submitter: Jenkins
Branch: master

commit 8022adb7342b09886f53c91c12d0b37986fbf35c
Author: Bogdan Tabor <email address hidden>
Date: Wed Oct 21 15:40:14 2015 +0200

    Mark for removal deadcode in neutron.common.utils

    Methods:
     * read_cached_file(filename, cache_info, reload_func=None)
     * find_config_file(options, config_file)
     * get_keystone_url(conf)
    are not used withing neutron projects.

    Change-Id: Iba3325103f5c24c1822781382f4c8864eb2921c5
    Closes-bug: #1508430

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.