For wrong ethertype exception message is hard coded

[Manjeet Singh Bhatia]

if you give any wrong ethertype while creating security group rule.
it will always mention reason None in exception message

Invalid input for ethertype. Reason: 'None' is not in ['IPv4', 'IPv6'].

try

neutron security-group-rule-create --ethertype ip --protocol icmp <group-id>

it will print
Invalid input for ethertype. Reason: 'None' is not in ['IPv4', 'IPv6'].

but actually it should be Invalid input for ethertype. Reason: 'ip' is not in ['IPv4', 'IPv6'].

[Armando Migliaccio (armando-migliaccio)]

Confirmed on master

[Armando Migliaccio (armando-migliaccio)]

IMO, we could simply say that input must be either IPv4 or IPv6, there's really no need to parrot back to the user who knows what he/she put on the CLI :)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/258971

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/258971
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=be14e905419f0927539e939c1f979430a6e44d42
Submitter: Jenkins
Branch: master

commit be14e905419f0927539e939c1f979430a6e44d42
Author: Sreekumar S <email address hidden>
Date: Thu Dec 17 02:34:33 2015 +0530

    Corrected wrong ethertype exception message

    This patch resolves the issue where wrong message was being
    shown when ethertype input parameter was not amongst one of
    the types supported. New message made akin to other input
    parameters like 'protocol'.

    Change-Id: I5636f3582c9d9877dad4d091a374284b656923f4
    Closes-Bug: #1508106

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/270261

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/270261
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1e3ef494317e9ed68fc9f87ae52da0423faffb6d
Submitter: Jenkins
Branch: stable/liberty

commit 1e3ef494317e9ed68fc9f87ae52da0423faffb6d
Author: Sreekumar S <email address hidden>
Date: Thu Dec 17 02:34:33 2015 +0530

    Corrected wrong ethertype exception message

    This patch resolves the issue where wrong message was being
    shown when ethertype input parameter was not amongst one of
    the types supported. New message made akin to other input
    parameters like 'protocol'.

    Change-Id: I5636f3582c9d9877dad4d091a374284b656923f4
    Closes-Bug: #1508106
    (cherry picked from commit be14e905419f0927539e939c1f979430a6e44d42)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 7.1.0 release.