VethFixture: smart veth delete

[Cedric Brandily]

VethFixture cleanup tries to delete veths from their namespaces even if they don't exist (without crashing the cleanup), it implies an extra trace if an error is raised which can be confusing:

Command: ['sudo', '-n', 'ip', 'netns', 'exec', 'test-ddc6fc89-5159-44e2-ba15-099a10adf5bc', 'ip', 'link', 'del', 'test-veth114005']
Exit code: 1
Stdin:
Stdout:
Stderr: Cannot open network namespace "test-ddc6fc89-5159-44e2-ba15-099a10adf5bc": No such file or directory

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/221350
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=72e87f6d87d0da65214a9d21fe603883f1d3c232
Submitter: Jenkins
Branch: master

commit 72e87f6d87d0da65214a9d21fe603883f1d3c232
Author: Cedric Brandily <email address hidden>
Date: Tue Sep 8 15:02:57 2015 +0000

    Do not try to delete a veth from a nonexistent namespace

    Currently, VethFixture cleanup tries to delete veth from their
    namespaces even if they don't exist anymore (without crashing the
    cleanup). It implies an extra trace if an error is raised which can be
    confusing.

    This change avoids to try deleting a veth from a nonexistent namespace
    in the fixture VethFixture.

    Closes-Bug: #1506862
    Change-Id: I5d0192998d2f3f8d1a6f783769ae9bfcb4bae7f2

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.