versions directory containing migration script is not included in neutron build if building outside of git

[Jakub Libosvar]

distutils contains only python files https://docs.python.org/2/distutils/sourcedist.html#manifest

neutron/db/migration/alembic_migrations/versions directory and its subdirectories don't have __init__.py because it's not an actual python package. When using "python setup.py egg_info", the SOURCE.txt file is generated by pbr based on git data. If package is built from e.g. tarball then pbr doesn't have access to git data and the whole versions directory is not packaged.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/234152

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/234155

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/234157

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/234161

[Armando Migliaccio (armando-migliaccio)]

are these backport material?

[Armando Migliaccio (armando-migliaccio)]

I am assuming this is going to be closed as soon as all the target patches merge, correct? Nothing is outstanding, besides the potential backport?

[Jakub Libosvar (libosvar)]

Yes, I think we should backport it to stable branches once merged.

Yes, we can close it, I'll test it first manually prior to closing.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/234155
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=2fba753bcefdf0b1652e5adb4cc7e1087afcc064
Submitter: Jenkins
Branch: master

commit 2fba753bcefdf0b1652e5adb4cc7e1087afcc064
Author: Jakub Libosvar <email address hidden>
Date: Tue Oct 13 13:29:01 2015 +0200

    Include alembic versions directory to the package

    If package is built without access to git metadata, all the migration
    scripts are not included in the build. We need to explicitly specify to
    package the scripts.

    This patch also removes non-existing files from MANIFEST.in

    Change-Id: I9a2acad13271863ee94de63c2404e8697ea70601
    Related-bug: #1505628

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/234157
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=a046cda097454670afa15ff19f29588dd94f7cdf
Submitter: Jenkins
Branch: master

commit a046cda097454670afa15ff19f29588dd94f7cdf
Author: Jakub Libosvar <email address hidden>
Date: Tue Oct 13 13:34:19 2015 +0200

    Include alembic versions directory to the package

    If package is built without access to git metadata, all the migration
    scripts are not included in the build. We need to explicitly specify to
    package the scripts.

    This patch also removes non-existing files from MANIFEST.in

    Change-Id: I9a2acad13271863ee94de63c2404e8697ea70601
    Related-bug: #1505628

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/234152
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=54a590d3419dbb41fc0a9bf81ec014440ba37054
Submitter: Jenkins
Branch: master

commit 54a590d3419dbb41fc0a9bf81ec014440ba37054
Author: Jakub Libosvar <email address hidden>
Date: Tue Oct 13 13:18:56 2015 +0200

    Include alembic versions directory to the package

    If package is built without access to git metadata, all the migration
    scripts are not included in the build. We need to explicitly specify to
    package the scripts.

    Change-Id: I9a2acad13271863ee94de63c2404e8697ea70601
    Closes-Bug: #1505628

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/234161
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=cf88bec3a5b1bfdfbb0bf53fc91b5f91c356251c
Submitter: Jenkins
Branch: master

commit cf88bec3a5b1bfdfbb0bf53fc91b5f91c356251c
Author: Jakub Libosvar <email address hidden>
Date: Tue Oct 13 13:37:49 2015 +0200

    Include alembic versions directory to the package

    If package is built without access to git metadata, all the migration
    scripts are not included in the build. We need to explicitly specify to
    package the scripts.

    This patch also removes non-existing files from MANIFEST.in

    Change-Id: I9a2acad13271863ee94de63c2404e8697ea70601
    Related-bug: #1505628

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.