neutron

Downgrade of DVR to legacy router returns wrong HTTP error code

Bug #1505346 reported by Assaf Muller
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Assaf Muller

Bug Description

Downgrading a DVR router to a legacy router raises a 'NotSupported' exception, which inherits from NeutronException, and isn't given an explicit error code in the API layer, therefor returning error 500:

http://paste.openstack.org/show/476056/

It should return error 400 (BadRequest) according to the API working group..

See original description
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/233766

Changed in neutron:
status: New → In Progress
Assaf Muller (amuller)
description: updated
OpenStack Infra (hudson-openstack)
Changed in neutron:
assignee: Assaf Muller (amuller) → Gal Sagie (gal-sagie)
Assaf Muller (amuller)
Changed in neutron:
assignee: Gal Sagie (gal-sagie) → Assaf Muller (amuller)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/233766
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a6d9580f2b95bf2c7c607d4e2671ffbbceae28d5
Submitter: Jenkins
Branch: master

commit a6d9580f2b95bf2c7c607d4e2671ffbbceae28d5
Author: Assaf Muller <email address hidden>
Date: Mon Oct 12 14:42:43 2015 -0400

    Fix DVR downgrade exception / error code

    Updating a distributed router back to a legacy router
    should return error 400 (BadRequest), not error 500.

    Closes-Bug: #1505346
    Change-Id: Ia57e80107bd11ff7b38b89d30279603017913724

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/238991

Assaf Muller (amuller)
tags: added: liberty-backport-potential
tags: added: kilo-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/238991
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4a2a931715dd121e1b3810e4f1d4c9d926328a67
Submitter: Jenkins
Branch: stable/liberty

commit 4a2a931715dd121e1b3810e4f1d4c9d926328a67
Author: Assaf Muller <email address hidden>
Date: Mon Oct 12 14:42:43 2015 -0400

    Fix DVR downgrade exception / error code

    Updating a distributed router back to a legacy router
    should return error 400 (BadRequest), not error 500.

    Closes-Bug: #1505346
    Change-Id: Ia57e80107bd11ff7b38b89d30279603017913724
    (cherry picked from commit a6d9580f2b95bf2c7c607d4e2671ffbbceae28d5)

tags: added: in-stable-liberty
Ihar Hrachyshka (ihar-hrachyshka)
tags: removed: liberty-backport-potential
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0b1

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

Doug Hellmann (doug-hellmann)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 7.0.1

This issue was fixed in the openstack/neutron 7.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.