L3 agent: explicit call to resync on init may lead to double syncing

[Oleg Bondarev]

Currently L3 agent has an explicit call to self.periodic_sync_routers_task() after initialization.
Given that periodic job spacing is set to 1 second, this may lead to double syncing with server on initialization (especially if there are a lot of routers scheduled to the agent):
 - agent starts, fullsync flag is True
 - periodic_sync_routers_task is called from after_start(), agent requests router info from server, fullsync flag is True
 - periodic_sync_routers_task is called by periodic task framework, fullsync flag is still True, agent requests router info from server once again.
So it's double work on both server and agent sides which might be quite expensive at scale.

The proposal is to just use run_immediately parameter.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/233698

[Assaf Muller (amuller)]

The fix should be backported to L and K.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233698
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cbc268e8395d72c8aa6ea05d90bd22f99df1b8db
Submitter: Jenkins
Branch: master

commit cbc268e8395d72c8aa6ea05d90bd22f99df1b8db
Author: Oleg Bondarev <email address hidden>
Date: Mon Oct 12 18:59:55 2015 +0300

    L3 agent: use run_immediately parameter to sync after start

    Explicit call to periodic resync after start may lead to
    double syncing. See bug for details.

    Closes-Bug: #1505282
    Change-Id: Ib5e481d579039b2c3e87d4f12cad1241d02fe060

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/235846

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/235849

[Ihar Hrachyshka (ihar-hrachyshka)]

I believe it's Juno too. Am I correct?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235849
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c518d6d8c7d9926780ce6f9424038dda10d19945
Submitter: Jenkins
Branch: stable/liberty

commit c518d6d8c7d9926780ce6f9424038dda10d19945
Author: Oleg Bondarev <email address hidden>
Date: Mon Oct 12 18:59:55 2015 +0300

    L3 agent: use run_immediately parameter to sync after start

    Explicit call to periodic resync after start may lead to
    double syncing. See bug for details.

    Closes-Bug: #1505282
    Change-Id: Ib5e481d579039b2c3e87d4f12cad1241d02fe060
    (cherry picked from commit cbc268e8395d72c8aa6ea05d90bd22f99df1b8db)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235846
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=26fa0f939cbd17968d52418e44540d7ac170fc03
Submitter: Jenkins
Branch: stable/kilo

commit 26fa0f939cbd17968d52418e44540d7ac170fc03
Author: Oleg Bondarev <email address hidden>
Date: Mon Oct 12 18:59:55 2015 +0300

    L3 agent: use run_immediately parameter to sync after start

    Explicit call to periodic resync after start may lead to
    double syncing. See bug for details.

    Closes-Bug: #1505282

    Conflicts:

     neutron/agent/l3/agent.py

    Change-Id: Ib5e481d579039b2c3e87d4f12cad1241d02fe060
    (cherry picked from commit cbc268e8395d72c8aa6ea05d90bd22f99df1b8db)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 7.0.1 release.