Provide stevedore aliases for interface_driver option

Bug #1504536 reported by Ihar Hrachyshka on 2015-10-09
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
devstack
Undecided
Martin Hickey
kolla-ansible
Undecided
zhongshengping
neutron
Low
Martin Hickey

Bug Description

Currently, we require to set the full import path for those drivers. It's both not user friendly, and error prone in case we decide later to move the code to some other place.

Changed in neutron:
importance: Undecided → Low
status: New → Confirmed
tags: added: low-hanging-fruit usability
Changed in neutron:
assignee: nobody → Martin Hickey (martin-hickey)
Changed in neutron:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/234991
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c5db6050e5c1988ba845d4b7e50d12057359f19f
Submitter: Jenkins
Branch: master

commit c5db6050e5c1988ba845d4b7e50d12057359f19f
Author: Martin Hickey <email address hidden>
Date: Wed Oct 14 22:32:49 2015 +0100

    Add stevedore aliases for interface_driver configuration

    Changed the interface_driver configure for agents from class
    imports to stevedor aliases. The loading method needed to be
    updated to load as a DriverManager. Backward compatability
    for configuration as class import.

    DocImpact

    Change-Id: Ic349691989484286cd7c60eaf3ad1454c5852d1f
    Closes-Bug: #1504536

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
status: Fix Committed → In Progress
Changed in devstack:
assignee: nobody → Martin Hickey (martin-hickey)
status: New → In Progress

Reviewed: https://review.openstack.org/238115
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c4e0574da1c7f30f9a153e01e7793926454cf2c7
Submitter: Jenkins
Branch: master

commit c4e0574da1c7f30f9a153e01e7793926454cf2c7
Author: Martin Hickey <email address hidden>
Date: Wed Oct 21 15:24:13 2015 +0100

    Update neutron-debug to use stevedore aliases

    Updating neutron-debug as it is importing interface driver classes
    directly and not using the load_driver_interface method.
    Also adds unit tests for the neutron-debug tool.

    Change-Id: Icf095b2182225e63e85d849d83c2cb36b8a39217
    Closes-Bug: #1504536

Changed in neutron:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/237519
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=dca49de22f57f3b2f502380b2cbfedb0dcdba209
Submitter: Jenkins
Branch: master

commit dca49de22f57f3b2f502380b2cbfedb0dcdba209
Author: Martin Hickey <email address hidden>
Date: Tue Oct 20 12:13:19 2015 +0100

    Use stevedore aliases for interface_driver configuration

    interface_driver configuration was updated to use stevedore aliases.
    This patch is to change devstack scripts to now use the aliases
    instead of the previous class imports.

    Closes-Bug: #1504536

    Change-Id: Ic56bfcc1f9da05a999e6fd328e4dd6617e9470ff

Changed in devstack:
status: In Progress → Fix Released

Change abandoned by YAMAMOTO Takashi (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/245630
Reason: i somehow misunderstood [1] was in liberty

[1] Ic349691989484286cd7c60eaf3ad1454c5852d1f

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

Changed in neutron:
status: Fix Committed → Fix Released
zhongshengping (chdzsp) on 2016-12-21
Changed in kolla-ansible:
assignee: nobody → zhongshengping (chdzsp)

Fix proposed to branch: master
Review: https://review.openstack.org/413445

Changed in kolla-ansible:
status: New → In Progress

Reviewed: https://review.openstack.org/413445
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=e9c7d4543abadf82bdf7ae7facfbcc3d9c7a95fc
Submitter: Jenkins
Branch: master

commit e9c7d4543abadf82bdf7ae7facfbcc3d9c7a95fc
Author: ZhongShengping <chdzsp@163.com>
Date: Wed Dec 21 15:03:23 2016 +0800

    Use stevedore aliases for interface_driver configuration

    interface_driver configuration was updated to use stevedore aliases.
    This patch is to change devstack scripts to now use the aliases
    instead of the previous class imports.

    Change-Id: Ida10765f89c07205837e46f8cb445391f0e15373
    Closes-Bug: #1504536

Changed in kolla-ansible:
status: In Progress → Fix Released

This issue was fixed in the openstack/kolla-ansible 4.0.0.0b3 development milestone.

Change abandoned by Kevin Benton (<email address hidden>) on branch: master
Review: https://review.openstack.org/419881
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Reviewed: https://review.openstack.org/419881
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c9d46984096574d130465705ac68b9df272aaa98
Submitter: Jenkins
Branch: master

commit c9d46984096574d130465705ac68b9df272aaa98
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 13 10:47:52 2017 +0000

    Update metering agent to use stevedore alias for driver

    Currently the metering agent is using the old import method,
    use stevedore instead.

    DocImpact

    Two places in the networking guide should change to
    'driver = iptables' from current format.

    Partial-Bug: #1504536
    Change-Id: I1e6d196a3ada8fbfc2b70d6a983984d8db09bbd0

Reviewed: https://review.openstack.org/590514
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=38309ca4dc79e033a7b8384f4e9f1224c5a69524
Submitter: Zuul
Branch: master

commit 38309ca4dc79e033a7b8384f4e9f1224c5a69524
Author: Hongbin Lu <email address hidden>
Date: Thu Aug 9 21:02:01 2018 +0000

    Update metering driver to load interface driver

    Currently the metering iptables driver is using the old method
    to load the interface driver. This patch allows it to load
    interface driver via stevedore aliases.

    Change-Id: I9e3027c1ec695ec3a09db0c53a0388e406e4ced6
    Related-Bug: #1504536

Reviewed: https://review.openstack.org/591488
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ad2c1bc374b6c21439cddc92e97d6f6d941e3507
Submitter: Zuul
Branch: stable/rocky

commit ad2c1bc374b6c21439cddc92e97d6f6d941e3507
Author: Hongbin Lu <email address hidden>
Date: Thu Aug 9 21:02:01 2018 +0000

    Update metering driver to load interface driver

    Currently the metering iptables driver is using the old method
    to load the interface driver. This patch allows it to load
    interface driver via stevedore aliases.

    Change-Id: I9e3027c1ec695ec3a09db0c53a0388e406e4ced6
    Related-Bug: #1504536
    (cherry picked from commit 38309ca4dc79e033a7b8384f4e9f1224c5a69524)

tags: added: in-stable-rocky

Reviewed: https://review.openstack.org/591489
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=75b86f8790ee07a66431ada8d3cd57590e9292eb
Submitter: Zuul
Branch: stable/queens

commit 75b86f8790ee07a66431ada8d3cd57590e9292eb
Author: Hongbin Lu <email address hidden>
Date: Thu Aug 9 21:02:01 2018 +0000

    Update metering driver to load interface driver

    Currently the metering iptables driver is using the old method
    to load the interface driver. This patch allows it to load
    interface driver via stevedore aliases.

    Change-Id: I9e3027c1ec695ec3a09db0c53a0388e406e4ced6
    Related-Bug: #1504536
    (cherry picked from commit 38309ca4dc79e033a7b8384f4e9f1224c5a69524)

tags: added: in-stable-queens

Reviewed: https://review.openstack.org/593599
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dc136094352f02c0b5770630c0464b9922501a1e
Submitter: Zuul
Branch: stable/pike

commit dc136094352f02c0b5770630c0464b9922501a1e
Author: Hongbin Lu <email address hidden>
Date: Thu Aug 9 21:02:01 2018 +0000

    Update metering driver to load interface driver

    Currently the metering iptables driver is using the old method
    to load the interface driver. This patch allows it to load
    interface driver via stevedore aliases.

    Change-Id: I9e3027c1ec695ec3a09db0c53a0388e406e4ced6
    Related-Bug: #1504536
    (cherry-picked from commit 38309ca4dc79e033a7b8384f4e9f1224c5a69524)

tags: added: in-stable-pike
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers