Remove redundant neutron.agent.linux.utils:replace_file()

Bug #1504477 reported by Bogdan Tabor
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Bogdan Tabor

Bug Description

neutron.agent.linux.utils:replace_file() and
neutron.common.utils:replace_file() have same functionality

Changed in neutron:
assignee: nobody → Bogdan Tabor (bogdan-tabor)
status: New → In Progress
Changed in neutron:
importance: Undecided → Low
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/232008
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dad0969a2eed6ee428521784d4d51e3b971c25b4
Submitter: Jenkins
Branch: master

commit dad0969a2eed6ee428521784d4d51e3b971c25b4
Author: Bogdan Tabor <email address hidden>
Date: Wed Oct 7 15:49:08 2015 +0200

    Switch to using neutron.common.utils:replace_file()

    neutron.agent.linux.utils:replace_file() and
    neutron.common.utils:replace_file() have same functionality.

    This is the 1st patch in the series of 4 patches.
    It modifies neutron.common.utils:replace_file(),
    so it can be used by all components as a replacement
    for neutron.agent.linux.utils:replace_file().
    New keyword parameter 'file_mode=0o644' is added
    to neutron.common.utils:replace_file().

    Partial-bug: #1504477
    Change-Id: Id1a7f1236786e8606c91bb9925cd9ac8e95892b3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-vpnaas (master)

Reviewed: https://review.openstack.org/232493
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=56bea059490a8c0875243f3b850ed884871ef222
Submitter: Jenkins
Branch: master

commit 56bea059490a8c0875243f3b850ed884871ef222
Author: Bogdan Tabor <email address hidden>
Date: Thu Oct 8 13:54:53 2015 +0200

    Switch to using neutron.common.utils:replace_file()

    neutron.agent.linux.utils:replace_file() and
    neutron.common.utils:replace_file() have same functionality.

    This is the 2nd patch in the series of 4 patches.

    Partial-bug: #1504477
    Depends-On: Id1a7f1236786e8606c91bb9925cd9ac8e95892b3
    Change-Id: I4352b7f1d6a55e47bbff4f3a1fcf136ed645dcbe

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lbaas (master)

Reviewed: https://review.openstack.org/232454
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=53c17d503a4bec9b1def115098b091e68259666d
Submitter: Jenkins
Branch: master

commit 53c17d503a4bec9b1def115098b091e68259666d
Author: Bogdan Tabor <email address hidden>
Date: Thu Oct 8 12:16:57 2015 +0200

    Switch to using neutron.common.utils:replace_file()

    neutron.agent.linux.utils:replace_file() and
    neutron.common.utils:replace_file() have same functionality.

    This is the 3rd patch in the series of 4 patches.

    Partial-bug: #1504477
    Depends-On: Id1a7f1236786e8606c91bb9925cd9ac8e95892b3
    Change-Id: Id0eb6829ce75df5ffccc354adfe2f0ccb19ed9fd

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/233558
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ae3f03396d1b6fe09d60b5606b75a02a42c5ae3f
Submitter: Jenkins
Branch: master

commit ae3f03396d1b6fe09d60b5606b75a02a42c5ae3f
Author: Bogdan Tabor <email address hidden>
Date: Mon Oct 12 12:07:54 2015 +0200

    Switch to using neutron.common.utils:replace_file()

    neutron.agent.linux.utils:replace_file() and
    neutron.common.utils:replace_file() have same functionality.

    This is the final patch in a series of 4 patches.
    It marks neutron.agent.linux.utils:replace_file() for removal.

    Closes-bug: #1504477
    Depends-On: Id0eb6829ce75df5ffccc354adfe2f0ccb19ed9fd
    Depends-On: I4352b7f1d6a55e47bbff4f3a1fcf136ed645dcbe
    Change-Id: I26b0a4d6105420a2c242b81a4cd58e0adef4cbec

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/295912
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=25fdc2a9f9bdeacd91ab2f9317c5dff1d8ec5977
Submitter: Jenkins
Branch: master

commit 25fdc2a9f9bdeacd91ab2f9317c5dff1d8ec5977
Author: Dariusz Smigiel (dasm) <email address hidden>
Date: Tue Mar 22 15:41:02 2016 +0000

    Remove deprecated method from agent utils file

    Commit I26b0a4d6105420a2c242b81a4cd58e0adef4cbec marked method
    replace_file as redundant. Functionality was moved to
    neutron.common.utils:replace_file

    Related-Bug: #1504477
    Change-Id: I77f907bee20bf921d4127502c1ce8156425e158a

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.