Update network with New Qos-Policy isn't working with SR-IOV agent

Bug #1504166 reported by Amichay Polishuk
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
yalei wang

Bug Description

The User try to switch Qos-Policy on Exist Network to another Qos-Policy.

#neutron net-update network_1 --qos-policy Policy_BW_5G_4G

No Indication in log, The "update" Action Failed!

My Environment:

- 2 Servers (All in one and Compute).
- OS : CentOS Linux release 7.1.1503 (Core)
- Kernel version : 3.10.0-123.el7.x86_64
- Openstack Version : Trunk

tags: added: qos
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Please provide logs and config files you use.

Changed in neutron:
status: New → Incomplete
Revision history for this message
Moshe Levi (moshele) wrote :

@Ihar, I don't think log will help
The issue is same as this one
https://bugs.launchpad.net/neutron/+bug/1486028

Miguel fixed it to OVS, we need to add network_update support to sr-iov agnet

patch that fix it to OVS https://review.openstack.org/#/c/215608/

summary: - Update network with New Qos-Policy isn't working
+ Update network with New Qos-Policy isn't working with SR-IOV agent
yalei wang (yalei-wang)
Changed in neutron:
assignee: nobody → yalei wang (yalei-wang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/233499

Changed in neutron:
status: Incomplete → In Progress
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

This bug is critical for proper sr-iov agent functioning in regards to QoS. You may even consider it a security threat because you don't apply the expected bandwidth limit to ports. I raised the Importance, and target it for M1.

Changed in neutron:
importance: Undecided → High
milestone: none → mitaka-1
Changed in neutron:
milestone: mitaka-1 → mitaka-2
Changed in neutron:
assignee: yalei wang (yalei-wang) → Moshe Levi (moshele)
Changed in neutron:
assignee: Moshe Levi (moshele) → yalei wang (yalei-wang)
Changed in neutron:
milestone: mitaka-2 → mitaka-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/233499
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7084fa8a17510a7a1a5221736fb3bd330b0ad86c
Submitter: Jenkins
Branch: master

commit 7084fa8a17510a7a1a5221736fb3bd330b0ad86c
Author: Yalei Wang <email address hidden>
Date: Mon Nov 30 22:13:08 2015 +0800

    Add network_update RPC into SR-IOV agent

    SR-IOV agent doesn't listen for network_update notification, but it's
    desired in QOS when network updated with a new QOS policy. This patch
    adds it into this agent.

    Change-Id: I06a7ca411da31bccabddec9c0adca6b8e6eab7cc
    Closes-Bug: #1504166

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/285353

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0b3

This issue was fixed in the openstack/neutron 8.0.0.0b3 development milestone.

tags: added: liberty-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/285353
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1b10be882586aa497765f181235bdc7f02fdb9ca
Submitter: Jenkins
Branch: stable/liberty

commit 1b10be882586aa497765f181235bdc7f02fdb9ca
Author: Yalei Wang <email address hidden>
Date: Mon Nov 30 22:13:08 2015 +0800

    Add network_update RPC into SR-IOV agent

    SR-IOV agent doesn't listen for network_update notification, but it's
    desired in QOS when network updated with a new QOS policy. This patch
    adds it into this agent.

    Conflicts:
     neutron/tests/unit/plugins/ml2/drivers/mech_sriov/agent/test_sriov_nic_agent.py

    Change-Id: I06a7ca411da31bccabddec9c0adca6b8e6eab7cc
    Closes-Bug: #1504166
    (cherry picked from commit 7084fa8a17510a7a1a5221736fb3bd330b0ad86c)

tags: added: in-stable-liberty
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 7.1.0

This issue was fixed in the openstack/neutron 7.1.0 release.

tags: removed: liberty-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.