oslo.db no longer requires testresources and testscenarios packages

Bug #1503501 reported by Davanum Srinivas (DIMS)
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Davanum Srinivas (DIMS)
Glance
Fix Released
High
Mike Fedosin
Ironic
Fix Released
High
Lucas Alvares Gomes
OpenStack Compute (nova)
Fix Released
High
Davanum Srinivas (DIMS)
OpenStack Heat
Fix Released
High
Sergey Kraynev
Liberty
Fix Released
Undecided
Unassigned
Sahara
Fix Released
High
Michael McCune
Liberty
Fix Released
High
Sergey Lukjanov
Mitaka
Fix Released
High
Michael McCune
neutron
Fix Released
High
Davanum Srinivas (DIMS)

Bug Description

As of https://review.openstack.org/#/c/217347/ oslo.db no longer has testresources or testscenarios in its requirements, So next release of oslo.db will break several projects. These project that use fixtures from oslo.db should add these to their requirements if they need it.

Example from Nova:
${PYTHON:-python} -m subunit.run discover -t ./ ${OS_TEST_PATH:-./nova/tests} --list
---Non-zero exit code (2) from test listing.
error: testr failed (3)
import errors ---
Failed to import test module: nova.tests.unit.db.test_db_api
Traceback (most recent call last):
  File "/home/travis/build/dims/nova/.tox/py27/lib/python2.7/site-packages/unittest2/loader.py", line 456, in _find_test_path
    module = self._get_module_from_name(name)
  File "/home/travis/build/dims/nova/.tox/py27/lib/python2.7/site-packages/unittest2/loader.py", line 395, in _get_module_from_name
    __import__(name)
  File "nova/tests/unit/db/test_db_api.py", line 31, in <module>
    from oslo_db.sqlalchemy import test_base
  File "/home/travis/build/dims/nova/.tox/py27/src/oslo.db/oslo_db/sqlalchemy/test_base.py", line 17, in <module>
    import testresources
ImportError: No module named testresources

https://travis-ci.org/dims/nova/jobs/83992423

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/231789

Changed in cinder:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: New → In Progress
Changed in neutron:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/231794

Changed in neutron:
importance: Undecided → High
Changed in heat:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Sergey Kraynev (skraynev)
milestone: none → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/231860

Changed in heat:
status: Confirmed → In Progress
Changed in neutron:
assignee: Davanum Srinivas (DIMS) (dims-v) → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/232055

Changed in nova:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/232071

Changed in heat:
assignee: Sergey Kraynev (skraynev) → Davanum Srinivas (DIMS) (dims-v)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Davanum Srinivas (dims) (<email address hidden>) on branch: master
Review: https://review.openstack.org/232071
Reason: OOOOOPppppssss! sorry.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/231794
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=86ad967e40c2c6752ec0fb46cfd3098ede0c7178
Submitter: Jenkins
Branch: master

commit 86ad967e40c2c6752ec0fb46cfd3098ede0c7178
Author: Davanum Srinivas <email address hidden>
Date: Tue Oct 6 18:47:00 2015 -0700

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    Change-Id: I7dfbf240333095d91a414ba15a439bdc4804eb25

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/231789
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ec40c3b6ddbfa4912ca6e612558efaef6043f3ae
Submitter: Jenkins
Branch: master

commit ec40c3b6ddbfa4912ca6e612558efaef6043f3ae
Author: Davanum Srinivas <email address hidden>
Date: Tue Oct 6 18:45:12 2015 -0700

    Add testresources and testscenarios used by oslo.db fixture

    If we use oslo.db fixtures, we'll need these 2 packages or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    Change-Id: I8facdaf69c79b1b1ae4f9f64e9856e12f14440ed

Changed in cinder:
status: In Progress → Fix Committed
Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Davanum Srinivas (DIMS) (dims-v)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/232055
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4bcc26487837b7ece7797f88622dea1b6d09bd94
Submitter: Jenkins
Branch: master

commit 4bcc26487837b7ece7797f88622dea1b6d09bd94
Author: Davanum Srinivas <email address hidden>
Date: Wed Oct 7 08:11:35 2015 -0700

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    Change-Id: I176c85551007d3d9e7de8896ad12e9b87ff278d8

Changed in nova:
status: In Progress → Fix Committed
Changed in heat:
assignee: Davanum Srinivas (DIMS) (dims-v) → Sergey Kraynev (skraynev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/231860
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=a7368fb68e8c1cccbb601aa1aad444248c645c25
Submitter: Jenkins
Branch: master

commit a7368fb68e8c1cccbb601aa1aad444248c645c25
Author: Sergey Kraynev <email address hidden>
Date: Wed Oct 7 02:59:01 2015 -0400

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need these 2 packages or
    the next version of oslo.db release will break us.

    Change-Id: I71f001c8b75ad52e68ccab8f07cd8946772fd03b
    Closes-Bug: #1503501

Changed in heat:
status: In Progress → Fix Committed
Changed in ironic:
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/233719

Changed in ironic:
status: New → In Progress
Mike Fedosin (mfedosin)
Changed in glance:
assignee: nobody → Mike Fedosin (mfedosin)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/233719
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=e7e0a056b4e2060ab53f2402c837a55e440edaaf
Submitter: Jenkins
Branch: master

commit e7e0a056b4e2060ab53f2402c837a55e440edaaf
Author: Lucas Alvares Gomes <email address hidden>
Date: Mon Oct 12 17:46:37 2015 +0100

    Add testresources and testscenarios used by oslo.db fixture

    oslo.db fixtures need these 2 packages and is breaking us.

    Closes-Bug: #1503501
    Change-Id: I75757b5bd7d9e75ca37d1b9a1efff810ba84b5df

Changed in ironic:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/233841
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=693b50b2e79c9f3a00aa9311651972d9e67e1bcf
Submitter: Jenkins
Branch: master

commit 693b50b2e79c9f3a00aa9311651972d9e67e1bcf
Author: Mike Fedosin <email address hidden>
Date: Tue Oct 13 00:33:27 2015 +0300

    Add testresources and testscenarios used by oslo.db fixture

    If we use oslo.db fixtures, we'll need these 2 packages or
    the next version of oslo.db release will break us.

    Change-Id: I7c0d2f6dabc20bd4ff0d29d3b47b948aa24ea56b
    Closes-Bug: #1503501

Changed in glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/233950

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-vpnaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/233953

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/liberty)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/233950
Reason: to be squashed

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/233931
Reason: superseded by:

https://review.openstack.org/#/c/232270/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/234115

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/234118

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/234166

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-vpnaas (master)

Reviewed: https://review.openstack.org/233953
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=6626a8529c256758f464eef8361913523a360961
Submitter: Jenkins
Branch: master

commit 6626a8529c256758f464eef8361913523a360961
Author: armando-migliaccio <email address hidden>
Date: Mon Oct 12 23:00:06 2015 -0700

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    Change-Id: I0075968c5d6ee41fa737658b683fa1d68aa44fca
    Closes-Bug: #1503501

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/liberty)

Change abandoned by Thierry Carrez (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/234115
Reason: Now part of the omnibus fix at https://review.openstack.org/#/c/234166/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/liberty)

Reviewed: https://review.openstack.org/233842
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=c5b6901527b8b4a1250bdc179405c8af66fbae7e
Submitter: Jenkins
Branch: stable/liberty

commit c5b6901527b8b4a1250bdc179405c8af66fbae7e
Author: Mike Fedosin <email address hidden>
Date: Tue Oct 13 00:33:27 2015 +0300

    Add testresources and testscenarios used by oslo.db fixture

    If we use oslo.db fixtures, we'll need these 2 packages or
    the next version of oslo.db release will break us.

    Change-Id: I7c0d2f6dabc20bd4ff0d29d3b47b948aa24ea56b
    Closes-Bug: #1503501

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (stable/liberty)

Change abandoned by John Griffith (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/234118
Reason: Squashed this with the other needed fix:
https://review.openstack.org/#/c/233668/

Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
milestone: none → liberty-rc3
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-rc3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/234329

Changed in sahara:
assignee: nobody → Michael McCune (mimccune)
Changed in sahara:
status: New → In Progress
Changed in sahara:
importance: Undecided → High
Changed in sahara:
milestone: none → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/liberty)

Reviewed: https://review.openstack.org/234166
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6df6ad3ff32f2b1fe2978df1032002548ad8eb66
Submitter: Jenkins
Branch: stable/liberty

commit 6df6ad3ff32f2b1fe2978df1032002548ad8eb66
Author: Davanum Srinivas <email address hidden>
Date: Wed Oct 7 08:11:35 2015 -0700

    Omnibus stable/liberty fix

    There are currently 3 different blocking issues in stable/liberty due
    to library releases: webob 1.5, oslo.db 3.0.0, and
    oslo.versionedobjects 0.11.0. This is a squashed fix for all of them
    as none can land without the others.

    Issue #1 - oslo.db

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    (Cherry-picked from 4bcc26487837b7ece7797f88622dea1b6d09bd94)

    Closes-Bug: #1503501

    Issue #2 - oslo.versionedobjects

    Drop unused obj_to_primitive() override

    This was a band-aid override until o.vo gained the obj_relationships fix
    that this method overrides. That has been in place since o.vo 0.8.0, which
    means this is long since no longer necessary (and is actually blocking our
    ability to absorb bug fixes to this code in o.vo). Further, we no longer
    use this directly because we're doing backports based on version manifests,
    which means we no longer consult child_versions _or_ obj_relationships.

    (cherry picked from commit 142f1d9cc4ace90956c665c40b1f78795f9f7e29)

    Issue #3 - webob

    Default ConvertedException code to 500

    webob 1.5.0 released on 10/11 has change f6c749011 which
    strictly enforces status codes in exceptions, and 0 is not
    a valid status code so tests fail.

    Change the default to 500 to match the default in the parent
    class in webob.

    Closes-Bug: #1505153
    (cherry picked from commit 10438c0fc34bd088e018e1a5e8ec57b396528792)

    Change-Id: I1e06e77308a7dd23209124f0807d61fb52470188

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/liberty)

Reviewed: https://review.openstack.org/234329
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=61026d4e4f2a58dd84ffb2e4e40ab99860b9316a
Submitter: Jenkins
Branch: stable/liberty

commit 61026d4e4f2a58dd84ffb2e4e40ab99860b9316a
Author: Davanum Srinivas <email address hidden>
Date: Tue Oct 6 18:45:12 2015 -0700

    Squashed commit of WebOb 1.5 and oslo.db fixes

    Add testresources and testscenarios used by oslo.db fixture

    If we use oslo.db fixtures, we'll need these 2 packages or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    Change-Id: I8facdaf69c79b1b1ae4f9f64e9856e12f14440ed
    (cherry picked from commit ec40c3b6ddbfa4912ca6e612558efaef6043f3ae)

    Fix test_misc for WebOb 1.5

    WebOb 1.5 was released at 2015-10-11. With this new version,
    webob.exc.WSGIHTTPException() constructor now fails with a KeyError
    when the HTTP status code is 0.

    test_exceptions_raise() of test_misc tries to instanciate all
    exceptions of cinder.exception. The problem is that
    ConvertedException uses a default HTTP status code of 0.

    Modify the default HTTP status code of ConvertedException to 400 to
    fix the unit test. The bug is only in the test,
    cinder/api/openstack/wsgi.py copies an existing HTTP code:

        Fault(exception.ConvertedException(code=ex_value.code, ...)

    Closes-Bug: #1505153
    Change-Id: I1aec8038774828d48da4b0e831b390e33243809a
    (cherry picked from commit 867fccf833ffc597aa986cb6ff1b3b5c1101b9ba)

    Change default Exception code to 500

    As a part of the fix for LP#1505153, the invalid
    response of 0 was changed to 400 to fix a running
    issue with the new version of WebOb.

    It was pointed out after the fact however that a
    500 might be more appropriate here.

    Additionally, other projects have implemented a 500
    as the default so for the sake of consistency we should
    consider doing the same.

    This patch just changes the 400 to a 500 as the default
    code.

    Conflicts:
            cinder/tests/unit/test_exception.py

    NOTE(mriedem): The conflict is due to 17802086f not being
    in stable/liberty.

    Change-Id: Ie486dc49c927f9b50f07c1fc562e89c090924a40
    Closes-Bug: #1505488
    (cherry picked from commit 9a7cbe540c94d54194194f4747a52b8211f6372e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (stable/liberty)

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/233668

Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-rc3
status: Fix Committed → Fix Released
Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-vpnaas (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/234426

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/234504

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/234326
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=a7ecd00a99fc26dce1e210d7e67e03efe752b5d3
Submitter: Jenkins
Branch: master

commit a7ecd00a99fc26dce1e210d7e67e03efe752b5d3
Author: Michael McCune <email address hidden>
Date: Tue Oct 13 12:24:38 2015 -0400

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    manually picked from: I176c85551007d3d9e7de8896ad12e9b87ff278d8
    for more information see: I1e06e77308a7dd23209124f0807d61fb52470188

    Change-Id: Ib511ec705206b2168fe18f5870ca81d59b7ba89f
    Closes-Bug: 1503501

Changed in sahara:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-rc3
Changed in nova:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)
Download full text (4.2 KiB)

Reviewed: https://review.openstack.org/232270
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6dcfe3a9362ae5fcf18e5cfb59663e43446cd59c
Submitter: Jenkins
Branch: stable/liberty

commit 6dcfe3a9362ae5fcf18e5cfb59663e43446cd59c
Author: Kevin Benton <email address hidden>
Date: Tue Oct 6 19:28:47 2015 -0700

    Mock oslo policy HTTPCheck instead of urllib

    We were mocking internal behavior of oslo policy by
    patching urllib. This will break with the upcoming oslo
    release that switches to requests.

    This patch changes the mock to the HTTPCheck level and we
    can leave implementation details testing up to oslo_policy.

    Change-Id: I07957f01307e25f1547197c720eea6e3e7f0ef5a
    Closes-Bug: #1503890
    (cherry picked from commit a0f1d9d6de1560be91d3001c8ac9f880a7a5a7e0)

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    Change-Id: I7dfbf240333095d91a414ba15a439bdc4804eb25
    (cherry picked from commit 86ad967e40c2c6752ec0fb46cfd3098ede0c7178)

    Fix functional test_server tests

    Now oslo.service 0.10.0 no longer sends SIGHUP to parent and
    children services.

    This was a chance introduced by 286a6ea, and since it invalidated
    the very logic under test, this must be revised.

    (cherry picked from commit 090fe713592c2b6398d999bfa03b80cbb2054609)

    Change-Id: I18a11283925369bc918002477774f196010a1bc3
    Closes-bug: #1505438
    (cherry picked from commit 090fe713592c2b6398d999bfa03b80cbb2054609)

    Make test_server work with older versions of oslo.service

    Change I18a11283925369bc918002477774f196010a1bc3 fixed the test for
    oslo.service >= 0.10.0, but it also broke it for older versions of
    oslo.service. Since the library has minimal version of >= 0.7.0 in
    requirements.txt, test should pass for those versions too.

    Now, instead of validating that either reset() or restart() of workers
    are triggered on SIGHUP, just validate that .start() is triggered the
    expected number of times (either way, no matter how oslo.service decide
    to clean up the children, they exit and then are respawned).

    Change-Id: I41f9d3af780b3178b075bc1e7084f417a2bd1378
    Closes-Bug: #1505645
    (cherry picked from commit 7bb40921660cf29beb68e338e205499efd6ffa36)

    Fixed multiple py34 gate issues

    1. Scope mock of 'open' to module

    By mocking 'open' at the module level, we can avoid affecting
    'open' calls from other modules.

    2. Stop using LOG.exception in contexts with no sys.exc_info set

    Python 3.4 logger fills in record.exc_info with sys.exc_info() result
    [1], and then it uses it to determine the current exception [2] to
    append to the log message. Since there is no exception, exc_info[1] is
    None, and we get AttributeError inside traceback module.

    It's actually a bug in Python interpreter that it attempt to access the
    attribute when there is no exception. It turns out that it's fixed in
    latest master of cPyth...

Read more...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-vpnaas (stable/liberty)

Reviewed: https://review.openstack.org/234426
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=1ab399faa6a907bb67e981b728dd06369f0a66d8
Submitter: Jenkins
Branch: stable/liberty

commit 1ab399faa6a907bb67e981b728dd06369f0a66d8
Author: armando-migliaccio <email address hidden>
Date: Mon Oct 12 23:00:06 2015 -0700

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    Change-Id: I0075968c5d6ee41fa737658b683fa1d68aa44fca
    Closes-Bug: #1503501
    (cherry picked from commit 6626a8529c256758f464eef8361913523a360961)

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/234709

Changed in glance:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (stable/liberty)

Reviewed: https://review.openstack.org/234504
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=d73130fb506d0cb3c464b5e9e4c7eba9bbe7dfdb
Submitter: Jenkins
Branch: stable/liberty

commit d73130fb506d0cb3c464b5e9e4c7eba9bbe7dfdb
Author: Lucas Alvares Gomes <email address hidden>
Date: Mon Oct 12 17:46:37 2015 +0100

    Add testresources and testscenarios used by oslo.db fixture

    oslo.db fixtures need these 2 packages and is breaking us.

    Closes-Bug: #1503501
    Change-Id: I75757b5bd7d9e75ca37d1b9a1efff810ba84b5df
    (cherry picked from commit e7e0a056b4e2060ab53f2402c837a55e440edaaf)

Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-rc3 → 12.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235181

Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc3 → 7.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235282

Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-rc3 → 7.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235300

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-vpnaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235318

Thierry Carrez (ttx)
Changed in glance:
milestone: liberty-rc3 → 11.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235346

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)
Download full text (7.3 KiB)

Reviewed: https://review.openstack.org/235282
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0f7d289a2899082802499a498cba34a3abca321d
Submitter: Jenkins
Branch: master

commit 61026d4e4f2a58dd84ffb2e4e40ab99860b9316a
Author: Davanum Srinivas <email address hidden>
Date: Tue Oct 6 18:45:12 2015 -0700

    Squashed commit of WebOb 1.5 and oslo.db fixes

    Add testresources and testscenarios used by oslo.db fixture

    If we use oslo.db fixtures, we'll need these 2 packages or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    Change-Id: I8facdaf69c79b1b1ae4f9f64e9856e12f14440ed
    (cherry picked from commit ec40c3b6ddbfa4912ca6e612558efaef6043f3ae)

    Fix test_misc for WebOb 1.5

    WebOb 1.5 was released at 2015-10-11. With this new version,
    webob.exc.WSGIHTTPException() constructor now fails with a KeyError
    when the HTTP status code is 0.

    test_exceptions_raise() of test_misc tries to instanciate all
    exceptions of cinder.exception. The problem is that
    ConvertedException uses a default HTTP status code of 0.

    Modify the default HTTP status code of ConvertedException to 400 to
    fix the unit test. The bug is only in the test,
    cinder/api/openstack/wsgi.py copies an existing HTTP code:

        Fault(exception.ConvertedException(code=ex_value.code, ...)

    Closes-Bug: #1505153
    Change-Id: I1aec8038774828d48da4b0e831b390e33243809a
    (cherry picked from commit 867fccf833ffc597aa986cb6ff1b3b5c1101b9ba)

    Change default Exception code to 500

    As a part of the fix for LP#1505153, the invalid
    response of 0 was changed to 400 to fix a running
    issue with the new version of WebOb.

    It was pointed out after the fact however that a
    500 might be more appropriate here.

    Additionally, other projects have implemented a 500
    as the default so for the sake of consistency we should
    consider doing the same.

    This patch just changes the 400 to a 500 as the default
    code.

    Conflicts:
            cinder/tests/unit/test_exception.py

    NOTE(mriedem): The conflict is due to 17802086f not being
    in stable/liberty.

    Change-Id: Ie486dc49c927f9b50f07c1fc562e89c090924a40
    Closes-Bug: #1505488
    (cherry picked from commit 9a7cbe540c94d54194194f4747a52b8211f6372e)

commit 5268a8d61beee1b18d14fd3738e763a0a61b00f1
Author: Xing Yang <email address hidden>
Date: Wed Sep 23 11:22:43 2015 -0400

    Fix VMAX live migration problem

    Live migration fails for VMAX because the host is not taken into
    account when determining whether a volume is masked or not. For
    live migration it is necessary to know which host a volume is masked
    to. This patch fixes the problem by checking which host the volume
    is masked to.

    Change-Id: I693e29f7b26145bd1fd357b7d98377e26bfdfed8
    Closes-Bug: #1498964
    (cherry picked from commit 794e27c78255c94084b54821d44a36fd8f2096d7)

commit 2c09897f569a786998fd1ab50e42d81e9a2093a0
Author: OpenStack Proposal Bot <email address hidden>
Date: Sat Oct 3 06:22:46 2015 +0000

    Imported Tr...

Read more...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)
Download full text (16.6 KiB)

Reviewed: https://review.openstack.org/235300
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=140ccc36d172bead2605968b3d61b36cca8a0040
Submitter: Jenkins
Branch: master

commit 6dcfe3a9362ae5fcf18e5cfb59663e43446cd59c
Author: Kevin Benton <email address hidden>
Date: Tue Oct 6 19:28:47 2015 -0700

    Mock oslo policy HTTPCheck instead of urllib

    We were mocking internal behavior of oslo policy by
    patching urllib. This will break with the upcoming oslo
    release that switches to requests.

    This patch changes the mock to the HTTPCheck level and we
    can leave implementation details testing up to oslo_policy.

    Change-Id: I07957f01307e25f1547197c720eea6e3e7f0ef5a
    Closes-Bug: #1503890
    (cherry picked from commit a0f1d9d6de1560be91d3001c8ac9f880a7a5a7e0)

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    Change-Id: I7dfbf240333095d91a414ba15a439bdc4804eb25
    (cherry picked from commit 86ad967e40c2c6752ec0fb46cfd3098ede0c7178)

    Fix functional test_server tests

    Now oslo.service 0.10.0 no longer sends SIGHUP to parent and
    children services.

    This was a chance introduced by 286a6ea, and since it invalidated
    the very logic under test, this must be revised.

    (cherry picked from commit 090fe713592c2b6398d999bfa03b80cbb2054609)

    Change-Id: I18a11283925369bc918002477774f196010a1bc3
    Closes-bug: #1505438
    (cherry picked from commit 090fe713592c2b6398d999bfa03b80cbb2054609)

    Make test_server work with older versions of oslo.service

    Change I18a11283925369bc918002477774f196010a1bc3 fixed the test for
    oslo.service >= 0.10.0, but it also broke it for older versions of
    oslo.service. Since the library has minimal version of >= 0.7.0 in
    requirements.txt, test should pass for those versions too.

    Now, instead of validating that either reset() or restart() of workers
    are triggered on SIGHUP, just validate that .start() is triggered the
    expected number of times (either way, no matter how oslo.service decide
    to clean up the children, they exit and then are respawned).

    Change-Id: I41f9d3af780b3178b075bc1e7084f417a2bd1378
    Closes-Bug: #1505645
    (cherry picked from commit 7bb40921660cf29beb68e338e205499efd6ffa36)

    Fixed multiple py34 gate issues

    1. Scope mock of 'open' to module

    By mocking 'open' at the module level, we can avoid affecting
    'open' calls from other modules.

    2. Stop using LOG.exception in contexts with no sys.exc_info set

    Python 3.4 logger fills in record.exc_info with sys.exc_info() result
    [1], and then it uses it to determine the current exception [2] to
    append to the log message. Since there is no exception, exc_info[1] is
    None, and we get AttributeError inside traceback module.

    It's actually a bug in Python interpreter that it attempt to access the
    attribute when there is no exception. It turns out that it's fixed in
    latest master of cPython [3] (...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/235540

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on sahara (stable/liberty)

Change abandoned by Sergey Lukjanov (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/235540

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-vpnaas (master)

Reviewed: https://review.openstack.org/235318
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=9a1860cc8d463c4d9e85d1098c183e43f6d21f15
Submitter: Jenkins
Branch: master

commit 1ab399faa6a907bb67e981b728dd06369f0a66d8
Author: armando-migliaccio <email address hidden>
Date: Mon Oct 12 23:00:06 2015 -0700

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    Change-Id: I0075968c5d6ee41fa737658b683fa1d68aa44fca
    Closes-Bug: #1503501
    (cherry picked from commit 6626a8529c256758f464eef8361913523a360961)

commit cc8703abe4d24d403d1eec6269ecb1c74a8c747c
Author: Henry Gessau <email address hidden>
Date: Sun Sep 27 16:04:20 2015 -0400

    Tag the alembic migration revisions for Liberty

    Previously when we had one repo with one alembic branch we would
    create a milestone revision on that single branch. Now we have
    multiple repos and expand/contract branches for each repo.

    So from now on we tag the final revision on every branch when we make
    a milestone release.

    Partial-Bug: #1499033

    Depends-On: I38623986dd574bec01fe147f9c6a747f3f512bb7

    Change-Id: I237cd984273212da930794414c761f7748e6bd0c
    (cherry picked from commit eac6ea6ef23d2734fd664e8c70a7a599a9f8bcff)

commit 0c4e3bd61f4a55fcc74542761ae64ba8e510969b
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Sep 25 13:03:07 2015 +0200

    Use stable/liberty branch for neutron dep

    Change-Id: I04cb52ab5e918059c8f19882d6a95106344b52e6

commit ffe66482371c99bb3c4d1b253c3b5f1015629863
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Sep 24 17:12:16 2015 +0200

    Update defaultbranch in .gitreview to stable/liberty

    Change-Id: Ic83d51a5740b56679f46985ed4b4a824082d4149

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (stable/liberty)

Reviewed: https://review.openstack.org/235133
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=7ab41f1384e2638020a02e7ae875cd46297b5b04
Submitter: Jenkins
Branch: stable/liberty

commit 7ab41f1384e2638020a02e7ae875cd46297b5b04
Author: Thierry Carrez <email address hidden>
Date: Thu Oct 15 09:35:41 2015 +0200

    Switch to post-versioning

    No longer mention next version on setup.cfg on stable branch.

    Add testresources used by oslo.db fixture
    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.
    for more information see: I1e06e77308a7dd23209124f0807d61fb52470188

    Closes-Bug: 1503501

    Change-Id: Iea3c737bc51a599d756514b82b1f4102b389a2c2

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (stable/liberty)

Change abandoned by Roman Podoliaka (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/234709

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/liberty)

Reviewed: https://review.openstack.org/235246
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6d611b7f9758b04cfe67bd9533d59044a7844bc7
Submitter: Jenkins
Branch: stable/liberty

commit 6d611b7f9758b04cfe67bd9533d59044a7844bc7
Author: Sirushti Murugesan <email address hidden>
Date: Thu Oct 8 09:13:04 2015 +0530

    Merge of three backported commits for fixing liberty gate

    First patch description:

    Use LOG.error when no exception handler is used

    There's no need to use LOG.exception here since sys.exc_info()
    results in (None, None, None) and thus would effectively just
    be LOG.error.

    Also, the failure of invoking LOG.exception outside of an
    exception handler is due to a bug in Python3[1]. The fix for
    that is only available in Python3.5.

    [1] http://bugs.python.org/issue17911

    Closes-Bug: #1482261
    (cherry picked from commit f5c415accfff2ad399194b30b9408a903042f009)

    Second patch description:

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need these 2 packages or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    (cherry picked from commit a7368fb68e8c1cccbb601aa1aad444248c645c25)

    Third patch description:

    Switch to post-versioning

    No longer mention next version on setup.cfg on stable branch.

    Change-Id: Ib40c664a4f0e01cd27e1f24cfdbc9de278aece42

Changed in ironic:
status: Fix Committed → Fix Released
status: Fix Released → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)
Download full text (4.1 KiB)

Reviewed: https://review.openstack.org/235346
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=431fa95ecf92a9ebb7082f829c0a99f958363cc3
Submitter: Jenkins
Branch: master

commit 69516fad5f651a085a047a337a05c58b39023c1b
Author: Mike Fedosin <email address hidden>
Date: Mon Oct 12 15:34:54 2015 +0300

    Add 'deactivated' status to image schema.

    New 'deactivated' status was introduced in Kilo release,
    but it doesn't listed in available image statuses in the schema.

    It leads to issues on the client side, when it can't validate
    the image with this status against the schema and returns the error.

    Change-Id: I5ec264614ae7ecf54b846ad0600442a18c61d24c
    Closes-bug: #1505218
    Related-bug: #1505134

commit c5b6901527b8b4a1250bdc179405c8af66fbae7e
Author: Mike Fedosin <email address hidden>
Date: Tue Oct 13 00:33:27 2015 +0300

    Add testresources and testscenarios used by oslo.db fixture

    If we use oslo.db fixtures, we'll need these 2 packages or
    the next version of oslo.db release will break us.

    Change-Id: I7c0d2f6dabc20bd4ff0d29d3b47b948aa24ea56b
    Closes-Bug: #1503501

commit fc32f0554de0ba7773d98e6828da157ca7c66002
Author: Mike Fedosin <email address hidden>
Date: Sun Sep 20 17:01:22 2015 +0300

    Cleanup chunks for deleted image if token expired

    In patch I47229b366c25367ec1bd48aec684e0880f3dfe60 it was
    introduced the logic that if image was deleted during file
    upload when we want to update image status from 'saving'
    to 'active' it's expected to get Duplicate error and delete
    stale chunks after that. But if user's token is expired
    there will be Unathorized exception and chunks will stay
    in store and clog it.
    And when, the upload operation for such an image is
    completed the operator configured quota can be exceeded.

    This patch fixes the issue of left over chunks for an image
    which was deleted from saving status, by correctly handle
    auth exceptions from registry server.

    Partial-bug: #1498163

    Change-Id: I17a66eca55bfb83107046910e69c4da01415deec

commit ca8d909a61ba335805d8d17070230ce9478a000d
Author: Stuart McLaren <email address hidden>
Date: Wed Sep 30 16:54:12 2015 +0000

    Download forbidden when get_image_location is set.

    When using v2 an attempt to download an image would return a 403 if the
    get_image_location policy was set.

    Note: We had been returning both 404 and 204 when no data was
    available. There was no way to detect the 404 case without trying to
    access the image locations so I've standardized on 204.

    Change-Id: I658b08a35d3a8cb8a7096baf716ccb3d6e7d9abf
    Closes-bug: 1501672
    (cherry picked from commit b47f625443c3b46483506926f31fee42478705d4)

commit ebdf076cc9bd5d9239cdc96c6e7cecc72f852bbb
Author: Mike Fedosin <email address hidden>
Date: Thu Oct 1 18:28:48 2015 +0300

    Catch NotAuthenticated exception in import task

    If glance uses registry as data_api then it's possible
    that token may expire during image import task and Glance
    will have NotUauthenticated exception.

    This code adds...

Read more...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)
Download full text (10.6 KiB)

Reviewed: https://review.openstack.org/235181
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d8a3b9d6408627ce9a293d1e62d003757af655a1
Submitter: Jenkins
Branch: master

commit 6df6ad3ff32f2b1fe2978df1032002548ad8eb66
Author: Davanum Srinivas <email address hidden>
Date: Wed Oct 7 08:11:35 2015 -0700

    Omnibus stable/liberty fix

    There are currently 3 different blocking issues in stable/liberty due
    to library releases: webob 1.5, oslo.db 3.0.0, and
    oslo.versionedobjects 0.11.0. This is a squashed fix for all of them
    as none can land without the others.

    Issue #1 - oslo.db

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    (Cherry-picked from 4bcc26487837b7ece7797f88622dea1b6d09bd94)

    Closes-Bug: #1503501

    Issue #2 - oslo.versionedobjects

    Drop unused obj_to_primitive() override

    This was a band-aid override until o.vo gained the obj_relationships fix
    that this method overrides. That has been in place since o.vo 0.8.0, which
    means this is long since no longer necessary (and is actually blocking our
    ability to absorb bug fixes to this code in o.vo). Further, we no longer
    use this directly because we're doing backports based on version manifests,
    which means we no longer consult child_versions _or_ obj_relationships.

    (cherry picked from commit 142f1d9cc4ace90956c665c40b1f78795f9f7e29)

    Issue #3 - webob

    Default ConvertedException code to 500

    webob 1.5.0 released on 10/11 has change f6c749011 which
    strictly enforces status codes in exceptions, and 0 is not
    a valid status code so tests fail.

    Change the default to 500 to match the default in the parent
    class in webob.

    Closes-Bug: #1505153
    (cherry picked from commit 10438c0fc34bd088e018e1a5e8ec57b396528792)

    Change-Id: I1e06e77308a7dd23209124f0807d61fb52470188

commit 606204354b5ed96852240020769c81acda9f9fc8
Author: Matt Riedemann <email address hidden>
Date: Mon Oct 5 20:32:58 2015 +0000

    Revert "[libvirt] Move cleanup of imported files to imagebackend"

    This reverts commit 9ba70756de326ffaa8be43acfde12cad04ed0af2

    The change introduced an UnboundLocalError if we fail to
    create the config_drive_image variable. Also, the original
    change didn't have any unit tests and came late in the
    liberty release so I don't really want to mess with fixing
    this given we need the fix in liberty-rc2.

    Change-Id: Ia7b70aa139b67cf58b5c0f9fbcd2a4deb465914e
    Closes-Bug: #1502961

commit ef655379445693443146f8a3ed31cabb011d9937
Author: OpenStack Proposal Bot <email address hidden>
Date: Thu Oct 8 06:41:06 2015 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: Idcac653033ab9808e06451a0dd690db4736834b2

commit eda3029aa74932f421d2992ac24f5ac3c92f347c
Author: Dan Smith <email address hidden>
Date: Tue Oct 6 10:58:18 2...

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/glance 12.0.0.0b1

This issue was fixed in the openstack/glance 12.0.0.0b1 development milestone.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/nova 13.0.0.0b1

This issue was fixed in the openstack/nova 13.0.0.0b1 development milestone.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0b1

This issue was fixed in the openstack/heat 6.0.0.0b1 development milestone.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/cinder 8.0.0.0b1

This issue was fixed in the openstack/cinder 8.0.0.0b1 development milestone.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0b1

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron-vpnaas 8.0.0.0b1

This issue was fixed in the openstack/neutron-vpnaas 8.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/sahara 4.0.0.0b1

This issue was fixed in the openstack/sahara 4.0.0.0b1 development milestone.

Changed in sahara:
status: Fix Committed → Fix Released
Changed in heat:
status: Fix Committed → Fix Released
Changed in ironic:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ironic 4.3.0

This issue was fixed in the openstack/ironic 4.3.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/heat 5.0.1

This issue was fixed in the openstack/heat 5.0.1 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/sahara 3.0.1

This issue was fixed in the openstack/sahara 3.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.