Use assertFalse

Bug #1503074 reported by Hirofumi Ichihara
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Hirofumi Ichihara

Bug Description

We should use assertFalse not assertEqual(False, ***).

Changed in neutron:
assignee: nobody → Hirofumi Ichihara (ichihara-hirofumi)
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-fwaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/231274

Revision history for this message
Reedip (reedip-banerjee-deactivatedaccount) wrote :

Dear Hirofumi,
I have fixed the related issue in the FWaaS extension and VPNaaS extension.

Revision history for this message
Hirofumi Ichihara (ichihara-hirofumi) wrote :

@Reedip Good work!

tags: added: low-hanging-fruit unittest
Changed in neutron:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/231274
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=1977b0f7dcf73dd49e739dadcf40d5d7970e0ea3
Submitter: Jenkins
Branch: master

commit 1977b0f7dcf73dd49e739dadcf40d5d7970e0ea3
Author: Reedip Banerjee <email address hidden>
Date: Tue Oct 6 06:15:36 2015 +0530

    use assertFalse instead of assertEqual(False, ***)

    The usage of assertEqual(False, ***) should be changed to a more
    meaningful format of assertFalse(***).
    This patch fixes the usage for FWaaS.

    Change-Id: Iac55fc1b98cebacefeb3227ca002f454bfc94f50
    Related-Bug: #1503074

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
status: Fix Committed → In Progress
Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/231221
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ae1fb6e87225900bedbc68d014369a1adaa4fcab
Submitter: Jenkins
Branch: master

commit ae1fb6e87225900bedbc68d014369a1adaa4fcab
Author: Hirofumi Ichihara <email address hidden>
Date: Fri Oct 9 23:38:27 2015 +0900

    Use assertFalse(observed) instead of assertEqual(False, observed)

    The patch also improves the way in which the assertTrue (and
    similarly assertFalse) are done,

    We should use assertFalse not assertEqual.

    Co-Authored-By: Gary Kotton <email address hidden>

    Closes-Bug: #1503074

    Change-Id: I5f527ddf2ca522cdf101de2482d59f059eca010f

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0b1

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

Changed in neutron:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.