Remove old neutronclient based fallback mechanism from metadata agent

[Ihar Hrachyshka]

The new RPC interface has proved itself for two cycles, I don't
recollect any serious issues with it, so let's just clean up the
obsolete neutronclient based fallback mechanism.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/231065

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/231065
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e5cd4a9f540ef48b5476df011c45333d9c0d72ba
Submitter: Jenkins
Branch: master

commit e5cd4a9f540ef48b5476df011c45333d9c0d72ba
Author: Ihar Hrachyshka <email address hidden>
Date: Mon Oct 5 17:46:33 2015 +0200

    Removed neutronclient option from metadata agent

    The new RPC interface has proved itself for two cycles, I don't
    recollect any serious issues with it, so let's just clean up the
    obsolete neutronclient based fallback mechanism.

    The metadata agent configuration documentation should be updated
    to not require API configuration values for the agent to talk to
    neutron-server.

    DocImpact
    Change-Id: I254c575c66214f50fb93a94c46c4c9caebfc2937
    Closes-Bug: #1502947

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

[Eugene (baribalbear)]

Is it possible to back port it to Liberty? We are having this issue often:

2016-02-12 18:38:27.867 121291 WARNING neutron.agent.metadata.agent [-] Server does not support metadata RPC, fallback to using neutron client
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent [-] Unexpected error.
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent Traceback (most recent call last):
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent File "/usr/lib/python2.7/site-packages/neutron/agent/metadata/agent.py", line 114, in __call__
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent instance_id, tenant_id = self._get_instance_and_tenant_id(req)
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent File "/usr/lib/python2.7/site-packages/neutron/agent/metadata/agent.py", line 210, in _get_instance_and_tenant_id
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent ports = self._get_ports(remote_address, network_id, router_id)
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent File "/usr/lib/python2.7/site-packages/neutron/agent/metadata/agent.py", line 198, in _get_ports
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent networks = self._get_router_networks(router_id)
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent File "/usr/lib/python2.7/site-packages/neutron/common/utils.py", line 104, in __call__
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent return self._get_from_cache(target_self, *args, **kwargs)
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent File "/usr/lib/python2.7/site-packages/neutron/common/utils.py", line 82, in _get_from_cache
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent item = self.func(target_self, *args, **kwargs)
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent File "/usr/lib/python2.7/site-packages/neutron/agent/metadata/agent.py", line 159, in _get_router_networks
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent internal_ports = self._get_ports_from_server(router_id=router_id)
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent File "/usr/lib/python2.7/site-packages/neutron/agent/metadata/agent.py", line 141, in _get_ports_from_server
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent return self._get_ports_using_client(filters)
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent File "/usr/lib/python2.7/site-packages/neutron/agent/metadata/agent.py", line 183, in _get_ports_using_client
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent ports = client.list_ports(**filters)
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent File "/usr/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 102, in with_params
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent ret = self.function(instance, *args, **kwargs)
2016-02-12 18:38:27.871 121286 ERROR neutron.agent.metadata.agent File "/usr/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 547, in list_ports
2016-02...

[Eugene (baribalbear)]

Basically it is written in http://docs.openstack.org/liberty/install-guide-rdo/neutron-compute-install.html to set "auth_url = http://IP:35357", all seems working fine but this fallback functionality does not.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/322662

[OpenStack Infra (hudson-openstack)]

Change abandoned by Hynek Mlnarik (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/322662
Reason: Abandoning this change as such a backport violates stable policy (changes of configuration)