neutron

iptables bare jump rule is not getting comments put in the right spot

Bug #1502932 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Kevin Benton

Bug Description

the bare iptables jump rules (jump without any criteria) are not having comments put in the correct place so they are being replaced on every iptables reload.

Kevin Benton (kevinbenton)
Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/231044

Changed in neutron:
status: New → In Progress
Ihar Hrachyshka (ihar-hrachyshka)
tags: added: kilo-backport-potential liberty-rc-potential sg-fw
Changed in neutron:
importance: Undecided → Medium
tags: added: loadimpact
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/231044
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2a4b5f938d038bd73a70f1fc86cc71e819e288b0
Submitter: Jenkins
Branch: master

commit 2a4b5f938d038bd73a70f1fc86cc71e819e288b0
Author: Kevin Benton <email address hidden>
Date: Mon Oct 5 08:07:56 2015 -0700

    Fix iptables comments for bare jump rules

    This fixes the order of arguments in iptables rules that
    are bare jumps (e.g. '-j other-chain').

    The previous code was only catching jump rules that appeared
    after a chain definition.

    Closes-Bug: #1502932
    Change-Id: I490792eb08c67a32f9b286d933a776fb76840b6b

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/233100

Ihar Hrachyshka (ihar-hrachyshka)
tags: added: metering
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/235830

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/233100
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=073845f4d9f46bd41461a207d4aac55eba6e6009
Submitter: Jenkins
Branch: stable/liberty

commit 073845f4d9f46bd41461a207d4aac55eba6e6009
Author: Kevin Benton <email address hidden>
Date: Mon Oct 5 08:07:56 2015 -0700

    Fix iptables comments for bare jump rules

    This fixes the order of arguments in iptables rules that
    are bare jumps (e.g. '-j other-chain').

    The previous code was only catching jump rules that appeared
    after a chain definition.

    Closes-Bug: #1502932
    Change-Id: I490792eb08c67a32f9b286d933a776fb76840b6b
    (cherry picked from commit 2a4b5f938d038bd73a70f1fc86cc71e819e288b0)

tags: added: in-stable-liberty
Akihiro Motoki (amotoki)
tags: removed: liberty-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/kilo)

Reviewed: https://review.openstack.org/235830
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=447d2cb9a517f329267fff496dd4a0a1b55e3410
Submitter: Jenkins
Branch: stable/kilo

commit 447d2cb9a517f329267fff496dd4a0a1b55e3410
Author: Kevin Benton <email address hidden>
Date: Mon Oct 5 08:07:56 2015 -0700

    Fix iptables comments for bare jump rules

    This fixes the order of arguments in iptables rules that
    are bare jumps (e.g. '-j other-chain').

    The previous code was only catching jump rules that appeared
    after a chain definition.

    Closes-Bug: #1502932
    Change-Id: I490792eb08c67a32f9b286d933a776fb76840b6b
    (cherry picked from commit 2a4b5f938d038bd73a70f1fc86cc71e819e288b0)

tags: added: in-stable-kilo
Ihar Hrachyshka (ihar-hrachyshka)
tags: removed: kilo-backport-potential
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0b1

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

Doug Hellmann (doug-hellmann)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 7.0.1

This issue was fixed in the openstack/neutron 7.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.