Evolution of options and features in neutron-db-manage for Newton

[Henry Gessau]

Neutron's DB schema and alembic revisions management is evolving.
In the process, we have deprecated and dropped features and options.

This bug will be used to track evolutionary updates:
- Better help and documentation
- Better formatting and and more useful output from commands
- Additional options for more insight into alembic branches/heads/history
- etc.

This bug will also be used to track the deprecations and removals:
- Branchless migrations
- split_branches option
- core_plugin option
- service option
- quota_driver option
- etc.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228882
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=82216c8764b47b4e2de93533b47af2d5aaf2730f
Submitter: Jenkins
Branch: master

commit 82216c8764b47b4e2de93533b47af2d5aaf2730f
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Sep 29 14:45:50 2015 +0200

    Deprecate branchless migration chains from neutron-db-manage

    Support for the scheme puts additional burden on neutron-db-manage
    maintainers. The split branches were introduced in all 'official'
    subprojects in Liberty, so it's fine to deprecate it in Mitaka, and drop
    in Noodle.

    Since there is no user actionable item to do for users, using
    debtcollector that will only issue DeprecationWarning if they are
    enabled. The assumption is that developers run their tests with that
    enabled (as the BaseTestCase ensures) and handle warnings.

    Related-Bug: #1501380
    Change-Id: Ie4ddd29d8c51be74a112864aae3d16fb5e52c0fa

[Armando Migliaccio (armando-migliaccio)]

To be discussed at the next drivers meeting.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/248160
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b06f816381ee1c5564aaf59d1406f9cc9873f5a1
Submitter: Jenkins
Branch: master

commit b06f816381ee1c5564aaf59d1406f9cc9873f5a1
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Nov 20 17:20:09 2015 +0100

    neutron-db-manage: mark several options as deprecated

    I believe we don't rely on --core_plugin or --quota_driver for the tool
    because database contents are independent of chosen plugins and drivers
    since ~Juno.

    Also marked --service with deprecated_for_removal=True.

    Related-Bug: #1501380
    Change-Id: I2b4d98242a0d38843d931a71414ef2560a7ddb8f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/239931
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ceb9c40d66d0bfad79165ced2ae8e02e44b55686
Submitter: Jenkins
Branch: master

commit ceb9c40d66d0bfad79165ced2ae8e02e44b55686
Author: Ann Kamyshnikova <email address hidden>
Date: Wed Oct 28 16:25:29 2015 +0300

    Kilo initial migration

    Juno will be deprecated with Mitaka release, so juno_initial migration
    should be replaced with kilo_initilal migration in Mitaka.

    Optimized execution time of "upgrade head" command.
    Test on my local machine on MySQL shows about 28% reduce (from 188
    seconds to 137 seconds).

    Related-Bug: #1501380

    Change-Id: I26571f1c43764a01d1ae9869ce43ff18ea677892

[Armando Migliaccio (armando-migliaccio)]

The patch that introduces deprecation: https://review.openstack.org/#/c/248160/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/295397

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/295261
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ea408db27bce57ffb9c8ed34d6e692ba41520299
Submitter: Jenkins
Branch: master

commit ea408db27bce57ffb9c8ed34d6e692ba41520299
Author: Ihar Hrachyshka <email address hidden>
Date: Mon Mar 21 12:58:35 2016 +0100

    Enforce alembic branch when creating scripts manually

    Autogeneration code already enforces the branch for new scripts, but
    explicit mode [where you pass --expand or --contract to get empty script
    stubs] was not doing it. This resulted in new scripts being created in
    the same directory where the current branch head is located. This is a
    problem when we want to switch to a new release directory to store
    future scripts.

    To fix the problem, we now enforce the branch as per --contract/--expand
    CLI arguments passed. We also ensure that the new directory is present
    before attempting to generate a new stub script.

    Related-bug: #1501380
    Change-Id: I01cb6fed6dd246bedf945c323372e53991973fdc

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/295397
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8d07ba0e1b46dfcb588925c6320d7c0c5225a315
Submitter: Jenkins
Branch: master

commit 8d07ba0e1b46dfcb588925c6320d7c0c5225a315
Author: Ihar Hrachyshka <email address hidden>
Date: Mon Mar 21 17:33:45 2016 +0100

    neutron-db-manage: revision: fail for --autogenerate and branch

    If branch specification (--expand/--contract) is passed to CLI while
    also passing --autogenerate, fail explicitly instead of going into
    autogeneration code and generating both scripts, as we currently do.

    Change-Id: Ibf829fdd0b66a8d312c314487cfd8122a7721ef6
    Related-bug: #1501380

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/295905
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7d806fb9906f3de75cc489b77d9488791b7aeb9a
Submitter: Jenkins
Branch: master

commit 7d806fb9906f3de75cc489b77d9488791b7aeb9a
Author: Dariusz Smigiel (dasm) <email address hidden>
Date: Tue Mar 22 15:32:41 2016 +0000

    Remove deprecated methods from migration CLI file

    Commit Ie4ddd29d8c51be74a112864aae3d16fb5e52c0fa marked methods:
     * _validate_head_file
     * update_head_file
    as deprecated.

    Related-Bug: #1501380
    Change-Id: I0c08b32120974a7f82d2ae967cf13374c2e797ce

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/311624

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/321797

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322862
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=95c7d83ea7fefbf812308407838d49f5c4b3b5a2
Submitter: Jenkins
Branch: master

commit 95c7d83ea7fefbf812308407838d49f5c4b3b5a2
Author: Henry Gessau <email address hidden>
Date: Mon May 30 10:50:50 2016 -0400

    Use --subproject instead of deprecated --service option

    The --service option to neutron-db-manage is deprecated and will be
    removed soon. Use --subproject instead.

    Related-Bug: #1501380

    Change-Id: I2f64634d6f01c06a071abf064caf11a134800d04

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322860
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=d818279ea99dbf78cd2d474adf56c7a67f203835
Submitter: Jenkins
Branch: master

commit d818279ea99dbf78cd2d474adf56c7a67f203835
Author: Henry Gessau <email address hidden>
Date: Mon May 30 10:46:31 2016 -0400

    Use --subproject instead of deprecated --service option

    The --service option to neutron-db-manage is deprecated and will be
    removed soon. Use --subproject instead.

    Related-Bug: #1501380

    Change-Id: I02757737baea7c8623e7ed6cabff99c490f1f6c1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/311624
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6e7f8c17043ee5ace116d1fcd9c8fe18f6e57547
Submitter: Jenkins
Branch: master

commit 6e7f8c17043ee5ace116d1fcd9c8fe18f6e57547
Author: Henry Gessau <email address hidden>
Date: Sun May 1 10:37:29 2016 -0400

    Remove some options from neutron-db-manage

    Remove these CLI options:
     --core_plugin : deprecated, not used
     --service : deprecated in favor of --subproject
     --sql_connection : deprecated in favor of --database-connection

    Related-Bug: #1501380

    Change-Id: Iff1babbb29d43dd0d4fed653de4714ca0ff75a99

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/321797
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a868433aa9aeb6616b17b97cc4507e45117200f2
Submitter: Jenkins
Branch: stable/mitaka

commit a868433aa9aeb6616b17b97cc4507e45117200f2
Author: Ihar Hrachyshka <email address hidden>
Date: Mon Mar 21 17:33:45 2016 +0100

    neutron-db-manage: revision: fail for --autogenerate and branch

    If branch specification (--expand/--contract) is passed to CLI while
    also passing --autogenerate, fail explicitly instead of going into
    autogeneration code and generating both scripts, as we currently do.

    Change-Id: Ibf829fdd0b66a8d312c314487cfd8122a7721ef6
    Related-bug: #1501380
    (cherry picked from commit 8d07ba0e1b46dfcb588925c6320d7c0c5225a315)

[Henry Gessau (gessau)]

The final step for this "bug" will be to remove the options that are marked as deprecated. This can happen when master opens for Ocata.