ovs_lib.OVSBridge.get_ports_attributes returns all ports in case there's no ports on the OVSBridge in question

[Assaf Muller]

If OVSBridge.get_ports_attributes is executed on an empty bridge, get_port_name_list will return an empty list. In which case, ovsdb.db_list is executed with port_names = [], meaning that it will return all ports, instead of no ports.

The implication is that if, for example, br-ex (An ancillary bridge in the OVS agent) is currently empty, then scan_ancillary_ports will pick up all ports. All ports on the system will be considered ancillary_ports, which is unexpected and can result in ports going DOWN when they shouldn't.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/227982

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/227982
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9c3e3a0fcee012ee0187b19931d63927379a621f
Submitter: Jenkins
Branch: master

commit 9c3e3a0fcee012ee0187b19931d63927379a621f
Author: Assaf Muller <email address hidden>
Date: Fri Sep 25 14:20:21 2015 -0400

    Handle empty bridge case in OVSBridge.get_ports_attributes

    Before this patch, get_ports_attributes would call
    get_port_name_list. In the case of an empty bridge,
    get_port_name_list would return an empty list and feed that
    in to ovsdb.db_list, thereby returning all ports instead of
    no ports.

    Change-Id: I5a91028c59d71943b7cef86a94fa6ab1cc3d667c
    Closes-Bug: #1499821

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/233135

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233135
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a43e35b4ce738f65f50d30e8fd985ddc54867b3c
Submitter: Jenkins
Branch: stable/liberty

commit a43e35b4ce738f65f50d30e8fd985ddc54867b3c
Author: Assaf Muller <email address hidden>
Date: Fri Sep 25 14:20:21 2015 -0400

    Handle empty bridge case in OVSBridge.get_ports_attributes

    Before this patch, get_ports_attributes would call
    get_port_name_list. In the case of an empty bridge,
    get_port_name_list would return an empty list and feed that
    in to ovsdb.db_list, thereby returning all ports instead of
    no ports.

    Change-Id: I5a91028c59d71943b7cef86a94fa6ab1cc3d667c
    Closes-Bug: #1499821
    (cherry picked from commit 9c3e3a0fcee012ee0187b19931d63927379a621f)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/241782

[OpenStack Infra (hudson-openstack)]

Change abandoned by Eric Pendergrass (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/241782
Reason: get_ports_attributes is not in kilo

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 7.0.1 release.