Static routes are attempted to add to SNAT Namespace of DVR routers without checking for Router Gateway.

Bug #1499787 reported by Swaminathan Vasudevan on 2015-09-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Low
Armando Migliaccio

Bug Description

In DVR routers static routes are now only added to snat namespace.
But before adding to snat namespace, the routers are not checked for the existence of gateway.

Because of this we have also seen that when an attempt is made to add a route entry into the SNAT namespace, when it is not present, it throws an exception.
Also we need to make sure that we are checking for the existence of namespace before attempting to add or delete entry into the namespace.

Changed in neutron:
status: New → Confirmed
assignee: nobody → Swaminathan Vasudevan (swaminathan-vasudevan)

Fix proposed to branch: master
Review: https://review.openstack.org/228026

Changed in neutron:
status: Confirmed → In Progress
Ryan Moats (rmoats) on 2015-11-10
Changed in neutron:
importance: Undecided → Low

Change abandoned by Swaminathan Vasudevan (<email address hidden>) on branch: master
Review: https://review.openstack.org/227008
Reason: not required anymore.

Changed in neutron:
assignee: Swaminathan Vasudevan (swaminathan-vasudevan) → Brian Haley (brian-haley)
Changed in neutron:
assignee: Brian Haley (brian-haley) → Swaminathan Vasudevan (swaminathan-vasudevan)
Changed in neutron:
assignee: Swaminathan Vasudevan (swaminathan-vasudevan) → Brian Haley (brian-haley)
Changed in neutron:
assignee: Brian Haley (brian-haley) → Swaminathan Vasudevan (swaminathan-vasudevan)
Changed in neutron:
assignee: Swaminathan Vasudevan (swaminathan-vasudevan) → Armando Migliaccio (armando-migliaccio)

Reviewed: https://review.openstack.org/228026
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=158f9eabe20824b2c91eaac795dad8b8a773611d
Submitter: Jenkins
Branch: master

commit 158f9eabe20824b2c91eaac795dad8b8a773611d
Author: Swaminathan Vasudevan <email address hidden>
Date: Fri Sep 25 09:54:44 2015 -0700

    Static routes not added to qrouter namespace for DVR

    Today static routes are added to the SNAT namespace
    for DVR routers. But they are not added to the qrouter
    namespace.

    Also while configuring the static routes to SNAT
    namespace, the router is not checked for the existence
    of the gateway.

    When routes are added to a router without a gateway the
    routes are only configured in the router namespace, but
    when a gateway is set later, those routes have to be
    populated in the snat_namespace as well.

    This patch addresses the above mentioned issues.

    Closes-Bug: #1499785
    Closes-Bug: #1499787

    Change-Id: I37e0d0d723fcc727faa09028045b776957c75a82

Changed in neutron:
status: In Progress → Fix Released

This issue was fixed in the openstack/neutron 8.0.0.0b2 development milestone.

Reviewed: https://review.openstack.org/275758
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4bb364044bb99f559c565f51db756f5ee9ac73b7
Submitter: Jenkins
Branch: stable/liberty

commit 4bb364044bb99f559c565f51db756f5ee9ac73b7
Author: Swaminathan Vasudevan <email address hidden>
Date: Fri Sep 25 09:54:44 2015 -0700

    Static routes not added to qrouter namespace for DVR

    Today static routes are added to the SNAT namespace
    for DVR routers. But they are not added to the qrouter
    namespace.

    Also while configuring the static routes to SNAT
    namespace, the router is not checked for the existence
    of the gateway.

    When routes are added to a router without a gateway the
    routes are only configured in the router namespace, but
    when a gateway is set later, those routes have to be
    populated in the snat_namespace as well.

    This patch addresses the above mentioned issues.

    Closes-Bug: #1499785
    Closes-Bug: #1499787

    Conflicts:
     neutron/agent/l3/dvr_edge_router.py
            neutron/tests/functional/agent/test_l3_agent.py
     neutron/tests/functional/agent/l3/framework.py
     neutron/tests/functional/agent/l3/test_dvr_router.py

    Change-Id: I37e0d0d723fcc727faa09028045b776957c75a82
    (cherry picked from commit 158f9eabe20824b2c91eaac795dad8b8a773611d)

tags: added: in-stable-liberty

This issue was fixed in the openstack/neutron 7.0.4 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers