M2: Quota usage tracking needs tests

[Salvatore Orlando]

Functional tests are needed to avoid breaking the mechanisms that regulate quota usage tracking in ML2.

With proper tests in place these bugs could have been avoided:
https://bugs.launchpad.net/neutron/+bug/1499339
https://bugs.launchpad.net/neutron/+bug/1497459

[Salvatore Orlando (salvatore-orlando)]

Tentatively setting milestone to RC1. It is however not a priority merging it for RC1 or liberty at all.

[Kyle Mestery (mestery)]

I don't see a patch here, so moving out of Liberty unless a patch appears, lands in master, and can be cherry picked today. I'll add the liberty-backport-potential tag though.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/227282
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/227282
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cdd049e4c4d7e6ba1ca377e50fc6e8c29c85ab3d
Submitter: Jenkins
Branch: master

commit cdd049e4c4d7e6ba1ca377e50fc6e8c29c85ab3d
Author: Salvatore Orlando <email address hidden>
Date: Mon Sep 21 16:40:55 2015 -0700

    ML2: Add tests to validate quota usage tracking

    Ensure that event handlers are invoked upon completion of
    ML2 operations which add or remove tracked resources.
    Also validate that the event handlers are called for the
    appropriate resources and that quota usage's dirty bit
    is set and unset as expected.

    These are not unit tests, but added in the unit test tree
    as they leverage code both from the DB unit test and the ML2
    unit test framework. This module has indeed been added to
    the 'exclusion list' in check_unit_test_structure.sh, and
    should be moved to the functional test tree together with
    the other modules.

    Closes-Bug: #1499358

    Change-Id: I78c432c35f3f3339607cd533019ae6d0fa2a5cd6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/259575

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/259575
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f175cd751bc33af9f79f4c2ecbc8d53e7d5fce0c
Submitter: Jenkins
Branch: stable/liberty

commit f175cd751bc33af9f79f4c2ecbc8d53e7d5fce0c
Author: Salvatore Orlando <email address hidden>
Date: Mon Sep 21 16:40:55 2015 -0700

    ML2: Add tests to validate quota usage tracking

    Ensure that event handlers are invoked upon completion of
    ML2 operations which add or remove tracked resources.
    Also validate that the event handlers are called for the
    appropriate resources and that quota usage's dirty bit
    is set and unset as expected.

    These are not unit tests, but added in the unit test tree
    as they leverage code both from the DB unit test and the ML2
    unit test framework. This module has indeed been added to
    the 'exclusion list' in check_unit_test_structure.sh, and
    should be moved to the functional test tree together with
    the other modules.

    Conflicts:
     neutron/quota/resource.py

    Closes-Bug: #1499358

    Change-Id: I78c432c35f3f3339607cd533019ae6d0fa2a5cd6
    (cherry picked from commit cdd049e4c4d7e6ba1ca377e50fc6e8c29c85ab3d)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b2 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 7.0.2 release.