ovs_agent fails to start on Windows because root_helper cfg opt is not found

Bug #1497930 reported by Adelina Tuvenie
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Adelina Tuvenie

Bug Description

The openvswitch neutron agent doesn't start on Windows because the root_helper cfg is not found.

Trace: http://paste.openstack.org/show/472500/

This happens because config.register_root_helper is not called in the Windows utils.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/226178

Changed in neutron:
assignee: nobody → Adelina Tuvenie (atuvenie)
status: New → In Progress
tags: added: liberty-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/226178
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=074f82d3ec18fd591e9d1805676dfe13bd508510
Submitter: Jenkins
Branch: master

commit 074f82d3ec18fd591e9d1805676dfe13bd508510
Author: Adelina Tuvenie <email address hidden>
Date: Mon Sep 21 23:51:42 2015 -0700

    Fixes 'ovs-agent cannot start on Windows because root_helper opt is not found'

    Change Ie1224f8a1c17268cd7d1c474ed82fdfb8852eaa8 removed
    config.register_root_helper() from ovs_neutron_agent:main, thus the agent
    cannot start on Windows since root_helper config option is never
    registered.

    The fix consists in adding config.register_root_helper in the Windows side
    utils.

    Closes-Bug: #1497930

    Change-Id: I6adc3b869c9564cac3ab99174b8fe47584213e59

Changed in neutron:
status: In Progress → Fix Committed
Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/230525

Kyle Mestery (mestery)
Changed in neutron:
milestone: none → mitaka-1
Thierry Carrez (ttx)
no longer affects: neutron/liberty
Changed in neutron:
milestone: mitaka-1 → liberty-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/230525
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cf1689438079de264dd4a61cccaf2ad8b0bd05b9
Submitter: Jenkins
Branch: stable/liberty

commit cf1689438079de264dd4a61cccaf2ad8b0bd05b9
Author: Adelina Tuvenie <email address hidden>
Date: Mon Sep 21 23:51:42 2015 -0700

    Fixes 'ovs-agent cannot start on Windows because root_helper opt is not found'

    Change Ie1224f8a1c17268cd7d1c474ed82fdfb8852eaa8 removed
    config.register_root_helper() from ovs_neutron_agent:main, thus the agent
    cannot start on Windows since root_helper config option is never
    registered.

    The fix consists in adding config.register_root_helper in the Windows side
    utils.

    Closes-Bug: #1497930

    Change-Id: I6adc3b869c9564cac3ab99174b8fe47584213e59
    (cherry picked from commit 074f82d3ec18fd591e9d1805676dfe13bd508510)

tags: added: in-stable-liberty
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-rc2 → 7.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235300

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)
Download full text (16.6 KiB)

Reviewed: https://review.openstack.org/235300
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=140ccc36d172bead2605968b3d61b36cca8a0040
Submitter: Jenkins
Branch: master

commit 6dcfe3a9362ae5fcf18e5cfb59663e43446cd59c
Author: Kevin Benton <email address hidden>
Date: Tue Oct 6 19:28:47 2015 -0700

    Mock oslo policy HTTPCheck instead of urllib

    We were mocking internal behavior of oslo policy by
    patching urllib. This will break with the upcoming oslo
    release that switches to requests.

    This patch changes the mock to the HTTPCheck level and we
    can leave implementation details testing up to oslo_policy.

    Change-Id: I07957f01307e25f1547197c720eea6e3e7f0ef5a
    Closes-Bug: #1503890
    (cherry picked from commit a0f1d9d6de1560be91d3001c8ac9f880a7a5a7e0)

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    Change-Id: I7dfbf240333095d91a414ba15a439bdc4804eb25
    (cherry picked from commit 86ad967e40c2c6752ec0fb46cfd3098ede0c7178)

    Fix functional test_server tests

    Now oslo.service 0.10.0 no longer sends SIGHUP to parent and
    children services.

    This was a chance introduced by 286a6ea, and since it invalidated
    the very logic under test, this must be revised.

    (cherry picked from commit 090fe713592c2b6398d999bfa03b80cbb2054609)

    Change-Id: I18a11283925369bc918002477774f196010a1bc3
    Closes-bug: #1505438
    (cherry picked from commit 090fe713592c2b6398d999bfa03b80cbb2054609)

    Make test_server work with older versions of oslo.service

    Change I18a11283925369bc918002477774f196010a1bc3 fixed the test for
    oslo.service >= 0.10.0, but it also broke it for older versions of
    oslo.service. Since the library has minimal version of >= 0.7.0 in
    requirements.txt, test should pass for those versions too.

    Now, instead of validating that either reset() or restart() of workers
    are triggered on SIGHUP, just validate that .start() is triggered the
    expected number of times (either way, no matter how oslo.service decide
    to clean up the children, they exit and then are respawned).

    Change-Id: I41f9d3af780b3178b075bc1e7084f417a2bd1378
    Closes-Bug: #1505645
    (cherry picked from commit 7bb40921660cf29beb68e338e205499efd6ffa36)

    Fixed multiple py34 gate issues

    1. Scope mock of 'open' to module

    By mocking 'open' at the module level, we can avoid affecting
    'open' calls from other modules.

    2. Stop using LOG.exception in contexts with no sys.exc_info set

    Python 3.4 logger fills in record.exc_info with sys.exc_info() result
    [1], and then it uses it to determine the current exception [2] to
    append to the log message. Since there is no exception, exc_info[1] is
    None, and we get AttributeError inside traceback module.

    It's actually a bug in Python interpreter that it attempt to access the
    attribute when there is no exception. It turns out that it's fixed in
    latest master of cPython [3] (...

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0b1

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.