Neutron subprojects cannot depend on alembic revisions from other neutron subprojects

Bug #1497830 reported by Henry Gessau
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Won't Fix
Medium
Henry Gessau

Bug Description

If networking-foo depends on networking-bar, then a requirement may arise for an alembic revision in networking-foo to depend on an alembic revision in networking-bar. Currently this cannot be accommodated because each subproject has its own alembic environment.

To solve this issue we need to switch to one alembic environment (neutron's) for all neutron subprojects.

Tags: db
Henry Gessau (gessau)
tags: added: db
Changed in neutron:
assignee: nobody → Henry Gessau (gessau)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/266159

Changed in neutron:
status: New → In Progress
Changed in neutron:
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/266159
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in neutron:
milestone: newton-1 → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/326133

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/326133
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=65bd0cd9ff655a2068915b2baa341a78675ba337
Submitter: Jenkins
Branch: master

commit 65bd0cd9ff655a2068915b2baa341a78675ba337
Author: Henry Gessau <email address hidden>
Date: Mon Jun 6 15:15:23 2016 -0400

    Complete removing support for unsplit alembic branches

    We used to support subprojects with a single alembic branch.
    Now the plan is to switch to a single alembic env for Neutron
    and all installed subprojects. In a single alembic env, all
    subprojects must use split (contract and expand) alembic branches.

    The first step of removing single branch support was done in [1]
    where we removed support for single HEAD files.

    The --split_branches option was used by developers only. By removing
    it we do not break any subproject, but force them to use split
    branches for any new migration scripts.

    [1] https://review.openstack.org/295905

    Partial-Bug: #1497830

    Change-Id: I62a191e1d22a1af4061c25fdc4a8df965d585419

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/333633

tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/333633
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=88359e3fe91b7e8f430b48da30b6d4f1ddf17d62
Submitter: Jenkins
Branch: master

commit 88359e3fe91b7e8f430b48da30b6d4f1ddf17d62
Author: Henry Gessau <email address hidden>
Date: Tue Jun 21 14:37:57 2016 -0400

    Support unique labels for alembic branches

    We plan to have all projects that integrate with Neutron use the same
    alembic environment (Neutron's) instead of having a separate alembic
    env.py in each repo. This means that each project will need to label
    their contract and expand branches uniquely.

    With this patch we add support for branch labels of the form
      'networking-foo-contract'
      'networking-foo-expand'

    We also support the old labels ('contract' and 'expand') with the
    intent of backporting this patch to Mitaka so that projects can be
    backwards compatible when they update their alembic branch labels. A
    best effort will be made to backport this patch to Liberty also.

    Support has been removed for label names starting with a "liberty_"
    prefix. Such labels temporarily existed during the Liberty cycle but
    have now all been cleaned up.

    Partial-Bug: #1497830

    Change-Id: Ibf38b3125d5d404d57f3e8ef0c7ecfa56eaf8042

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/338543

Changed in neutron:
milestone: newton-2 → newton-3
tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential
Changed in neutron:
milestone: newton-3 → newton-rc1
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

I doubt this bug justifies being landed in Newton.

Revision history for this message
Henry Gessau (gessau) wrote :

Existing case studies have so far not shown a convergent direction on which a good design can be based. I will continue working on this in Ocata.

Changed in neutron:
milestone: newton-rc1 → next
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/338543
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in neutron:
milestone: next → none
Revision history for this message
Lajos Katona (lajos-katona) wrote :

this bug is inactive for ~5years, I close it now

Changed in neutron:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.