Ignore the ERROR when delete a ipset member or destroy ipset sets

Bug #1497074 reported by shihanzhang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
shihanzhang
Kilo
Fix Released
Undecided
Unassigned

Bug Description

when ovs-agent or lb-agent execute ipset command, it will crash in some cases, but some actions like delete a ipset memeber or destroy ipset sets, these actions should not crash the l2 agent, we just need to log it if happen errors.

Changed in neutron:
assignee: nobody → shihanzhang (shihanzhang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/224967

Changed in neutron:
status: New → In Progress
Revision history for this message
Miguel Angel Ajo (mangelajo) wrote : Re: Ignore the ERROR when delete a ipset member

I believe we should backport this, as, it will avoid crashing the ovs agent in a loop when this happens (even if the occurrences in the gate are low/non existent, some operators have reported it eventually happening).

tags: added: kilo-backport-potential
tags: added: juno-backport-potential liberty-rc-potential
summary: - Ignore the ERROR when delete a ipset member
+ Ignore the ERROR when delete a ipset member or destroy ipset sets
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/231362

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/231363

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/224967
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e82733f5d9adefaf4ee2a9ff4ea615c5e0cb91a9
Submitter: Jenkins
Branch: master

commit e82733f5d9adefaf4ee2a9ff4ea615c5e0cb91a9
Author: shihanzhang <email address hidden>
Date: Fri Sep 18 10:38:43 2015 +0800

    Execute ipset command using check_exit_code

    When l2 agent execute ipset command, we should pass
    parameter 'check_exit_code' to self.execute acording to
    action.
    The intention is to safely fail if we try to destroy a
    non existing set, or delete a non existing member.
    Otherwise the agent gets stuck in a loop if such situation
    happens. Such kind of event would be logged as errors.

    Change-Id: If67330523d114d6da13d0280851e7138a51d08f7
    Closes-bug: #1497074

Changed in neutron:
status: In Progress → Fix Committed
Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → High
milestone: none → liberty-rc2
status: Fix Committed → In Progress
Thierry Carrez (ttx)
Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/231362
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fb40dbbce9ac17ee43d8921aa62c28f1ea723fba
Submitter: Jenkins
Branch: stable/liberty

commit fb40dbbce9ac17ee43d8921aa62c28f1ea723fba
Author: shihanzhang <email address hidden>
Date: Fri Sep 18 10:38:43 2015 +0800

    Execute ipset command using check_exit_code

    When l2 agent execute ipset command, we should pass
    parameter 'check_exit_code' to self.execute acording to
    action.
    The intention is to safely fail if we try to destroy a
    non existing set, or delete a non existing member.
    Otherwise the agent gets stuck in a loop if such situation
    happens. Such kind of event would be logged as errors.

    Change-Id: If67330523d114d6da13d0280851e7138a51d08f7
    Closes-bug: #1497074

tags: added: in-stable-liberty
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/kilo)

Reviewed: https://review.openstack.org/231363
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f23247511550e25ed996ac084ab09ecc52578ac7
Submitter: Jenkins
Branch: stable/kilo

commit f23247511550e25ed996ac084ab09ecc52578ac7
Author: shihanzhang <email address hidden>
Date: Fri Sep 18 10:38:43 2015 +0800

    Execute ipset command using check_exit_code

    When l2 agent execute ipset command, we should pass
    parameter 'check_exit_code' to self.execute acording to
    action.
    The intention is to safely fail if we try to destroy a
    non existing set, or delete a non existing member.
    Otherwise the agent gets stuck in a loop if such situation
    happens. Such kind of event would be logged as errors.

    (cherry picked from commit fb40dbbce9ac17ee43d8921aa62c28f1ea723fba)

    Change-Id: If67330523d114d6da13d0280851e7138a51d08f7
    Closes-bug: #1497074

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-rc2 → 7.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235300

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)
Download full text (16.6 KiB)

Reviewed: https://review.openstack.org/235300
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=140ccc36d172bead2605968b3d61b36cca8a0040
Submitter: Jenkins
Branch: master

commit 6dcfe3a9362ae5fcf18e5cfb59663e43446cd59c
Author: Kevin Benton <email address hidden>
Date: Tue Oct 6 19:28:47 2015 -0700

    Mock oslo policy HTTPCheck instead of urllib

    We were mocking internal behavior of oslo policy by
    patching urllib. This will break with the upcoming oslo
    release that switches to requests.

    This patch changes the mock to the HTTPCheck level and we
    can leave implementation details testing up to oslo_policy.

    Change-Id: I07957f01307e25f1547197c720eea6e3e7f0ef5a
    Closes-Bug: #1503890
    (cherry picked from commit a0f1d9d6de1560be91d3001c8ac9f880a7a5a7e0)

    Add testresources used by oslo.db fixture

    If we use oslo.db fixtures, we'll need the package or
    the next version of oslo.db release will break us.

    Closes-Bug: #1503501
    Change-Id: I7dfbf240333095d91a414ba15a439bdc4804eb25
    (cherry picked from commit 86ad967e40c2c6752ec0fb46cfd3098ede0c7178)

    Fix functional test_server tests

    Now oslo.service 0.10.0 no longer sends SIGHUP to parent and
    children services.

    This was a chance introduced by 286a6ea, and since it invalidated
    the very logic under test, this must be revised.

    (cherry picked from commit 090fe713592c2b6398d999bfa03b80cbb2054609)

    Change-Id: I18a11283925369bc918002477774f196010a1bc3
    Closes-bug: #1505438
    (cherry picked from commit 090fe713592c2b6398d999bfa03b80cbb2054609)

    Make test_server work with older versions of oslo.service

    Change I18a11283925369bc918002477774f196010a1bc3 fixed the test for
    oslo.service >= 0.10.0, but it also broke it for older versions of
    oslo.service. Since the library has minimal version of >= 0.7.0 in
    requirements.txt, test should pass for those versions too.

    Now, instead of validating that either reset() or restart() of workers
    are triggered on SIGHUP, just validate that .start() is triggered the
    expected number of times (either way, no matter how oslo.service decide
    to clean up the children, they exit and then are respawned).

    Change-Id: I41f9d3af780b3178b075bc1e7084f417a2bd1378
    Closes-Bug: #1505645
    (cherry picked from commit 7bb40921660cf29beb68e338e205499efd6ffa36)

    Fixed multiple py34 gate issues

    1. Scope mock of 'open' to module

    By mocking 'open' at the module level, we can avoid affecting
    'open' calls from other modules.

    2. Stop using LOG.exception in contexts with no sys.exc_info set

    Python 3.4 logger fills in record.exc_info with sys.exc_info() result
    [1], and then it uses it to determine the current exception [2] to
    append to the log message. Since there is no exception, exc_info[1] is
    None, and we get AttributeError inside traceback module.

    It's actually a bug in Python interpreter that it attempt to access the
    attribute when there is no exception. It turns out that it's fixed in
    latest master of cPython [3] (...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.