Enable the use of 'external' service providers

[Armando Migliaccio]

Changes [1] allowed a service provider that does not belong to any of neutron *-aas projects (e.g. lbaas, fwaas, vpnaas) to be enabled/loaded through configuration.

That was good.

Now, this feature enhancement takes this to the next level of support for external drivers, and it allows service providers that may not be shipped with neutron-* and or networking_* projects to be loaded within the neutron service framework as well.

[1] https://review.openstack.org/#/q/topic:bug/1473110,n,z

[Armando Migliaccio (armando-migliaccio)]

I should really get going with this one because external providers (like OVN, ODL, etc) that want to co-locate their provider drivers in their repo will have a hard time plugging in.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/225298

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/225322

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/225298
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=522b278963701bd8cc6f05bf7a4212bd4aad0794
Submitter: Jenkins
Branch: master

commit 522b278963701bd8cc6f05bf7a4212bd4aad0794
Author: armando-migliaccio <email address hidden>
Date: Fri Sep 18 12:21:08 2015 -0700

    Get rid of ConfigParser code in ProviderConfiguration

    We may be unable to get rid of this code, but at least we can
    make it slimmer and more oslo_config friendly.

    This patch also fixes an issue where plain ConfigParser cannot
    handle config options with the same name under same section.

    Related-bug: #1492069

    Change-Id: I596613eb7b2fc3e894a3c1cc7b7cb24d7137cbc5

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/225322
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d24633a4688b951f2b4d29b3248019588b3e198a
Submitter: Jenkins
Branch: master

commit d24633a4688b951f2b4d29b3248019588b3e198a
Author: armando-migliaccio <email address hidden>
Date: Fri Sep 18 13:13:59 2015 -0700

    Relax service module check on service providers

    service_provider is a 'special' configuration. It is a MultiStr
    option that used to be in neutron.conf, but moved into its own *-aas
    config files after the service split. We allow for the definition to
    be available 'anywhere': either in neutron.conf or in the *-aas
    service's config file.

    The list of 'service_provider' can include drivers from within the *-aas
    tree, or from elsewhere, and can apply to different service types. Due to
    the polymorphic nature of this variable it is very tricky to identify only
    the drivers that pertain a specific service module: the service module
    may as well implement more than one service type and may have support
    from drivers out of tree.

    For this reason it is best to relax this check and rely on query filters
    when the ServiceManager.get_service_providers() is invoked. Furthermore,
    without this fix there was a situation where the value returned by
    'service_providers' may be differ depending on how the configuration is
    passed on the CLI, and this inconsistency may only cause headaches.

    Closes-bug: #1492069

    Change-Id: I4db4ce0b287c984d86181227edf769531ecb7bb8

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/342048
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=49d1def76263326535fa19fa9940434cbb34a05a
Submitter: Jenkins
Branch: master

commit 49d1def76263326535fa19fa9940434cbb34a05a
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Jul 14 10:39:05 2016 +0200

    Deprecate implicit loading of service_providers from neutron_*.conf

    This feature is redundant, since it duplicates oslo.config functionality. If
    neutron-server needs to load the configuration option from multiple files, it
    should be achieved by passing multiple --config-dir/--config-file CLI
    arguments, not by relying on implicit loading for files with names matching the
    neutron_*.conf pattern.

    The plan is to stop implicit loading in Ocata.

    More details:
    http://lists.openstack.org/pipermail/openstack-dev/2016-May/096033.html

    Related-Bug: #1492069
    Related-Bug: #1599936
    Change-Id: I743e181532d285303c8d5c2a73f4fd674626b478

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/373830

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/374261

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/373830
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e80112ca627805b4ad85f26361be1e9618030dbc
Submitter: Jenkins
Branch: master

commit e80112ca627805b4ad85f26361be1e9618030dbc
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Sep 21 16:43:23 2016 +0900

    Fix a release note typo for implicit provider loading deprecation

    Don't repeat --config-dir option twice.

    Related-Bug: #1492069
    Related-Bug: #1599936
    Change-Id: I002b80ba8e5496c164d08357e4cce9e0b4abf5cf

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374261
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2043cbd81f149dec1ef7e00c0e2de2f0aa863826
Submitter: Jenkins
Branch: stable/newton

commit 2043cbd81f149dec1ef7e00c0e2de2f0aa863826
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Sep 21 16:43:23 2016 +0900

    Fix a release note typo for implicit provider loading deprecation

    Don't repeat --config-dir option twice.

    Related-Bug: #1492069
    Related-Bug: #1599936
    Change-Id: I002b80ba8e5496c164d08357e4cce9e0b4abf5cf
    (cherry picked from commit e80112ca627805b4ad85f26361be1e9618030dbc)