create_router regression for some of plugins

[YAMAMOTO Takashi]

change I5a78d7f32e8ca912016978105221d5f34618af19 broke
plugins which calls create_router with a surrounding transaction.
eg. networking-midonet.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219215

[YAMAMOTO Takashi (yamamoto)]

this is blocking networking-midonet gate.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/219215
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Launchpad Janitor (janitor)]

[Expired for neutron because there has been no activity for 60 days.]

[YAMAMOTO Takashi (yamamoto)]

gate-tempest-dsvm-networking-midonet-ml2 failure with the following backtrace.
i think it can happen with any plugins with a surrounding transaction for create_router.

http://logs.openstack.org/42/328842/2/check/gate-tempest-dsvm-networking-midonet-ml2/32b6d98/logs/screen-q-svc.txt.gz?#_2016-06-14_09_02_13_857

2016-06-14 09:02:13.857 12058 ERROR root [req-753083b5-ba59-47d6-a4e8-90df2bcac4bd tempest-RoutersTest-1344545865 -] Original exception being dropped: ['Traceback (most recent call last):\n', ' File "/opt/stack/new/neutron/neutron/db/l3_db.py", line 236, in create_router\n gw_info, router=router_db)\n', ' File "/opt/stack/new/neutron/neutron/db/l3_gwmode_db.py", line 69, in _update_router_gw_info\n context, router_id, info, router=router)\n', ' File "/opt/stack/new/neutron/neutron/db/l3_db.py", line 479, in _update_router_gw_info\n ext_ips)\n', ' File "/opt/stack/new/neutron/neutron/db/l3_db.py", line 449, in _create_gw_port\n new_network_id, ext_ips)\n', ' File "/opt/stack/new/neutron/neutron/db/l3_db.py", line 350, in _create_router_gw_port\n context.elevated(), {\'port\': port_data})\n', ' File "/opt/stack/new/neutron/neutron/plugins/common/utils.py", line 164, in create_port\n return core_plugin.create_port(context, {\'port\': port_data})\n', ' File "/opt/stack/new/neutron/neutron/plugins/ml2/plugin.py", line 1149, in create_port\n result, mech_context = self._create_port_db(context, port)\n', ' File "/opt/stack/new/neutron/neutron/plugins/ml2/plugin.py", line 1139, in _create_port_db\n self._setup_dhcp_agent_provisioning_component(context, result)\n', ' File "/usr/lib/python2.7/contextlib.py", line 35, in __exit__\n self.gen.throw(type, value, traceback)\n', ' File "/opt/stack/new/neutron/neutron/db/api.py", line 67, in exc_to_retry\n raise db_exc.RetryRequest(e)\n', 'RetryRequest\n']
2016-06-14 09:02:13.871 12058 ERROR neutron.api.v2.resource [req-753083b5-ba59-47d6-a4e8-90df2bcac4bd tempest-RoutersTest-1344545865 -] create failed
2016-06-14 09:02:13.871 12058 ERROR neutron.api.v2.resource Traceback (most recent call last):
2016-06-14 09:02:13.871 12058 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/api/v2/resource.py", line 78, in resource
2016-06-14 09:02:13.871 12058 ERROR neutron.api.v2.resource result = method(request=request, **args)
2016-06-14 09:02:13.871 12058 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/api/v2/base.py", line 424, in create
2016-06-14 09:02:13.871 12058 ERROR neutron.api.v2.resource return self._create(request, body, **kwargs)
2016-06-14 09:02:13.871 12058 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_db/api.py", line 148, in wrapper
2016-06-14 09:02:13.871 12058 ERROR neutron.api.v2.resource ectxt.value = e.inner_exc
2016-06-14 09:02:13.871 12058 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 221, in __exit__
2016-06-14 09:02:13.871 12058 ERROR neutron.api.v2.resource self.force_reraise()
2016-06-14 09:02:13.871 12058 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_utils/exc...

[YAMAMOTO Takashi (yamamoto)]

this is one of blockers of networking-midonet gate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/219215
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e25151be3d71abc9b51cfc85b92b42b3e1162354
Submitter: Jenkins
Branch: master

commit e25151be3d71abc9b51cfc85b92b42b3e1162354
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Sep 1 19:07:50 2015 +0900

    create_router: Report the original exception

    In case delete_router, which is an attempt to revert
    the operation, failed, report the original exception
    rather than the one from delete_router. The former is
    more likely useful for users. Besides that, it's critical
    to preserve the original exception for special exceptions
    like RetryRequest.

    Also, add some relevant unit tests.

    Closes-Bug: #1490917
    Change-Id: I1cef944115c1911d4b7e60fb4dff389b1911ddbb

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 9.0.0.0b2 development milestone.