DB migration of geneve type driver should be 'expand'

Bug #1490767 reported by Itsuro Oda
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Won't Fix
Undecided
Unassigned

Bug Description

https://review.openstack.org/#/c/187945/

It only do adding table only definitely. So it should be in 'expand' directory.

It was merged already. I don't know how to fix though.

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

@Ihar: assigned to you just to draw your attention. Can you chime in?

Changed in neutron:
assignee: nobody → Ihar Hrachyshka (ihar-hrachyshka)
status: New → Confirmed
milestone: none → liberty-3
tags: added: db
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Ann is going to come up with a functional test that will validate semantical correctness of alembic operations used in split migration scripts.

Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Ann Kamyshnikova (akamyshnikova)
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

For damage control: I don't believe we can attach the geneve migration script to expand now. I also don't believe it's a disaster: we only put some operations that could be executed when service is up to offline phase.

I believe part of the problem here is lack of reviewer attention to the paths, but that's understandable: gerrit does not show paths in meaningful way when you review file after file.

The test to validate semantical correctness of operations could rely on Mike Bayer's autogenerate code that already has some kind of operation classification: https://review.openstack.org/#/c/203842/9/neutron/db/migration/autogen.py

I wonder whether it should be not a test that could be missed in a subproject, but a check that is embedded in upgrade command, that would make sure you cannot run a wrong migration script until the script is fixed. That could expand our sanity checks in neutron-db-manage that currently consist of a single check for security groups.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/219288

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/219295

Changed in neutron:
assignee: Ann Kamyshnikova (akamyshnikova) → Henry Gessau (gessau)
status: Confirmed → In Progress
Changed in neutron:
importance: Undecided → High
Changed in neutron:
assignee: Henry Gessau (gessau) → Armando Migliaccio (armando-migliaccio)
Changed in neutron:
assignee: Armando Migliaccio (armando-migliaccio) → Henry Gessau (gessau)
Changed in neutron:
assignee: Henry Gessau (gessau) → Armando Migliaccio (armando-migliaccio)
Changed in neutron:
assignee: Armando Migliaccio (armando-migliaccio) → Henry Gessau (gessau)
Changed in neutron:
milestone: liberty-3 → liberty-rc1
Changed in neutron:
assignee: Henry Gessau (gessau) → Armando Migliaccio (armando-migliaccio)
Changed in neutron:
assignee: Armando Migliaccio (armando-migliaccio) → Henry Gessau (gessau)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Henry Gessau (<email address hidden>) on branch: master
Review: https://review.openstack.org/219295
Reason: Missed L-3. It's not a good idea to fiddle with the migration timeline after a release has been tagged.

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :
Changed in neutron:
status: In Progress → Won't Fix
milestone: liberty-rc1 → none
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Bottom line: to have your system support the geneve type driver you need downtime.

Changed in neutron:
assignee: Henry Gessau (gessau) → nobody
importance: High → Undecided
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/221712

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/221712
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bbaa4abdd5500d30576d63b5a5eb1503363e2f67
Submitter: Jenkins
Branch: master

commit bbaa4abdd5500d30576d63b5a5eb1503363e2f67
Author: Ann Kamyshnikova <email address hidden>
Date: Wed Sep 9 14:32:36 2015 +0300

    Add test to check that correct functions is used in expand/contract

    This test will check that expand branch does not contain drop SQLAlchemy
    operations and contract branch does not contain create/add SQLAlchemy
    operations.

    Partially-Implements: blueprint online-schema-migrations

    Change-Id: Ifda31c0599651931c1a98f673f3b10e64538f18b
    Related-bug: #1490767

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (feature/pecan)

Related fix proposed to branch: feature/pecan
Review: https://review.openstack.org/224334

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: feature/pecan
Review: https://review.openstack.org/224357

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (feature/pecan)
Download full text (73.6 KiB)

Reviewed: https://review.openstack.org/224357
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fdc3431ccd219accf6a795079d9b67b8656eed8e
Submitter: Jenkins
Branch: feature/pecan

commit fe236bdaadb949661a0bfb9b62ddbe432b4cf5f1
Author: Miguel Angel Ajo <email address hidden>
Date: Thu Sep 3 15:40:12 2015 +0200

    No network devices on network attached qos policies

    Network devices, like internal router legs, or dhcp ports
    should not be affected by bandwidth limiting rules.

    This patch disables application of network attached policies
    to network/neutron owned ports.

    Closes-bug: #1486039
    DocImpact

    Change-Id: I75d80227f1e6c4b3f5fa7762b8dc3b0c0f1abd46

commit db4a06f7caa20a4c7879b58b20e95b223ed8eeaf
Author: Ken'ichi Ohmichi <email address hidden>
Date: Wed Sep 16 10:04:32 2015 +0000

    Use tempest-lib's token_client

    Now tempest-lib provides token_client modules as library and the
    interface is stable. So neutron repogitory doesn't need to contain
    these modules.
    This patch makes neutron use tempest-lib's token_client and removes
    the own modules for the maintenance.

    Change-Id: Ieff7eb003f6e8257d83368dbc80e332aa66a156c

commit 78aed58edbe6eb8a71339c7add491fe9de9a0546
Author: Jakub Libosvar <email address hidden>
Date: Thu Aug 13 09:08:20 2015 +0000

    Fix establishing UDP connection

    Previously, in establish_connection() for UDP protocol data were sent
    but never read on peer socket. That lead to successful read on peer side
    if this connection was filtered. Having constant testing string masked
    this issue as we can't distinguish to which test of connectivity data
    belong.

    This patch makes unique data string per test_connectivity() and
    also makes establish_connection() to create an ASSURED entry in
    conntrack table. Finally, in last test after firewall filter was
    removed, connection is re-established in order to avoid troubles with
    terminated processes or TCP continuing sending packets which weren't
    successfully delivered.

    Closes-Bug: 1478847
    Change-Id: I2920d587d8df8d96dc1c752c28f48ba495f3cf0f

commit e6292fcdd6262434a7b713ad8802db6bc8a6d3dc
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Sep 16 13:20:51 2015 +0900

    ovsdb: Fix a few docstring

    Change-Id: I53e1e21655b28fe5da60e58aeeb7cbbd103ae014

commit c22949a4449d96a67caa616290cf76b67b182917
Author: fumihiko kakuma <email address hidden>
Date: Wed Sep 16 11:52:59 2015 +0900

    Remove requirements.txt for the ofagent mechanism driver

    It is no longer used.

    Related-Blueprint: core-vendor-decomposition
    https://blueprints.launchpad.net/neutron/+spec/core-vendor-decomposition

    Change-Id: Ib31fb3febf8968e50d86dd66e1e6e1ea2313f8ac

commit d1d4de19d85f961d388c91e70f31b3bafec418c5
Author: Kevin Benton <email address hidden>
Date: Thu Sep 3 20:25:57 2015 -0700

    Always return iterables in L3 get_candidates

    The caller of this function expects iterables.

    Closes-Bug: #1494996
    Change-Id: I3d103e63f4e127a77268502415c0ddb0d804b54a

commit 1ad6ac448067306...

tags: added: in-feature-pecan
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (feature/pecan)

Change abandoned by Doug Wiegley (<email address hidden>) on branch: feature/pecan
Review: https://review.openstack.org/224334

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/220091
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers