the items will never be deleted from metering_info

Bug #1490581 reported by Sergey Vilgelm
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Kevin Benton
Juno
Fix Released
Undecided
Unassigned
Kilo
Fix Released
Undecided
Unassigned

Bug Description

The function _purge_metering_info of MeteringAgent class has a bug. The items of metering_info dictionary will never be deleted:
            if info['last_update'] > ts + report_interval:
                del self.metering_info[label_id]
I this situation last_update will always be less than current timestamp.
Also this function is not covered by the unit tests.
Also again, the purge_metering_info function uses metering_info dict but it should use the metering_infos dict.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/218885

Changed in neutron:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
description: updated
Revision history for this message
Kevin Benton (kevinbenton) wrote :

looks like this will cause an annoying memory leak

Changed in neutron:
milestone: none → liberty-rc1
importance: Undecided → Medium
Changed in neutron:
assignee: Sergey Vilgelm (sergey.vilgelm) → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/218885
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=997aa86fa12e3209b65741ef95906d491895a493
Submitter: Jenkins
Branch: master

commit 997aa86fa12e3209b65741ef95906d491895a493
Author: Sergey Vilgelm <email address hidden>
Date: Mon Aug 31 17:06:48 2015 +0300

    Fix a wrong condition for the _purge_metering_info function

    Fix a situation for the _purge_metering_info function
    when the items will never be deleted from the metering_info.
    Delete the metering_info dict and use the metering_infos instead.
    Fix the problem with changing a dictionary during iteration.
    Add the unit tests for the _purge_metering_info and
    _add_metering_info functions.

    Co-Authored-By: Yaroslav Isakov <email address hidden>

    Change-Id: I9031a5f27ae6438ffd5c5a48b0cf5cdc6867eff3
    Closes-Bug: #1490581

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/220453

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/220454

Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :

This bug also affects the kilo and juno releases.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/kilo)

Reviewed: https://review.openstack.org/220453
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2a6b34e5a37d73034567ccb5e16eae8dd47f9995
Submitter: Jenkins
Branch: stable/kilo

commit 2a6b34e5a37d73034567ccb5e16eae8dd47f9995
Author: Sergey Vilgelm <email address hidden>
Date: Mon Aug 31 17:06:48 2015 +0300

    Fix a wrong condition for the _purge_metering_info function

    Fix a situation for the _purge_metering_info function
    when the items will never be deleted from the metering_info.
    Delete the metering_info dict and use the metering_infos instead.
    Fix the problem with changing a dictionary during iteration.
    Add the unit tests for the _purge_metering_info and
    _add_metering_info functions.

    Co-Authored-By: Yaroslav Isakov <email address hidden>

    Change-Id: I9031a5f27ae6438ffd5c5a48b0cf5cdc6867eff3
    Closes-Bug: #1490581
    (cherry picked from commit 997aa86fa12e3209b65741ef95906d491895a493)

tags: added: in-stable-kilo
tags: added: in-stable-juno
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/juno)

Reviewed: https://review.openstack.org/220454
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2f344ee0884b75eacf3439c7bccce26f0c8c6b01
Submitter: Jenkins
Branch: stable/juno

commit 2f344ee0884b75eacf3439c7bccce26f0c8c6b01
Author: Sergey Vilgelm <email address hidden>
Date: Mon Aug 31 17:06:48 2015 +0300

    Fix a wrong condition for the _purge_metering_info function

    Fix a situation for the _purge_metering_info function
    when the items will never be deleted from the metering_info.
    Delete the metering_info dict and use the metering_infos instead.
    Fix the problem with changing a dictionary during iteration.
    Add the unit tests for the _purge_metering_info and
    _add_metering_info functions.

    Co-Authored-By: Yaroslav Isakov <email address hidden>

    Change-Id: I9031a5f27ae6438ffd5c5a48b0cf5cdc6867eff3
    Closes-Bug: #1490581
    (cherry picked from commit 997aa86fa12e3209b65741ef95906d491895a493)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/224334

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/224357

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (73.6 KiB)

Reviewed: https://review.openstack.org/224357
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fdc3431ccd219accf6a795079d9b67b8656eed8e
Submitter: Jenkins
Branch: feature/pecan

commit fe236bdaadb949661a0bfb9b62ddbe432b4cf5f1
Author: Miguel Angel Ajo <email address hidden>
Date: Thu Sep 3 15:40:12 2015 +0200

    No network devices on network attached qos policies

    Network devices, like internal router legs, or dhcp ports
    should not be affected by bandwidth limiting rules.

    This patch disables application of network attached policies
    to network/neutron owned ports.

    Closes-bug: #1486039
    DocImpact

    Change-Id: I75d80227f1e6c4b3f5fa7762b8dc3b0c0f1abd46

commit db4a06f7caa20a4c7879b58b20e95b223ed8eeaf
Author: Ken'ichi Ohmichi <email address hidden>
Date: Wed Sep 16 10:04:32 2015 +0000

    Use tempest-lib's token_client

    Now tempest-lib provides token_client modules as library and the
    interface is stable. So neutron repogitory doesn't need to contain
    these modules.
    This patch makes neutron use tempest-lib's token_client and removes
    the own modules for the maintenance.

    Change-Id: Ieff7eb003f6e8257d83368dbc80e332aa66a156c

commit 78aed58edbe6eb8a71339c7add491fe9de9a0546
Author: Jakub Libosvar <email address hidden>
Date: Thu Aug 13 09:08:20 2015 +0000

    Fix establishing UDP connection

    Previously, in establish_connection() for UDP protocol data were sent
    but never read on peer socket. That lead to successful read on peer side
    if this connection was filtered. Having constant testing string masked
    this issue as we can't distinguish to which test of connectivity data
    belong.

    This patch makes unique data string per test_connectivity() and
    also makes establish_connection() to create an ASSURED entry in
    conntrack table. Finally, in last test after firewall filter was
    removed, connection is re-established in order to avoid troubles with
    terminated processes or TCP continuing sending packets which weren't
    successfully delivered.

    Closes-Bug: 1478847
    Change-Id: I2920d587d8df8d96dc1c752c28f48ba495f3cf0f

commit e6292fcdd6262434a7b713ad8802db6bc8a6d3dc
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Sep 16 13:20:51 2015 +0900

    ovsdb: Fix a few docstring

    Change-Id: I53e1e21655b28fe5da60e58aeeb7cbbd103ae014

commit c22949a4449d96a67caa616290cf76b67b182917
Author: fumihiko kakuma <email address hidden>
Date: Wed Sep 16 11:52:59 2015 +0900

    Remove requirements.txt for the ofagent mechanism driver

    It is no longer used.

    Related-Blueprint: core-vendor-decomposition
    https://blueprints.launchpad.net/neutron/+spec/core-vendor-decomposition

    Change-Id: Ib31fb3febf8968e50d86dd66e1e6e1ea2313f8ac

commit d1d4de19d85f961d388c91e70f31b3bafec418c5
Author: Kevin Benton <email address hidden>
Date: Thu Sep 3 20:25:57 2015 -0700

    Always return iterables in L3 get_candidates

    The caller of this function expects iterables.

    Closes-Bug: #1494996
    Change-Id: I3d103e63f4e127a77268502415c0ddb0d804b54a

commit 1ad6ac448067306...

tags: added: in-feature-pecan
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (feature/pecan)

Change abandoned by Doug Wiegley (<email address hidden>) on branch: feature/pecan
Review: https://review.openstack.org/224334

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.