QoS doesn't work when a mechanism driver which doesn't implement bind_port explicitly supports it

[John Schwarz]

My ml2 configuration file contains the following:

[ml2]
extension_drivers = port_security,qos
mechanism_drivers = openvswitch,l2population

However, when trying to get a list of available rule types, the neutron-server logs this to the log file:

WARNING neutron.plugins.ml2.managers [req-19db3de7-1a1a-42b5-b4c0-b9f146a6bcac admin b44ee578c44a426e81752b4df76c1a89] l2population does not support QoS; no rule types available

Seems to me like this should not be the case, as l2pop has nothing to do with QoS or binding ports. Probably other mechanism drivers also produce the same error. QoS should explicitly check if a mechanism driver overrides bind_port and only if it does it should produce that error.

[Miguel Angel Ajo (mangelajo)]

Thanks guys, I will ping Ihar to see if he can look at it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/224831

[Kyle Mestery (mestery)]

Moving to Mitaka as the RC will be cut 9-22 or 9-23 this week.

[Ihar Hrachyshka (ihar-hrachyshka)]

Moved back to l-rc1 since it's ready for review.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/224831
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0cdb46b2030ed5b61098ca43662cb5b9ff855613
Submitter: Jenkins
Branch: master

commit 0cdb46b2030ed5b61098ca43662cb5b9ff855613
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Sep 17 19:13:22 2015 +0200

    ml2: don't consider drivers with no bind_port for qos supported rule types

    If the driver is not going to bind a port, we should not use it as
    justification to limit the subset of rule types available for the user.

    The most common scenario for that would be l2pop, that does not handle port
    binding, but merely modifies the implementation details of node
    interconnection.

    Change-Id: Iba0f3530deff3bb2871ebf893c43ef628a80c7c0
    Closes-Bug: #1488996