neutron

test_create_subnet_ipv6_pd_gw_values failure on OSX

Bug #1484837 reported by YAMAMOTO Takashi
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
YAMAMOTO Takashi

Bug Description

a few tests including test_create_subnet_ipv6_pd_gw_values fail on OSX due to different representation of IPv4-compat addresses.

Linux:
    >>> netaddr.IPAddress("::2")
    IPAddress('::2')
    >>>

OSX:
    >>> netaddr.IPAddress("::2")
    IPAddress('::0.0.0.2')
    >>>

See original description
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/213032

Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Revision history for this message
YAMAMOTO Takashi (yamamoto) wrote :

https://github.com/drkjam/netaddr/issues/82

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/228313

YAMAMOTO Takashi (yamamoto)
tags: added: unittest
tags: added: ipv6
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/228313
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2f6279e3e9a8561e74026ab3f3e639903014081b
Submitter: Jenkins
Branch: master

commit 2f6279e3e9a8561e74026ab3f3e639903014081b
Author: YAMAMOTO Takashi <email address hidden>
Date: Mon Sep 28 14:48:55 2015 +0900

    test_db_base_plugin_v2: Skip a few tests on some platforms

    netaddr (and its underlying libc inet_pton) produces different
    representations of IPv4-compat addresses for different platforms.

    Linux:
        >>> netaddr.IPAddress("::2")
        IPAddress('::2')
        >>>

    OSX:
        >>> netaddr.IPAddress("::2")
        IPAddress('::0.0.0.2')
        >>>

    As our API assumes Linux's way, skip affected test cases on
    the other platforms.

    Related-Bug: #1484837
    Change-Id: I89e1822bb92dfcf8772bba1a3edf908c89550119

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by YAMAMOTO Takashi (<email address hidden>) on branch: master
Review: https://review.openstack.org/213032
Reason: an alternative has been merged.
https://review.openstack.org/#/c/228313/

Assaf Muller (amuller)
tags: added: liberty-backport-potential
Assaf Muller (amuller)
Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (stable/liberty)

Related fix proposed to branch: stable/liberty
Review: https://review.openstack.org/240928

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/240928
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=445f5a4ad67a5bc7d3bff974a0e269424efbf1c9
Submitter: Jenkins
Branch: stable/liberty

commit 445f5a4ad67a5bc7d3bff974a0e269424efbf1c9
Author: YAMAMOTO Takashi <email address hidden>
Date: Mon Sep 28 14:48:55 2015 +0900

    test_db_base_plugin_v2: Skip a few tests on some platforms

    netaddr (and its underlying libc inet_pton) produces different
    representations of IPv4-compat addresses for different platforms.

    Linux:
        >>> netaddr.IPAddress("::2")
        IPAddress('::2')
        >>>

    OSX:
        >>> netaddr.IPAddress("::2")
        IPAddress('::0.0.0.2')
        >>>

    As our API assumes Linux's way, skip affected test cases on
    the other platforms.

    Conflicts:
     neutron/tests/tools.py

    Related-Bug: #1484837
    Change-Id: I89e1822bb92dfcf8772bba1a3edf908c89550119

tags: added: in-stable-liberty
Ihar Hrachyshka (ihar-hrachyshka)
tags: removed: liberty-backport-potential
Doug Hellmann (doug-hellmann)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-lib (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/398092

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-lib (master)

Reviewed: https://review.openstack.org/398092
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=e94547d4583ec1db21c4105ced7553b45e0b1d65
Submitter: Jenkins
Branch: master

commit e94547d4583ec1db21c4105ced7553b45e0b1d65
Author: Reedip <email address hidden>
Date: Wed Nov 16 09:35:35 2016 +0530

    Add is_bsd() to neutron-lib

    The is_bsd() testtool function is required for skipping
    some of the test cases in OSX/BSD environment.

    The is_bsd() check is useful when projects want to skip
    test cases related to IPv6 formatting as the implementation
    of netaddr differs in different platforms.

    Change-Id: I664e55883bbd714e31b49b278060e625fc5e6ea4
    Related-Bug: #1484837

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.