neutronclient gate broken following VPNaaS infra changes

[Assaf Muller]

https://etherpad.openstack.org/p/vpn-test-changes

stable/kilo breakage is tracked here: https://bugs.launchpad.net/neutron/+bug/1483266

[Paul Michali (pcm)]

Have https://review.openstack.org/#/c/209887/ and https://review.openstack.org/#/c/210021/1 to add plugin support (need to be updated with bug#)

[Paul Michali (pcm)]

We need to get 209887 updated in project-config to enable the use of a gate hook. Once upstreamed, 210021 can then use a gate-hook to enable the plugin. This will then allow future changes (if any are needed) to be done inside of the neutronclient project.

[Paul Michali (pcm)]

These is a workaround in place (VPN tests are skipped). Do need to determine approach for solution with the test jobs.

Some choices are:

A) One test job that enables the plugins and tests everything
B) Two jobs one for core, one for adv svc commands
C) Three/Four jobs, one for core, and then one for each advanced service, as they switch to plugins.

[Kyle Mestery (mestery)]

What is the current status of this bug Paul? Is it still critical?

[Paul Michali (pcm)]

Currently, the VPN tests are being skipped, so that the neutron client tests will pass.

There are two commits out to restore VPN tests (not sure why they are not showing up here).

https://review.openstack.org/#/c/209887/ Creates two experiment jobs for neutron-client that will use a gate hook to run tests; one for core neutron client tests and one for advanced services tests. The jobs are neutronclient-test-dsvm-functional and neutronclient-test-dsvm-functional-adv-svcs.

https://review.openstack.org/#/c/214587/ Modifies neutron client to split out the test modules into core and advanced service test modules (VPN only currently), and uses the gate hook to enable VPN devstack plugin for the advanced services job.

We need to get 209887 upstreamed, so that 214587 can then be tested in Jenkins.

[Kyle Mestery (mestery)]

Targeting Liberty-RC1 now and hoping we can land these two reviews.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/214587
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=b915201dbfd81b7dbb62c51a30576d596c3a3fa7
Submitter: Jenkins
Branch: master

commit b915201dbfd81b7dbb62c51a30576d596c3a3fa7
Author: Paul Michali <email address hidden>
Date: Wed Aug 19 12:16:05 2015 +0000

    Enable VPN test cases

    With the gate hook changes from Ieeaca1375d68705509f4e05f10cb35c0fa0b9582 and
    new jobs from I2db939bf99288c0cdec06cdd49fec3bdc72e5253, this commit does
    several things:

        * Moves test modules to tests/functional/core/
        * Moves VPN test cases to new module & places in tests/functional/adv-svcs
        * Modifies tox.ini to support 'functional' and 'functional-adv-svcs' test

    This commit will be used to test the experimental jobs, one that runs the
    same tests as before, one that runs VPN tests using the VPN DevStack plugin
    via the gate-hook.sh.

    Modified post test hook so that test results are properly created (was not
    seeing results from testr, prior to this).

    Goal is to place all advanced services into tests/functional/adv-svcs/ and
    use plugins, as needed in the gate hook.

    Change-Id: I1e3d19e51a1cbd1bc947bbf9927260cd4d73841a
    Depends-On: I2db939bf99288c0cdec06cdd49fec3bdc72e5253
    Partial-Bug: 1484148

[Paul Michali (pcm)]

Update:

VPN tests were "skipped" so that job would work (so this bug won't affect release). Since then, new jobs have been created and tested as experimental and, then as non-voting in check queue (https://review.openstack.org/227232). Once this gets some test time with commits, we can move it to voting and close this bug out completely (and remove the old job, as one of the new ones replaces it).

[Armando Migliaccio (armando-migliaccio)]

Ok, so to close this we need a project-config change rather than any neutron tree related change.

[Paul Michali (pcm)]

Correct. Once we are comfortable with the non-voting results, I can make another project-config commit to make this voting.

[Armando Migliaccio (armando-migliaccio)]

This bug is > 180 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

[Launchpad Janitor (janitor)]

[Expired for python-neutronclient because there has been no activity for 60 days.]