neutron-fwaas: Enable python34 support

Bug #1480338 reported by Kyle Mestery
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Li Ma

Bug Description

The following files need to be addressed and fixed so that "tox -epy34" completes successfully with all unit tests enabled:

neutron_fwaas/tests/unit/db/firewall/test_firewall_db.py
neutron_fwaas/tests/unit/extensions/test_firewall.py
neutron_fwaas/tests/unit/services/firewall/agents/vyatta/test_vyatta_utils.py
neutron_fwaas/tests/unit/services/firewall/drivers/vyatta/test_vyatta_fwaas.py
neutron_fwaas/tests/unit/services/firewall/drivers/cisco/test_csr_firewall_svc_helper.py
neutron_fwaas/tests/unit/services/firewall/freescale/test_fwaas_plugin.py

Kyle Mestery (mestery)
tags: added: fwaas low-hanging-fruit
Changed in neutron:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-fwaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/207926

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/207926
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=54d20b195716ade99384dcb464b5deb1bbb1e7d4
Submitter: Jenkins
Branch: master

commit 54d20b195716ade99384dcb464b5deb1bbb1e7d4
Author: Kyle Mestery <email address hidden>
Date: Fri Jul 31 14:36:03 2015 +0000

    py34: Enable initial python34 testing for FWaaS

    This adds the initial unit tests which pass for python34
    so we can enable this in the gate job.

    Change-Id: Ib5377c36fdb10cdc2427942f16b1f7c93f802525
    Related-Bug: #1480338
    Signed-off-by: Kyle Mestery <email address hidden>

Li Ma (nick-ma-z)
Changed in neutron:
assignee: nobody → Li Ma (nick-ma-z)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-fwaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/217037

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/217043

Revision history for this message
Li Ma (nick-ma-z) wrote :

neutron_fwaas/tests/unit/services/firewall/drivers/cisco/test_csr_firewall_svc_helper.py passes py34 test.

Revision history for this message
Li Ma (nick-ma-z) wrote :

neutron_fwaas/tests/unit/services/firewall/freescale/test_fwaas_plugin.py passes py34 test.

Revision history for this message
Li Ma (nick-ma-z) wrote :

neutron_fwaas/tests/unit/extensions/test_firewall.py passes py34.

Revision history for this message
Li Ma (nick-ma-z) wrote :

neutron_fwaas/tests/unit/db/firewall/test_firewall_db.py passes py34.

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/220942

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-fwaas (master)

Change abandoned by Li Ma (<email address hidden>) on branch: master
Review: https://review.openstack.org/220942
Reason: boring rework.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Li Ma (<email address hidden>) on branch: master
Review: https://review.openstack.org/217043
Reason: boring rework.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/217037
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=9e9aa46d67d22792c778958b40f49147168d1d89
Submitter: Jenkins
Branch: master

commit 9e9aa46d67d22792c778958b40f49147168d1d89
Author: Nick <email address hidden>
Date: Fri Aug 21 19:24:05 2015 +0800

    py34 support for fwaas

    Add py34 support to the modules listed below:
    test_firewall_db
    test_firewall
    test_vyatta_utils
    test_vyatta_fwaas
    test_csr_firewall_svc_helper
    test_fwaas_plugin

    Most work is done by introducing python-six
    to bridge the gap between py27 and py34.

    At this stage, py34 support is finished for fwaas.

    Change-Id: Ifa3716b159a210957d60f8581fc54f67c61eb332
    Closes-Bug: #1480338

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.