Reviewed: https://review.openstack.org/209556 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cc0ae6dd49da3e67c1d0400bc422e735c27e98fb Submitter: Jenkins Branch: feature/qos commit 1753187d490758238a09827f867a2d6542ee941b Author: Moshe Levi Date: Tue Jul 28 15:46:10 2015 +0300 Update OVS driver to work with objects This patch updates the QoS OVS driver to work with policy NeutronObjects that are passed by the agent extension manager, instead of lists of rule dicts, as we originally expected. It also adds validation that the rules that are sent by the neutron-server are actually supported by the backend. Finally, port dict was not really enough to determine the name of the port in ovsdb. 'name' field is not really present in all port dicts, and does not reflect what is known to ovs anyway. So instead, we should rely on vif_port object to determine the ovs port name. Since ovs agent only added the vif_port value to details dict when binding was desired, I made adding the vif_port object unconditional, and covered that fact with unit tests. With this patch in place, I was able to get policy rules applied to a port in devstack installation. Functional tests will belong to a follow-up. Partially-Implements: blueprint quantum-qos-api Change-Id: I8926adb0a30728e4f82e55d71ad7e76676a22086 commit 7ccc705f6177d9fd198f079e8b57cf44e58b1963 Author: John Schwarz Date: Mon Aug 3 15:49:13 2015 +0300 Add API tests for non-accessible policies Tests which dealt with creating a rule for a policy that the tenant has no access to, or for a policy which does not even exist, were missing. This patch adds them. Partially-Implements: quantum-qos-api Change-Id: I0a2679fa1ccfb7bae6083df9a71c6cb5205a21d9 commit 0c154ca94438e26884770742822728ecde3810e0 Author: John Schwarz Date: Mon Aug 3 16:56:27 2015 +0300 Gracefully handle fetching nonexistent rule Currently, if we invoke the API for 'show rule' but the rule does not exist, an exception is raised from deep within Neutron. This in turns causes an uncaught exception and the user will see 'ServerFault'. This patch proposes a fix for this scenario - the case where the rule does not exist is handled and a NeutronException is caused, causing a proper 'NotFound' error on the client side instead. Partially-Implements: blueprint quantum-qos-api Change-Id: Ic703a0865d1cfa057ab1ad5290b793b22df06af6 commit 651eeb6a5f40e58b7a6b3ccb59826bb6f08827c0 Author: Ihar Hrachyshka Date: Sun Aug 2 23:44:53 2015 +0200 use single transaction to update qos policy associatation To make association changes atomic, use autonested transaction. Change-Id: I582ff43a0ce2f17e3f9fedf7cd32dfbac1ebae28 Partially-Implements: blueprint quantum-qos-api commit 12ff4d6b5890c2fd1e0a3e58f974be3e1f1465ca Author: John Schwarz Date: Mon Jul 27 12:09:10 2015 +0300 Replace to_dict() calls with a function decorator Up until now, API server functions would need to return simple iterable objects, such as dicts and lists of dicts. This patch introduces a decorator which allows such functions to return non-simple objects (as long as the returned object implements the 'to_dict()' method, or is a list of such objects) and converts them on its own, simplifying the user's code and removing code duplication. Change-Id: Ib30a9213b86b33826291197cf01f00bc1dd3db52 commit 2b280a634ecb6f57c44c1d5a34b07e0bdb4d750e Author: Ihar Hrachyshka Date: Wed Jul 29 20:44:54 2015 +0200 Guarantee there is only one bandwidth limit rule per policy Added corresponding db model constraint. Change-Id: I5592d49909408df66e4d01cebbc45204c2be66c1 Partially-Implements: blueprint quantum-qos-api commit c660173edcc137c53bad6194183188bcac3552a1 Author: Ihar Hrachyshka Date: Sun Aug 2 22:40:40 2015 +0200 Cleaned up some TODO comments for feature/qos that do not apply anymore 1. Removed comment to add tests for invalid input for attach/detach methods for QosPolicy. Those tests are already implemented in the test class, so the TODO became obsolete. 2. Removed TODO to use a constant for rule 'type' field. There is no 'type' field in rules anymore, so it does not apply any more. Change-Id: I205cbc2d9a2eeee1a0a9fb5794efc063de6f326d Partially-Implements: blueprint quantum-qos-api commit 336a547aad506ccf69a58e7ac11b9ea12e9f66f9 Author: Ihar Hrachyshka Date: Sun Aug 2 19:17:27 2015 +0200 L2 agent extension manager: read extensions list from config file This effectively disables qos extension in the OVS agent, but we don't rely on it in any functional or fullstack tests so far. To enable the extension, a user should add: [agent] extensions = qos to their openvswitch_agent.ini file. DocImpact Partially-Implements: blueprint quantum-qos-api Change-Id: Icfbf32c36f98cc6e203841b152c7f6fc4f48c20a commit 52f60ba6c7319b139e2d6e17a2d3fa07344786b3 Author: Ihar Hrachyshka Date: Sun Aug 2 17:27:56 2015 +0200 objects.qos.policy: forbid deletion when attached to a port or a network Similar to security groups, we forbid removing a policy that is attached to any port or a network. Change-Id: I0854c8ebc3b690c9195beeca92fe37f1121b410a Partially-Implements: blueprint quantum-qos-api commit cb8fb80a4b62e5d2fb15642c770c3b15495d2bf5 Author: Ihar Hrachyshka Date: Sun Aug 2 17:40:13 2015 +0200 Remove handle_network/handle_subnet from l2 agent extensions L2 agents do not care about networks or subnets, they only care about ports. Change-Id: I3b354765e0efc9fa511421e7acbb937ded1146d8 Partially-Implements: blueprint quantum-qos-api commit 87aa42bc765614750e4f3fab446d03384722133a Author: Ihar Hrachyshka Date: Mon Jul 27 20:53:26 2015 +0200 Moved QOS_POLICY_ID into qos_consts.py Partially-Implements: blueprint quantum-qos-api Change-Id: If789695b4084aed467d5f773c6b6bebea073724d commit f80aa722a664324de1efe453803794a50c9e5cb1 Author: Ihar Hrachyshka Date: Wed Jul 29 13:39:20 2015 +0200 Added missing [qos] section into neutron.conf Also renamed service_notification_drivers into notification_drivers since it's clear where it belongs anyway (it's in neutron.conf meaning it's a server side configuration value). Change-Id: I64610e4b60112daec982a8cacded9b9b936c10bd Partially-Implements: blueprint quantum-qos-api commit 80ff953069dc096383e04350a7013971214e1e5d Author: Ihar Hrachyshka Date: Wed Jul 29 20:34:49 2015 +0200 Enable rule delete test Change-Id: Ic950db35aec66fc0f81070a0641e0473f70d765c Partially-Implements: blueprint quantum-qos-api commit 1f2c05a0b13d429ba6822b2e6acb5b56e10cb0ed Author: Ihar Hrachyshka Date: Wed Jul 29 17:47:21 2015 +0200 objects: consolidate single transaction checks into test_base Cover all base methods with it. Change-Id: I0a6d401f6c1d35cbed397eed79a9aa7db07d179b Partially-Implements: blueprint quantum-qos-api commit 582d03e4642a1eb271c187e65527b0c232548a49 Author: Ihar Hrachyshka Date: Wed Jul 29 15:25:52 2015 +0200 objects.qos.policy: provide rules field, not type specific It should be forbidden to have multiple rules of the same type attached to a policy, so the idea of having per type lists is moot. Instead, we should have a single list of all rules that belong to the policy. Also fixed a test that validated a single transaction to actually work with multiple autonested transactions applied. Partially-Implements: blueprint quantum-qos-api Change-Id: Ia152b3ff385d2aa0cf40664ef039265b046b1d17 commit c9bdcb5557dbf8f782fe502dbb6c98c3550e5241 Author: Ihar Hrachyshka Date: Sat Jul 25 16:21:37 2015 +0200 Unite qos_rules and qos_*_rules tables The only values in qos_rules table are: type, id and qos_policy_id. Both id fields point to qos_*_rules and qos_policies objects. Type is redundant since qos_rule and qos_*_rule objects maintain 1-to-1 relationship. Keeping a separate table just to link qos_*_rule and qos_policy objects has no meaning. At the same time, it complicates the code for rule objects significantly. So instead of copying with all those issues, we just squash the tables into single one. It allows us to reuse all base methods from NeutronObject for rules. LOC stats for the patch clearly shows the point: 65 insertions(+), 267 deletions(-) And no actual functionality is lost. While at it, the following changes were applied: - some base tests are reimplemented to test objects in a more explicit way; - fields_no_update class attribute is now actually enforced in base object class. Partially-Implements: blueprint quantum-qos-api Change-Id: Iadabd14c3490c842608e53ceccf38c79dcdf8d85 commit 3b97f79ab7756a8737df53405b3dd458e79752be Author: John Schwarz Date: Sun Jul 26 16:00:12 2015 +0300 Fix accessing shared policies, add assoc tests This patch is two-fold: 1. Previously, policies that were created using the 'shared=True' flag were not accessible to other tenants, since the context used to search the policies was not elevated. This patch elevates the context prior to retrieving the policy, and if a match was found, makes sure that the user has permissions to access it (either the policy is shared or it's from the same tenant id). 2. Tests for both associations and disassociations of policies to both networks and ports are added in this patch, to make sure coverage is good and that the problem is fixed. Change-Id: Idec13ff4ec575b6d0c0a455c1b3bd9d9700ff7fb commit 11924b11532979090abdba9960dd2dad81debcfe Author: Ihar Hrachyshka Date: Thu Jul 30 13:51:24 2015 +0200 qos: forbid creating rules when there is no access to policy Change-Id: If06de416dfe0eb7115fd4be9feb461fae8e8358d Partially-Implements: blueprint quantum-qos-api commit 3a9c08b80b7f86fa2cd0cbc08de6d1845249ac13 Author: Moshe Levi Date: Wed Jul 15 08:25:38 2015 +0300 SR-IOV: update pci lib to support rate limit Partially-Implements: blueprint ml2-qos Change-Id: I3095f0e8249941f24cbf478cba142135272ebfd3 commit 8c7c33c85678e37da3a40e2167d37f01146ca9cc Author: Ihar Hrachyshka Date: Thu Jul 30 10:46:49 2015 +0200 QosPolicy: made shared field required and with default value = False Change-Id: Icc71ae923d88e2db193d4a33726f8455af4c5dd8 Partially-Implements: blueprint quantum-qos-api commit ec1e812e34339f3d4b2f259a7dd294c5487d8f80 Author: Ihar Hrachyshka Date: Mon Jul 27 16:25:24 2015 +0200 Load the QoS notification driver from the configuration file The agent based RPC notification driver for message queue is the default. Added support for multiple notification drivers. DocImpact Partially-Implements: blueprint quantum-qos-api Change-Id: I4108c3d111067d8217bc4112c05e1bde0125e0ef commit 01e9b771031bd83c12f5ca2f1725927e70050763 Author: Eran Gampel Date: Wed Jul 1 18:32:30 2015 +0300 Add pluggable backend driver for QoS Service notification Added a reference driver for the agent based solutions RPC sending the messages over the message queue Partially-Implements: blueprint quantum-qos-api Change-Id: I725c876739ff85b4db8fb053de0362ce367ae78c commit e7ef7cace1da95e43401a086f314c3cb89d9fc9d Author: Ihar Hrachyshka Date: Mon Jul 27 14:43:56 2015 +0200 Add update tests for policies and rules This patch adds tests for 'update' for both policies and rules. This completes the CRUD tests and leaves the association/disassociation for a later patch. Note that deleting a rule isn't tested explicitly because of a bug with the rule delete logic on the server side. Once that code is fixed, the test should be added. to_dict() for policies should also convert any rules inside rule lists to dicts too, otherwise API layer receives rule object __repr__ strings instead of actual dicts. This patch introduces a fix to the existing to_dict() code to properly support policies. This patch also modifies the base infra to create policies and rules for admins and not for tenant. Partially-Implements: blueprint quantum-qos-api Change-Id: I13870680d7756be9dd020135bc8e91d1c12f728d Co-Authored-By: Ihar Hrachyshka commit 12f7abd3982d3580abdb9055c650bdad50900cf4 Author: Ihar Hrachyshka Date: Thu Jun 11 08:11:08 2015 +0200 Introduce mechanism to determine supported qos rule types for a plugin Every plugin that supports some of QoS rules will define a property called supported_qos_rule_types of list type. For ml2, determine supported qos rule types as a subset of rule types supported by all drivers. (In the future, we may expand the list to include all types supported by at least one of enabled drivers. This would require synchronized work with nova scheduler though.) For ml2, tests are limited, and should be expanded to check that common subset of qos rules is calculated properly when intersection != the list of each plugins. For now, it's enough since we don't have more than one rule type planned for Liberty. Added API test for the resource. Partially-Implements: blueprint ml2-qos Co-Authored-By: Irena Berezovsky Co-Authored-By: John Schwarz Change-Id: I0d18ae256877a129e203110003fcadd1d63590b4 commit a798840a40c3ec00d2b27edb772328403d1376c9 Author: Ihar Hrachyshka Date: Mon Jul 27 15:13:43 2015 +0200 get_info: request object backport only if desired version is different Partially-Implements: blueprint quantum-qos-api Change-Id: I93fde3c472e4ecd7af8a7ce50be832b7216e40f6 commit 612ffff9aff93e3e41c549097a1249f2ea37a8e0 Author: Ihar Hrachyshka Date: Mon Jul 27 13:51:36 2015 +0200 rpc.callbacks.registry: validate that callback provider is registered Partially-Implements: blueprint quantum-qos-api Change-Id: I05e1902c75e4ce5de7f88f5d6281934a3a9a84ac commit 92d94bf020ede2a37c3c966c9ac7ed68b139cccd Author: Ihar Hrachyshka Date: Sat Jul 25 21:35:44 2015 +0200 rpc.callbacks.registry: validate type of callback result Enforce appropriate type for the object returned by rpc callback. Partially-Implements: blueprint quantum-qos-api Change-Id: I994253ac15320254104862d2df8dacfc7fc00014 commit c240d381dc281e542f32045174333dd6909b44d2 Author: Jakub Libosvar Date: Tue Jul 14 14:48:28 2015 +0000 Add UT for agent_extensions_manager Partially-Implements: blueprint quantum-qos-api Change-Id: I86cf669dabbdad9680b6739d59e0f81a74c8629f commit 9193048edf186d90739ff2e1b3d9737fc3ba06fb Author: Ihar Hrachyshka Date: Sat Jul 25 17:42:23 2015 +0200 Don't set tenant_id for rule objects There is no such field anyway. Partially-Implements: blueprint quantum-qos-api Change-Id: Iac895d7eff8dc4f34b56007a48fa6fc64535fca3 commit fd0bf111838b90dcf76d670987770835904810fb Author: Jakub Libosvar Date: Tue Jul 21 11:17:18 2015 +0000 QoS: Remove type attribute from QoS rules The type is given by object itself. We don't specify type when creating resource cause it's a part of uri. This patch allows a bandwidth_limit_rule to be created in given policy. Partially-Implements: blueprint quantum-qos-api Change-Id: Ica4626083054200e3b82bef23984462e7c596e1e commit 5c21e5d826f7e7d184224f3817d8b5ee7346ee9b Author: Ihar Hrachyshka Date: Sat Jul 18 15:47:26 2015 +0200 Don't enforce qos ml2 extension driver It's now enabled in gate for feature/qos, so return to the original version of the code. Depends-On: I421c42aef2cf558935f91a6634a5a5b16e55a606 Change-Id: I5875fb24b7c95efb3bd7cd548bd5d9d21d6544ba commit 301ffb02ecccdddfee361ee6738b7ff84d7cc0d8 Author: Ihar Hrachyshka Date: Fri Jul 24 17:31:50 2015 +0200 ml2: added qos_profile_id to get_device_details payload This is needed to make l2 agent qos extension determine which rules to apply to the port, if any. Partially-Implements: blueprint quantum-qos-api Change-Id: Idefa819f9a21cf53762b1fb923dafb63f2b256e0 commit d2259240bb06f2e1d82465d3ddc0ee7073795087 Author: Moshe Levi Date: Thu Jul 9 13:21:49 2015 +0300 Add versioned object serialize/deserialize for resources RPC Also switched RPC callback API to consistently receive resource_type string and not a resource class. This is because for get_info(), we cannot propagate a class thru RPC but only a string that uniquely identifies the class. So it would be not optimal to require the server to discover the corresponding class from the type name passed from the agent. Also updated some comments in api/rpc/callbacks directory to reflect that we handle NeutronObjects, not dicts. Finally, killed the rule resource registration from QoS plugin and the rule type from supported resources since it's YAGNI at least now. Partially-Implements: blueprint quantum-qos-api Change-Id: I5929338953a2ad7fa68312d79394a306eb0164a2 commit 9599e748cafd504d469a0e225e37ede18345d5ee Author: Ihar Hrachyshka Date: Tue Jul 21 15:37:33 2015 +0200 policy: made attach_* and detach_* methods more robust Handle cases when a policy or a port or a network are not in the database without exposing database level exceptions to object consumers. Change-Id: I06a0b5c4f474b370072f2b6a13146f17a51eb847 commit 7ed1d4f61635e67d0a554ed34540a03222c3f9d3 Author: Jakub Libosvar Date: Tue Jul 21 08:04:00 2015 +0000 Support qos rules and fields parameters in GET requests Previously we didn't load the rules into policy object. This patch adds loading the rules and defines bandwidth_limit_rules as a policy resource in a single transaction. As a part of moving towards usage of single transaction, create() and update() of rule were modified accordingly. Finally, we support types in GET requests in this patch. API tests will follow in different patch. Change-Id: I25c72aae74469b687766754bbeb749dfd1b8867c commit 15b524c0d8e6b723fc5c9861ec6332b785039ff2 Author: Jakub Libosvar Date: Tue Jul 21 11:26:42 2015 +0000 Pass context when deleting bandwidth limit rule Context was missing in db_api leading to crashing when creating transaction. Change-Id: Ib4355481a51c9c568ab821c45b2c6fe863a594dd commit 69f4b813e8a086512f39ee3ef5b8f3354f9af8c0 Author: Ihar Hrachyshka Date: Tue Jul 21 15:05:33 2015 +0200 [qos] cleanup _find_object from neutron.db.api Instead of having a separate function for id-based search, make get_object accept any kwargs, including id=, and reuse it everywhere where we used _find_object before. Change-Id: Ibd94c41fb847d67aabb94172d0117bafc0fdbdf6 commit 517cf5b843922b6a789c4d4fd1381444acbb91d2 Author: Ihar Hrachyshka Date: Wed Jul 22 12:53:00 2015 +0200 Revert "Mute neutron.callbacks notification logs." This reverts commit e19eb49c1c066c8fa4a3c19183bca1daef553a5c. We don't use callbacks to extend resources, so no need to mute the logs. Change-Id: I8eaffa243f74a8f93dfc1638727ac9cd0bdf505d commit 5d58a6877336089ccd89acee6edc2b7c9ee9ee3c Author: Ihar Hrachyshka Date: Wed Jul 22 12:54:53 2015 +0200 qos: kill get_namespace() from service plugin Its usage was removed as of I3c406910991c33cf959c5345d76153eabe3ace2d that is now included in feature/qos branch. Change-Id: Iddab10729cf12e3b7425c5d2298f2a6b3436289c commit e467fb3f5bc3ae925838ad3fc8a7a41185a9c4c1 Author: John Schwarz Date: Tue Jun 30 17:57:19 2015 +0300 Base infrastructure for QoS API tests This introduces the basic methods in the tempest client, that allow the testing of the QoS plugin. This also contains 2 (very) simple tests which test creation and deletion of both policies and bandwidth rules, as well as list/show for both resources. While creation is done explicitly, deletion is done implicitly (all resources are deleted after the test, during tearDown) Minor fixes to the QoS plugin are included as well. Change-Id: I0f34ed8464857859bcd519e301a49b0b067593b0 commit ea02f25fbef43580c619eb778aab3dc874427eef Author: Moshe Levi Date: Wed Jul 15 11:13:50 2015 +0300 Update OVS Agent to work with Agent Extension Mgr Change-Id: I1887d402a4377babb648182727cf51b9f2627e1c commit c22cce92f8cc93392e07124d00771c3c5a962cba Author: Jakub Libosvar Date: Thu Jul 16 14:23:26 2015 +0200 Instantiate qos agent driver Change-Id: Icd8a725f231e2749bb81da0bcad0f7ef95beb676 commit ddd9ee9a4c1dc36b405cb4cb854bb1b46ed32e98 Author: Ihar Hrachyshka Date: Thu Jul 16 15:15:11 2015 +0200 objects.rule: enable database tests for QosRule While at it, simplified inheritance mess in test_policy. Change-Id: I6cf2394a27f8bb29a18c99effe2dc2251c138d59 commit 0395f142031bb200373b439c7798629eee1321eb Author: Mike Kolesnik Date: Wed Jul 15 10:44:15 2015 +0300 Handle qos_policy on network/port create/update Added handling for qos_policy_id field in the network and port entities via ML2 extension driver. The QoS profile will be associated to the network/port when requested as part of the entity creation or update. Allow ML2 extension manager to not register for any api extension (new use case). === Extend the resources using the QoS extension class Since the QoS extension for plugins is handles by this class, it makes sense for it to handle also property extension of resources. For ML2 this means that that extend_{network,port}_dict functions will handle the extension of resources by calling QosExtensionHandler. This logic can easily be reused by other plugins. Note: we should make sure that resource extension does not require db access, otherwise we see DBDeadLock errors and random tempest failures. To achieve this, we define a new SQLAlchemy joined relationship on policy bindings to make networks and ports receive those bindings on their fetch from database. After that, the only work to do left for resource extension handler is to copy the fetched policy into resource dictionary. === Also enable new qos ml2 extension until we configure it in gate via project-config and devstack-gate to make sure it's enabled and tested. Co-Authored-By: Ihar Hrachyshka Partially-implements: blueprint quantum-qos-api Change-Id: I1b7d4611215a471d5c24eb3d7208dcddb7e015f4 commit 0a33e355bcfb0a44ad3617f659ab452a04abdbdb Author: Ihar Hrachyshka Date: Fri Jul 10 18:00:34 2015 +0200 objects.qos.policy: support per type rule lists as synthetic fields This is a significant piece of work. It enables neutron objects to define fields that are lazily loaded on field access. To achieve that, - field should be mentioned in cls.synthetic_fields - obj_load_attr should be extended to lazily fetch and cache the field Based on this work, we define per type rule fields that are lists of appropriate neutron objects. (At the moment, we have only single type supported, but I tried hard to make it easily extendable, with little or no coding needed when a new rule type object definition is added to rule.py: for example, we inspect object definitions based on VALID_RULE_TYPES, and define appropriate fields for the policy object). To implement lazy loading for those fields, I redefined get_by_id for rules that now meld fields from both base and subtype db models into the corresponding neutron object. Added a simple test that checks bandwidth_rules attribute behaves for policies. Some objects unit test framework rework was needed to accomodate synthetic fields that are not propagated to db layer. Change-Id: Ia16393453b1ed48651fbd778bbe0ac6427560117 commit 6140da5f25da126cdbfae3e9ee397315e7834fc5 Author: Miguel Angel Ajo Date: Tue Jul 14 14:31:55 2015 +0200 QoS Service devref This is initial version that should be ready for merge. After we get it in the tree, we'll be able to expand on demand or even as part of patches that change the implementation in significant way. Co-Authored-By: Ihar Hrachyshka Change-Id: I3d89bcbb9c64b87d7425155c33b2f753176e94fd commit 4af0de954aabb51560d4c28f8ea246a53d214b20 Author: Mike Kolesnik Date: Tue Jun 30 12:07:48 2015 +0300 Implement QoS plugin Initial implementation of the QoS service plugin that just implements CRUD for policy and rule. There are no tests yet. path_prefix is now provided as an attribute to the plugin base, since that's required by the COMMON_PREFIXES removal from master branch. Partially-implements: blueprint quantum-qos-api Change-Id: Icf821dec17f435d8e47e1047fb05225e7dd071f0 commit bcb4d237a79be9af18f1bcc792e1827c18b058d2 Author: Kevin Benton Date: Thu Jul 16 02:07:48 2015 -0700 Add oslo db retry decorator to non-CRUD actions The previously added decorators to the create and update handlers in the API layer only applied to actions that followed the standard create/update path. However, for API operations like add_router_interface, a different path is followed that wasn't covered by a retry decorator. This patch adds the decorator to handle deadlocks in those operations as well. Closes-Bug: #1475218 Change-Id: Ib354074e6a3f68cedb95fd774f905d94ca16a830 (cherry picked from commit 435ffa7c67cf8668063588e2af760c1ff595dfbb) commit a1c05891a52fba19dec1122e25144446ee8717ae Author: Jakub Libosvar Date: Tue Jul 14 12:42:57 2015 +0000 Add qos section to ovs agent config [qos] section is introduced with qos driver for ovs agent. Similar manner should follow for all l2 agents using qos with different default drivers. Change-Id: I3c6a3711d3cd9924d55cf6d0ed84be18c993c275 commit e19eb49c1c066c8fa4a3c19183bca1daef553a5c Author: Miguel Angel Ajo Date: Wed Jul 15 15:42:52 2015 +0200 Mute neutron.callbacks notification logs. We believe they could be the source of some yielding, and consequient DBDeadlocks we're experiencing when using AFTER_READ to extend resources. This will need to be revised. Change-Id: I040b3a3c9e137267dfe237dd90fb525026b0d16e commit 1ec79bad468f65d0adfb16f652170f059c92a3bc Author: Jakub Libosvar Date: Wed Jul 15 15:47:40 2015 +0200 Small fixes in test_qos_agent UT Change-Id: Ib09824552edd287ec1df3bdd6700c9ce8a02df29 commit 3cbe446cb6db0ee18c928bb3ec1ff688db5febd4 Author: Gal Sagie Date: Tue Jul 14 17:37:08 2015 +0300 Add unit tests and fixes for OVS Agent QoS Extension Driver Add basic unit tests and fix some of the issues while doing the tests blueprint ml2-ovs-qos-with-bwlimiting Change-Id: I3962dd2c0e1273905781faf3f5c51886dea21cd4 commit cdcffc709baa3290934e6fc3e7f87862dbbbe0e1 Author: Gal Sagie Date: Wed Jul 1 15:36:51 2015 +0300 Add OVS QoS extension agent driver This is a prototype for the OVS agent driver for QoS extension. Should be adjusted to final API's once they are added blueprint ml2-ovs-qos-with-bwlimiting Depends-On: I9e388173dfe0eb43c961018bd687bc86f34c7a6a Change-Id: Ie952b63e3760d1924a34676e97319ec4301effca commit 9544ffb615f69f25268f0f2fd3d92ca4acc7d8cb Author: Moshe Levi Date: Wed Jun 24 18:44:08 2015 +0300 Qos Agent Extension This patch introduces the following: QosAgentExtension - implementation of AgentCoreResourceExtension QosAgentDriver - interface class This will allow any agent to implement their own low level driver for Qos Agent Extension. Co-Authored-By: Miguel Angel Ajo Change-Id: I9e388173dfe0eb43c961018bd687bc86f34c7a6a commit dd6cd44b2155605345a6925d3373bb6afe0bcf62 Author: Miguel Angel Ajo Date: Thu Jul 9 16:39:05 2015 +0200 Implement QoS policy detach from port and network Includes db.qos.api calls to delete port<->qos_profile and network<->qos_profile bindings. Change-Id: I8ab3e885bdf010fe95529157f3db4f1089326c86 commit 6f3b70b5061af332c7accd348ec31b453c272e98 Author: Irena Berezovsky Date: Tue Jul 7 11:54:39 2015 +0000 Add API stub for QoS support rule_type resource Rule_type is added as an API Resource. Using this API User can get list of supported QoS rule types. Change-Id: Ica80753ce3052b68ba8db2d2760ed4310ec0b976 commit 954e9de8b3b697b39e087f2d03b49f0856c44c32 Author: Ihar Hrachyshka Date: Thu Jul 9 14:12:56 2015 +0200 objects.base: fixed object.delete() It was using wrong call to delete an object from a session. Also, expanded test_create() test to check all basic operations: get_by_id, create, update, and delete. To facilitate update() check, introduced a new field for objects called fields_to_update that stores names of fields that are not expected to be updated in an object. This allows us to keep the above mentioned test untangled from specific object type. Also made get_by_id() behave correctly (returning None) if the object does not exist. Change-Id: I1aecb2e7c4d8cb8f239072d1cb9df3db29dcedde commit 31e09028e3b3c85954a9aebf32c412bd897afdbb Author: Ihar Hrachyshka Date: Thu Jul 9 12:37:01 2015 +0200 objects.qos.policy: fixed get_*_policy and attach_* methods Added sql unit tests for those methods. Change-Id: I6e95aa6cb61d5cc36600394b2198587793da8a0e commit 3edec57c2250daafdcdac88581efa1acc5acf237 Author: Ihar Hrachyshka Date: Wed Jul 8 18:06:12 2015 +0200 objects.base: reset changes after getting objects from database Now all objects are comparable. We need to reset changes, otherwise an object that is constructed and .create()d is different from the one that is .get_by_id()d from database (for primitive serialization contains list of changed fields for versioned objects). Added initial sql test case for objects (just create-fetch for policy for now, but can be easily extended to other types). Change-Id: I012b5fe4e95f166f66da91274734d7184c224dfd commit 78703ddefbbf93dda8ecb173f14086880bb9f82f Author: Ihar Hrachyshka Date: Wed Jul 8 17:47:12 2015 +0200 BaseObjectTestCase: rename test_class into _test_class It seems that testtools are trying to load that class as if it's a test case (for it considers everything inside a test class named as test_* as a test case). Change-Id: Ic4342cc0637d659191f084467ccdb9c90e89a023 commit 00589382cf1ea7034d5dee5aec8bf3814f7e92a5 Author: John Schwarz Date: Thu Jul 2 12:40:11 2015 +0300 Cleanup rule models and objects - drop tenant_id for base and bandwidth_limit rules; - added 'to_dict' function to convert objects into dicts. Change-Id: I28167e356e70235304b166c997df52ca1b28f836 commit a71cb067d0100a1ec3f6df037c6c4740a6b2771a Author: Ihar Hrachyshka Date: Fri Jul 3 01:57:03 2015 +0300 objects.qos: fixed create and update for QosBandwidthLimitRule To simplify Qos*Rule object type implementation, renamed 'qos_rule_id' field for qos_bandwidth_limit_rule table into 'id'. Also added unit test coverage for the object type. Change-Id: Id6bc992af9f1ab46c022d3c88aa66a0f3bb7f227 commit cbc7826f2c0b77f1283ed62a3adb332c639cbdd5 Author: Ihar Hrachyshka Date: Fri Jul 3 00:52:20 2015 +0300 objects.qos: added unit tests for QosPolicy neutron object Change-Id: Icecb3fc08c81bd9fb9f8bad54ed800a4eb55d399 commit 878e85527fa6833a85d7d9ad15e63e26aeb00ccd Author: Ihar Hrachyshka Date: Thu Jul 2 23:30:36 2015 +0300 objects.base: avoid db access if object does not have changes Also cover base object with unit tests. Change-Id: I2f58c767ba35eeee2f9ecc363e5b042ea8638faa commit 4ee9eebd7dd5ed7c87d481eda500b664ae564644 Author: John Schwarz Date: Thu Jul 2 12:32:05 2015 +0300 QoS extension fixes This patch introduces small fixes to the QoS extensions: 1. Adding a common tenant_id field for QoS API calls. 2. Making sure the function interface is correct. Co-Authored-By: Irena Berezovsky Change-Id: If9c7a7b9b8a5d2367d8f3225fbf07d8e3ec8865d commit c26142be338ef14f5fd0a4c7aa5b4ac42bc685d1 Author: Moshe Levi Date: Wed Jun 24 18:10:05 2015 +0300 AgentExtensionsManager and AgentCoreResourceExtension This patch introduces the following classes: L2Agent - abstract class for common L2Agent implementions. AgentExtensionsManager - to load AgentCoreResourceExtension. AgentCoreResourceExtension - interface class to define the AgentCoreResourceExtension API. This allows better segregation between L2 Agent Core and L2 Agent Extensions. The patch is missing unit test but it was tested manually. I added a unit tests @TODO comments to come back to them later. Change-Id: I813de7ff1bee188f4294f4b3eb3645ebd903297b commit 2d38c742e84aebccd367eb7312ddaaeb0d02bc01 Author: Moshe Levi Date: Tue Jun 30 22:23:26 2015 +0300 Generic Resources RPC This patch adds Generic Resource RPC from agent to server. Change-Id: I0ac8a009e781b6edb283d8634b1a2f047db092dc commit dc802438887265c1faa0a92df7c7c701854cf5fc Author: Miguel Angel Ajo Date: Thu Jun 11 15:21:28 2015 +0200 Generic rpc callback mechanism which could be reused This is a publisher/subscriber messaging mechanism optimized for agent consumption and server production without the need of creating new rpc messages when new resources are introduced. Oslo versionedobjects are the perfect match to ensure cross version compatibility even if the published/subscribed resources format change over time. This is still a basic stub allowing get_info of the resources, and the next change will introduce the RPC methods to call get_info: I0ac8a009e781b6edb283d8634b1a2f047db092dc The plugin is returning stub objects to be consumed from the agent to test the basic behaviour until we have DB. TODO: Update documentation, according to code changes, enforce versioned objects only doing deserial/serialization. Co-Authored-By: Miguel Angel Ajo Co-Authored-By: Eran Gampel Change-Id: I524cf5a14e99dc6bee4d4261557d98c75efa0809 commit e3dba1424114575581c153e02227282e036ad0a2 Author: Miguel Angel Ajo Date: Fri Jun 19 16:43:52 2015 +0200 Introduce the AFTER_READ callback for ports and networks This callback can be used by extensions and service plugins to extend port and network information on read time, without the need of plugin mixins. Partially-implements: blueprint quantum-qos-api Change-Id: Ifc92c19a69d28784c030d605c2eb161c2ba4b3f5 commit 3de65f57e30b73f5d7efc0344a102f1e40a6b40e Author: Mike Kolesnik Date: Tue Jun 30 15:21:30 2015 +0300 Add extension callbacks support for networks Add callbacks for extention to the network resource so that interested extensions can do custom logic when a network is created or updated. Currently it will be done the same way port notifications are done - i.e. only in ML2 plugin. We can revisit this in a floow up patch if the whole notification logic should be moved somewhere else as this merits further discussion which is out of scope for a mere patch. This will be utilized in a follow up commit. Partially-implements: blueprint quantum-qos-api Change-Id: I38528863e1145caf05fe3b2425511d1c5b5c0f93 commit b167ec6d4f5577c54a1a02e6a835b875a6e2150a Author: Ihar Hrachyshka Date: Thu Jul 2 11:14:17 2015 +0300 [qos] policy: add methods to interact with policy bindings Detachment is not supported in this patch. blueprint quantum-qos-api Change-Id: I66f87b99241a25d39d08c124bae3779c872bc567 commit e90b28662eb769e26f2f6c202a71910819c3ff41 Author: Ihar Hrachyshka Date: Tue Jun 30 13:32:27 2015 +0300 First QoS versioned objects, ever Well, first versioned objects in the tree. Binding to networks and ports is not implemented. No tests. Checked manually. blueprint quantum-qos-api Co-Authored-By: vikram.choudhary Change-Id: I9b6cacfda4f40230d746222bed5b6c490be63743 commit 3d6666af4921a28ccb95d25d88087e89e23e3ec5 Author: Gal Sagie Date: Wed Jul 1 19:15:55 2015 +0300 Add bandwidth_limit rule type constant Change-Id: I7228b3a288848833947271a0966ca415bfaa07c4 commit 3e2ef95dfdfe19a0097f8d68f453cbabbb8f2169 Author: Irena Berezovsky Date: Tue Jun 30 12:04:39 2015 +0000 Add bandwidth_limit rules as sub-collection of qos policy This patch add support for qos extension according to the spec modification [1]. [1] https://review.openstack.org/#/c/197004/ Change-Id: I9226932191464face6e20625e35ad4b7529db4ca commit 4310b4c2a68914aa78275a78f882c70eb57c1fde Author: Ramanjaneya Date: Wed Jun 24 17:24:11 2015 +0530 QoS: db models and migration rules This patch includes db models and migration rules for initial QoS objects. Comparing to the spec, it adds two more service tables to maintain links between networks and ports and their respective policies. We maintain uniqueness as a unique constraint. In some parallel world, we could have an additional field for networks and ports that could be nullable to point to a policy. That said, it breaks qos isolation a bit, and will also be a bit more painful if and when we decide to spin out qos service pieces outside the tree. blueprint quantum-qos-api Co-Authored-By: Ramanjaneya Co-Authored-By: vikram.choudhary Co-Authored-By: Ihar Hrachyshka Co-Authored-By: Miguel Angel Ajo Change-Id: I55a7dac602e2e770c21b6c7957430cb7115e5bdc commit be1d242fa3efcef9e7095fbbf0e2de022fa86a45 Author: Gal Sagie Date: Sat Jun 27 13:16:11 2015 +0300 Add Create/Destroy API to OVS QoS BW Limiting Add infrastructure needed for the implementations (CLI and native) and add API to ovs_lib Add functional tests for ovs_lib blueprint ml2-ovs-qos-with-bwlimiting Change-Id: Ided0740548987ca91f1549f251c7906e6449f91d commit b17f865f85fddafaab367f55470c2b7ae8135e62 Author: Ihar Hrachyshka