DVR issues with supporting multiple subnets per network on DVR routers - PortbindingContext does not have the status.
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | neutron |
Critical
|
Swaminathan Vasudevan | ||
Bug Description
DVR today has issues with supporting multiple subnets per network on its routers.
| Changed in neutron: | |
| assignee: | nobody → Swaminathan Vasudevan (swaminathan-vasudevan) |
On further investigation it seems that even when a "single" IPv4 router-interface port is updated with a new IP address then the L2pop - update-
See the failure logs below.
For some reason when a port update happens the PortContext is provided for DVR Routed ports instead of the DVRPortbinding context.
| Changed in neutron: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| summary: |
- DVR issues with supporting multiple subnets per network on DVR routers + DVR issues with supporting multiple subnets per network on DVR routers - + PortbindingContext does not have the status. |
| Kyle Mestery (mestery) wrote : | #3 |
This seems critical since it's blocking the DVR job from running. Swami, are you going to fix this in Neutron itself? I think Yamamoto can possibly fix this if you don't have time, I've added him to the bug.
| Changed in neutron: | |
| importance: | Medium → Critical |
Hi Kyle, yes I am currently investigating the problem and also working with Rob Kukura to understand the port-binding issues.
I can work with Yamamoto if he has some bandwith to help on this issue.
First patch.
https:/
| Changed in neutron: | |
| status: | Confirmed → In Progress |
With current review comments, I tried to refactor the patch and I am seeing another issue, where the "DVR Port Binding" is not returning "binding-list" when the first time the update_port is called.
Later the binding-list is visible, so there is no way to make this code generic.
See the logs in the paste bin.
Search for "Binding List" and this will show in the beginning the list is empty and later gets populated.
| YAMAMOTO Takashi (yamamoto) wrote : | #7 |
Swaminathan, i couldn't find "Binding List". maybe paste truncated the log?
Yamamoto , yes I think the paste is truncated.
The log is too big for some reason I could not upload all the logs.
But what is happening here is, sync_routers is were the "dvr binding is introduced".
In this case, there is a timing issue where before the port is binding, the update_port is called while add_router_
In this case, the first time when the "dvr port binding" is fetched for the port, it returns an empty list.
So when I use the same list for processing all other function calls, the list returns "out-of-bound" errors.
You can look at the "logstash" for the patch with the current changes in the code.
| YAMAMOTO Takashi (yamamoto) wrote : | #9 |
The patch is up for review. It would be great if anyone can review it.
| Changed in neutron: | |
| assignee: | Swaminathan Vasudevan (swaminathan-vasudevan) → Carl Baldwin (carl-baldwin) |
| Changed in neutron: | |
| assignee: | Carl Baldwin (carl-baldwin) → Swaminathan Vasudevan (swaminathan-vasudevan) |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 9eed4167b63f0c0
Author: Swaminathan Vasudevan <email address hidden>
Date: Mon Jun 29 16:19:49 2015 -0700
Fix update_
Updating DVR Router interface ports was throwing
errors in the l2pop mechanism drivers function
update_
PortContext's portbinding information does not show
the status of the ports. For DVR Router interface
ports the DVRPortbinding table contains the status
information for the ports.
In the case of the update_port method, there was
no code related to DVR that retreives the port
binding information from the DVRPortBinding table.
This was working before, since in the driver_context,
the PortContext was just returning the port status for
all router interfaces.
With the recent refactor to the driver_context, this
behavior changed and the PortContext was returning the
_binding.status for the DVR router interface ports and
the _port.status for the non DVR ports.
When the update_port function calls update_
with PortContext for DVR router interface ports, l2pop
was throwing an error saying that Portbinding does not
have the attribute 'status'.
This was causing addition of any second subnet to the
same network with respect to IPv6 to fail.
Because in the case of IPv6, when you add additional
subnets to the existing network, it just updates the port
with the IPv6 prefix instead of creating additional port.
In the case of IPv4 still we could see that there are
two different ports created for each subnet we try to
add.
This patch fixes the above issue in l2pop and allows the
DVR router interface ports to be successfull.
Also the _find_ipv6_
all the ports for DVR including the DVR CSNAT internal
ports which are not part of the router interface ports.
This patch also fixes this problem by returning false,
when it finds a DVR SNAT port.
Closes-Bug: #1465434
Change-Id: Id243a4b3f30071
| Changed in neutron: | |
| status: | In Progress → Fix Committed |
| Changed in neutron: | |
| milestone: | none → liberty-2 |
| status: | Fix Committed → Fix Released |
Fix proposed to branch: feature/pecan
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: feature/pecan
commit 991ea00e6c11534
Author: Moshe Levi <email address hidden>
Date: Thu Jul 30 12:04:15 2015 +0300
SR-IOV: Fix SR-IOV agent to run ip link commands as root
Commit https:/
remove the remaining root_helper args, but didn't
update the SR-IOV agent to execute them as root.
This patch updates the agent to execute ip link commands
as root and pass options argument as a list in the
self._as_root method.
Closes-Bug: #1479694
Change-Id: I53cafd61845a69
commit 5b3bacedf6c0148
Author: Saksham Varma <email address hidden>
Date: Thu Jul 23 22:46:23 2015 -0700
Moved out cisco n1kv mech driver and db models
Moving out Cisco N1Kv database models and the mech driver
to the openstack/
phase vendor-core decomposition
Partial-Bug: #1479123
Partial-
Change-Id: I65a704b238d8cb
commit 65ac8cd0a80548e
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Jul 29 20:44:01 2015 +0000
Updated from global requirements
Change-Id: I3a884a73d51df0
commit f0e8356d04d0460
Author: sridhargaddam <email address hidden>
Date: Mon Jul 27 03:46:48 2015 +0000
Update dhcp agent cache for network:dhcp ports
When a network with a dhcp_enabled subnet is scheduled on a dhcp
agent, dhcp driver creates the network:dhcp port for the subnet.
However, the port info is not updated in dhcp agents internal cache.
Subsequently if the user deletes the network:dhcp port, the port is
properly deleted on the server side (i.e., in the database) and when
the port_delete_end notification is sent to the dhcp agent, it simply
ignores it as the port entry would be missing in the cache. This patch
fixes this issue by updating the dhcp agents cache when dhcp driver
creates the network:dhcp port for the subnets.
Closes-Bug: #1478426
Change-Id: I69f5834dd964a4
commit cb60d0bb4e0cc0c
Author: changzhi <email address hidden>
Date: Thu Jul 16 10:14:16 2015 +0800
Keep dns nameserver order consistency
Currently, there is no dns servers prioritization for subnets
for Neutron.
Generally speaking, it is useful to keep the order of dns
nameservers consistent. Add a new column named 'order' in table
'dnsnameser
Closes-Bug: #1218629
Implements: blueprint keep-dns-
Change-Id: Id937aea411397d
commit b39e1469e824bc8
Author: Salvatore Orlando <email address hidden>
Date: Tue Jun 23 04:54:2...
| tags: | added: in-feature-pecan |
| Changed in neutron: | |
| milestone: | liberty-2 → 7.0.0 |
| tags: | added: kilo-backport-potential |
Fix proposed to branch: stable/kilo
Review: https:/
Change abandoned by Erik Colnick (<email address hidden>) on branch: stable/kilo
Review: https:/
Reason: Not convinced this was actually an issue in kilo. Abandoning.
Change abandoned by Erik Colnick (<email address hidden>) on branch: stable/kilo
Review: https:/
Reason: This particular change is not backwards compatible owing to modification in the abstract interface for PortContext, which will break other existing implementations of the interface.
This is exposed when the IPv6 tempest test "test_multi_