neutron

Improve OVS agent init method

Bug #1464394 reported by Gal Sagie
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Sergey Belous

Bug Description

Currently the agent init method takes the configuration object cfg.CONF but also there is a method which creates specific configurations dictionary according to it and call the agent with that structure.

One method should be picked and code needs to be aligned as this is causing confusion and makes it hard to track

Gal Sagie (gal-sagie)
Changed in neutron:
assignee: nobody → Gal Sagie (gal-sagie)
Eugene Nikanorov (enikanorov)
Changed in neutron:
importance: Undecided → Wishlist
tags: added: low-hanging-fruit
Changed in neutron:
status: New → Confirmed
Sergey Belous (sbelous)
Changed in neutron:
assignee: Gal Sagie (gal-sagie) → Sergey Belous (sbelous)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/230537

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/251494

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/230537
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a88fdfc8e113f076603f336befc90500145353ed
Submitter: Jenkins
Branch: master

commit a88fdfc8e113f076603f336befc90500145353ed
Author: Sergey Belous <email address hidden>
Date: Fri Oct 2 19:24:29 2015 +0300

    Refactor OVS-agent init-method

    Removed create_agent_config_map method which creates specific
    configurations dictionary according to cfg.CONF and call the OVS-agent
    with that structure. Passing oslo_config directly to init-method
    of OVS-agent is more straightforward and makes it more testable.
    Also refactored unit and functional tests of OVS-agent in accordance
    with the changes in init-method.

    Closes-bug: #1464394
    Change-Id: I88742e4d454709e35481f2c505c9d64995497cac

Changed in neutron:
status: In Progress → Fix Committed
Doug Hellmann (doug-hellmann)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/251494
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=58ea633fa44d8994596055a23cfde260e6d9d9c9
Submitter: Jenkins
Branch: master

commit 58ea633fa44d8994596055a23cfde260e6d9d9c9
Author: Cedric Brandily <email address hidden>
Date: Mon Nov 30 19:05:18 2015 +0100

    Refactor OVS-agent tunnel config validate

    This change transforms validate_local_ip into a sub-method of
    validate_tunnel_config and raises directly SystemExit instead of
    indirectly.

    Related-bug: #1464394
    Change-Id: I35addd41e1a8b061bd0e5e6656a1728fb7fe04ce

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.