ipset can't be destroyed when last sg rule is deleted

Bug #1460562 reported by shihanzhang
14
This bug affects 5 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
shihanzhang
Juno
Fix Released
Undecided
Unassigned
Kilo
Fix Released
Undecided
Unassigned

Bug Description

reproduce steps:
1. a VM A in default security group
2. default security group has rules: 1. allow all traffic out; 2. allow it self as remote_group in
3. firstly delete rule 1, then delete rule2

I found the iptables in compute node which VM A resids didn't be reload, and the relevant ipset didn't be destroyed.

tags: added: ipset
Changed in neutron:
assignee: nobody → shihanzhang (shihanzhang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/187483

Changed in neutron:
status: New → In Progress
Revision history for this message
yalei wang (yalei-wang) wrote :

is this a regression issue?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by shihanzhang (<email address hidden>) on branch: master
Review: https://review.openstack.org/187483
Reason: this bug can be fixed in patch #https://review.openstack.org/#/c/189171/, please help to review it

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/187483
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=764f018f50ac7cd42c29efeabaccbb5aec21f6f4
Submitter: Jenkins
Branch: master

commit 764f018f50ac7cd42c29efeabaccbb5aec21f6f4
Author: shihanzhang <email address hidden>
Date: Mon Jun 1 16:17:37 2015 +0800

    Fix ipset can't be destroyed when last rule is deleted

    when it deletes a security group all rules, it should
    include this sg information in RPC method
    'security_group_info_for_devices', otherwise the ports
    in this sg can't corrcectly update their iptables and
    ipset sets.

    Change-Id: Ibb071ce84590bd46cda2c1e010a566e75e22b4d2
    Closes-bug: #1460562

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/211492

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (37.3 KiB)

Reviewed: https://review.openstack.org/211492
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a7b91632fc65ab9d2687298c68b1d715866d0356
Submitter: Jenkins
Branch: feature/pecan

commit 966203f89dee8fe61fb2dce654e36e510e80380f
Author: Sukhdev Kapur <email address hidden>
Date: Wed Jul 1 16:30:44 2015 -0700

    Neutron-Ironic integration patch

    This patch is in preparation for the integration
    of Ironic and Neutron. A new vnic_type is being
    added so that ML2 drivers can filter for all
    Ironic ports based upon match for 'baremetal'.
    Nova/Ironic will set this vnic_type when issuing
    port-create request to neutron.
    (e.g. binding:vnic_type = 'baremetal' )

    Change-Id: I25dc9472b31db052719db503a10c1fb1a55572ef
    Partial-Implements: blueprint neutron-ironic-integration

commit 236e408272bcb9b8e957524864e571b5afdc4623
Author: Oleg Bondarev <email address hidden>
Date: Tue Jul 7 12:02:58 2015 +0300

    DVR: fix router scheduling

    Fix scheduling of DVR routers to not stop scheduling once
    csnat portion was scheduled. See bug report for failing
    scenario.

    This partially reverts
    commit 3794b4a83e68041e24b715135f0ccf09a5631178
    and fixes bug 1374473 by moving csnat scheduling
    after general dvr router scheduling, so double binding does
    not happen.

    Closes-Bug: #1472163
    Related-Bug: #1374473
    Change-Id: I57c06e2be732e47b6cce7c724f6b255ea2d8fa32

commit e152f93878b9bb6af7cfedc9e045892fcf7d0615
Author: Assaf Muller <email address hidden>
Date: Sat Aug 8 21:15:03 2015 +0300

    TESTING.rst love

    Change-Id: I64b569048f8f87ea2fe63d861302b4020d36493d

commit 633c52cca1b383af2c900e1663c8682114acd177
Author: sridhargaddam <email address hidden>
Date: Wed Aug 5 10:49:33 2015 +0000

    Avoid dhcp_release for ipv6 addresses

    dhcp_release is only supported for IPv4 addresses [1] and not for
    IPv6 addresses [2]. There will be no effect when it is called with
    IPv6 address. This patch adds a corresponding note and avoids calling
    dhcp_release for IPv6 addresses.

    [1] http://manpages.ubuntu.com/manpages/trusty/man1/dhcp_release.1.html
    [2] http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2013q2/007084.html

    Change-Id: I8b8316c9d3d011c2a687a3a1e2a4da5cf1b5d604

commit 2de8fad17402f38bbc30204ee2f4f99cf21cb69d
Author: OpenStack Proposal Bot <email address hidden>
Date: Mon Aug 10 06:11:06 2015 +0000

    Imported Translations from Transifex

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I2b423e83a7d0ac8b23239f81fe33dd8382c6fff6

commit fef79dc7b9162e03c8891645494c115b52d4d014
Author: Henry Gessau <email address hidden>
Date: Mon Aug 3 23:30:34 2015 -0400

    Consistent layout and headings for devref

    The lack of convention for heading levels among the independently
    written devref documents was starting to make the Table of Contents
    look rather messy when rendered in HTML.

    This patch does not cover the "Neutron Internals" section since its
    layo...

tags: added: in-feature-pecan
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/224517

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/224528

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/kilo)

Reviewed: https://review.openstack.org/224517
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=114949b789eca7ef88ec4c43f1bb0b7233abd69c
Submitter: Jenkins
Branch: stable/kilo

commit 114949b789eca7ef88ec4c43f1bb0b7233abd69c
Author: shihanzhang <email address hidden>
Date: Mon Jun 1 16:17:37 2015 +0800

    Fix ipset can't be destroyed when last rule is deleted

    when it deletes a security group all rules, it should
    include this sg information in RPC method
    'security_group_info_for_devices', otherwise the ports
    in this sg can't corrcectly update their iptables and
    ipset sets.

    Change-Id: Ibb071ce84590bd46cda2c1e010a566e75e22b4d2
    Related-bug: #1491131
    Closes-bug: #1460562
    (cherry picked from commit 764f018f50ac7cd42c29efeabaccbb5aec21f6f4)

tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/juno)

Reviewed: https://review.openstack.org/224528
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d567d57f72ae9699442ca999ce347074ad8df886
Submitter: Jenkins
Branch: stable/juno

commit d567d57f72ae9699442ca999ce347074ad8df886
Author: shihanzhang <email address hidden>
Date: Mon Jun 1 16:17:37 2015 +0800

    Fix ipset can't be destroyed when last rule is deleted

    when it deletes a security group all rules, it should
    include this sg information in RPC method
    'security_group_info_for_devices', otherwise the ports
    in this sg can't corrcectly update their iptables and
    ipset sets.

    Related-bug: #1491131
    Closes-bug: #1460562
    (cherry picked from commit 764f018f50ac7cd42c29efeabaccbb5aec21f6f4)
    (cherry picked from commit 114949b789eca7ef88ec4c43f1bb0b7233abd69c)

    Conflicts neutron/tests/unit/test_security_groups_rpc.py, tests
    adapted for py26 compatibility.
    Change-Id: Ibb071ce84590bd46cda2c1e010a566e75e22b4d2

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-3 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.