neutron

neutron-ovs-cleanup failing to start with ovs bonding

Bug #1460494 reported by Ross Krumbeck on 2015-06-01

This bug affects 5 people

Affects		Status	Importance	Assigned to	Milestone
	neutron	Fix Released	Medium	yalei wang

Bug Description

System is running Openstack Kilo:

[root@network01 ~]# cat /etc/redhat-release
CentOS Linux release 7.1.1503 (Core)

[root@network01 ~]# uname -r
3.10.0-229.4.2.el7.x86_64

[root@network01 ~]# rpm -qa|grep neutron
openstack-neutron-ml2-2015.1.0-1.el7.noarch
openstack-neutron-common-2015.1.0-1.el7.noarch
openstack-neutron-openvswitch-2015.1.0-1.el7.noarch
python-neutronclient-2.3.11-1.el7.noarch
python-neutron-2015.1.0-1.el7.noarch
openstack-neutron-2015.1.0-1.el7.noarch

Issue is with python-neutron-2015.1.0-1.el7.noarch line 316 of:

/usr/lib/python2.7/site-packages/neutron/agent/common/ovs_lib.py

get_vif_ports function is expecting that each ovs port will have an interface with a matching name, i.e. ovs port eth0 must have ovs Interface with name eth0. This does not work for bonded interfaces created within ovs as port bond2 may have Interface eth0 and Interface eth1 as an example.

2015-05-29 16:53:06.034 2833 INFO neutron.common.config [-] Logging enabled!
2015-05-29 16:53:06.039 2833 INFO neutron.common.config [-] /usr/bin/neutron-ovs-cleanup version 2015.1.0
2015-05-29 16:53:06.502 2833 ERROR neutron.agent.ovsdb.impl_vsctl [-] Unable to execute ['ovs-vsctl', '--timeout=10', '--oneline', '--format=json', '--', '--columns=external_ids', 'list', 'Interface', 'bond2'].
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl Traceback (most recent call last):
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl File "/usr/lib/python2.7/site-packages/neutron/agent/ovsdb/impl_vsctl.py", line 63, in run_vsctl
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl log_fail_as_error=False).rstrip()
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl File "/usr/lib/python2.7/site-packages/neutron/agent/linux/utils.py", line 137, in execute
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl raise RuntimeError(m)
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl RuntimeError:
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl Command: ['sudo', 'neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'ovs-vsctl', '--timeout=10', '--oneline', '--format=json', '--', '--columns=external_ids', 'list', 'Interface', 'bond2']
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl Exit code: 1
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl Stdin:
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl Stdout:
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl Stderr: ovs-vsctl: no row "bond2" in table Interface
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl
2015-05-29 16:53:06.502 2833 TRACE neutron.agent.ovsdb.impl_vsctl
2015-05-29 16:53:06.503 2833 CRITICAL neutron [-] RuntimeError:
Command: ['sudo', 'neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'ovs-vsctl', '--timeout=10', '--oneline', '--format=json', '--', '--columns=external_ids', 'list', 'Interface', 'bond2']
Exit code: 1
Stdin:
Stdout:
Stderr: ovs-vsctl: no row "bond2" in table Interface

2015-05-29 16:53:06.503 2833 TRACE neutron Traceback (most recent call last):
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/bin/neutron-ovs-cleanup", line 10, in <module>
2015-05-29 16:53:06.503 2833 TRACE neutron sys.exit(main())
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/lib/python2.7/site-packages/neutron/cmd/ovs_cleanup.py", line 100, in main
2015-05-29 16:53:06.503 2833 TRACE neutron ports = collect_neutron_ports(available_configuration_bridges)
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/lib/python2.7/site-packages/neutron/cmd/ovs_cleanup.py", line 60, in collect_neutron_ports
2015-05-29 16:53:06.503 2833 TRACE neutron ports += [port.port_name for port in ovs.get_vif_ports()]
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/lib/python2.7/site-packages/neutron/agent/common/ovs_lib.py", line 316, in get_vif_ports
2015-05-29 16:53:06.503 2833 TRACE neutron check_error=True)
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/lib/python2.7/site-packages/neutron/agent/common/ovs_lib.py", line 139, in db_get_val
2015-05-29 16:53:06.503 2833 TRACE neutron check_error=check_error)
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/lib/python2.7/site-packages/neutron/agent/ovsdb/impl_vsctl.py", line 83, in execute
2015-05-29 16:53:06.503 2833 TRACE neutron txn.add(self)
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/lib/python2.7/site-packages/neutron/agent/ovsdb/api.py", line 68, in __exit__
2015-05-29 16:53:06.503 2833 TRACE neutron self.result = self.commit()
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/lib/python2.7/site-packages/neutron/agent/ovsdb/impl_vsctl.py", line 50, in commit
2015-05-29 16:53:06.503 2833 TRACE neutron res = self.run_vsctl(args)
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/lib/python2.7/site-packages/neutron/agent/ovsdb/impl_vsctl.py", line 70, in run_vsctl
2015-05-29 16:53:06.503 2833 TRACE neutron ctxt.reraise = False
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/lib/python2.7/site-packages/oslo_utils/excutils.py", line 85, in __exit__
2015-05-29 16:53:06.503 2833 TRACE neutron six.reraise(self.type_, self.value, self.tb)
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/lib/python2.7/site-packages/neutron/agent/ovsdb/impl_vsctl.py", line 63, in run_vsctl
2015-05-29 16:53:06.503 2833 TRACE neutron log_fail_as_error=False).rstrip()
2015-05-29 16:53:06.503 2833 TRACE neutron File "/usr/lib/python2.7/site-packages/neutron/agent/linux/utils.py", line 137, in execute
2015-05-29 16:53:06.503 2833 TRACE neutron raise RuntimeError(m)
2015-05-29 16:53:06.503 2833 TRACE neutron RuntimeError:
2015-05-29 16:53:06.503 2833 TRACE neutron Command: ['sudo', 'neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'ovs-vsctl', '--timeout=10', '--oneline', '--format=json', '--', '--columns=external_ids', 'list', 'Interface', 'bond2']
2015-05-29 16:53:06.503 2833 TRACE neutron Exit code: 1
2015-05-29 16:53:06.503 2833 TRACE neutron Stdin:
2015-05-29 16:53:06.503 2833 TRACE neutron Stdout:
2015-05-29 16:53:06.503 2833 TRACE neutron Stderr: ovs-vsctl: no row "bond2" in table Interface
2015-05-29 16:53:06.503 2833 TRACE neutron
2015-05-29 16:53:06.503 2833 TRACE neutron

ovs_lib.py should be updated so that for an ovs bond port all interfaces belonging to the bond are looked up without relying on the name of the Interface to be matching.

See original description

Tags:

Ross Krumbeck (rkrum) on 2015-06-01

description:

updated

Revision history for this message

Ross Krumbeck (rkrum) wrote on 2015-06-01:

A work around is to configure standard linux bonding, then add linux bond interface as an ovs port (rather than creating bond within openvswitch).

description:

updated

yalei wang (yalei-wang) on 2015-06-09

Changed in neutron:
assignee:	nobody → yalei wang (yalei-wang)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-06-09: Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/189568

Changed in neutron:
status:	New → In Progress

Kyle Mestery (mestery) on 2015-07-17

Changed in neutron:
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-07-21:

Fix proposed to branch: master
Review: https://review.openstack.org/203992

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-07-23: Fix merged to neutron (master)

Reviewed: https://review.openstack.org/189568
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b4e42a341894177a1c870a48b2641bae6c36696e
Submitter: Jenkins
Branch: master

commit b4e42a341894177a1c870a48b2641bae6c36696e
Author: Yalei Wang <email address hidden>
Date: Tue Jun 9 13:46:57 2015 +0800

Add new ovs DB API to inquire interfaces name list in a bridge

    In OVS, ports don't equal to interfaces when a bond port created. This patch
    add the new API get_iface_name_list to get the interfaces' name, and it's
    supplementary to the current get_port_name_list API.

Change-Id: I29c220e099b8dcf78248e2d660c435578bb2932d
Partial-Bug: #1460494

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-07-31: Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/207903

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-08-01: Fix merged to neutron (feature/pecan)

Download full text (70.7 KiB)

Reviewed: https://review.openstack.org/207903
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9badcd249dab2d3330f0cd608496b59c9f44499a
Submitter: Jenkins
Branch: feature/pecan

commit 991ea00e6c115343eabecc62e86072175823f81f
Author: Moshe Levi <email address hidden>
Date: Thu Jul 30 12:04:15 2015 +0300

SR-IOV: Fix SR-IOV agent to run ip link commands as root

    Commit https://review.openstack.org/#/c/155523/
    remove the remaining root_helper args, but didn't
    update the SR-IOV agent to execute them as root.

    This patch updates the agent to execute ip link commands
    as root and pass options argument as a list in the
    self._as_root method.

Closes-Bug: #1479694
Change-Id: I53cafd61845a69fae3a759fb7526950d655ffa20

commit 5b3bacedf6c014815bef03c2e821b5eb8ef92dcb
Author: Saksham Varma <email address hidden>
Date: Thu Jul 23 22:46:23 2015 -0700

Moved out cisco n1kv mech driver and db models

    Moving out Cisco N1Kv database models and the mech driver
    to the openstack/networking-cisco repo as part of the second
    phase vendor-core decomposition

Partial-Bug: #1479123
Partial-implements: blueprint core-vendor-decomposition

Change-Id: I65a704b238d8cbe2951a6912fa4f1e8518c6f412

commit 65ac8cd0a80548e115b8ec1d4cfd47a94422fddf
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Jul 29 20:44:01 2015 +0000

Updated from global requirements

Change-Id: I3a884a73d51df0f93b5cc88b3e3250d81bb1f455

commit f0e8356d04d04600c072a1c0f0bdf274ff19ab8c
Author: sridhargaddam <email address hidden>
Date: Mon Jul 27 03:46:48 2015 +0000

Update dhcp agent cache for network:dhcp ports

    When a network with a dhcp_enabled subnet is scheduled on a dhcp
    agent, dhcp driver creates the network:dhcp port for the subnet.
    However, the port info is not updated in dhcp agents internal cache.
    Subsequently if the user deletes the network:dhcp port, the port is
    properly deleted on the server side (i.e., in the database) and when
    the port_delete_end notification is sent to the dhcp agent, it simply
    ignores it as the port entry would be missing in the cache. This patch
    fixes this issue by updating the dhcp agents cache when dhcp driver
    creates the network:dhcp port for the subnets.

Closes-Bug: #1478426
Change-Id: I69f5834dd964a4320c606c4e0aa2cdba70416943

commit cb60d0bb4e0cc0cba68f59fdf5f4e89d6ec52950
Author: changzhi <email address hidden>
Date: Thu Jul 16 10:14:16 2015 +0800

Keep dns nameserver order consistency

Currently, there is no dns servers prioritization for subnets
for Neutron.

    Generally speaking, it is useful to keep the order of dns
    nameservers consistent. Add a new column named 'order' in table
    'dnsnameservers' and add nameserver into DB one by one.

    Closes-Bug: #1218629
    Implements: blueprint keep-dns-nameserver-orderconsistency
    Change-Id: Id937aea411397d39370368a4eb45be26c4eefa9e

commit b39e1469e824bc8bc79e1ecafa98825a94811c0b
Author: Salvatore Orlando <email address hidden>
Date: Tue Jun 23 04:54:2...

Reviewed:  https://review.openstack.org/207903
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9badcd249dab2d3330f0cd608496b59c9f44499a
Submitter: Jenkins
Branch:    feature/pecan

commit 991ea00e6c115343eabecc62e86072175823f81f
Author: Moshe Levi <moshele@mellanox.com>
Date:   Thu Jul 30 12:04:15 2015 +0300

SR-IOV: Fix SR-IOV agent to run ip link commands as root
    
    Commit https://review.openstack.org/#/c/155523/
    remove the remaining root_helper args, but didn't
    update the SR-IOV agent to execute them as root.
    
    This patch updates the agent to execute ip link commands
    as root and pass options argument as a list in the
    self._as_root method.
    
    Closes-Bug: #1479694
    Change-Id: I53cafd61845a69fae3a759fb7526950d655ffa20

commit 5b3bacedf6c014815bef03c2e821b5eb8ef92dcb
Author: Saksham Varma <sakvarma@cisco.com>
Date:   Thu Jul 23 22:46:23 2015 -0700

Moved out cisco n1kv mech driver and db models
    
    Moving out Cisco N1Kv database models and the mech driver
    to the openstack/networking-cisco repo as part of the second
    phase vendor-core decomposition
    
    Partial-Bug: #1479123
    Partial-implements: blueprint core-vendor-decomposition
    
    Change-Id: I65a704b238d8cbe2951a6912fa4f1e8518c6f412

commit 65ac8cd0a80548e115b8ec1d4cfd47a94422fddf
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Wed Jul 29 20:44:01 2015 +0000

Updated from global requirements
    
    Change-Id: I3a884a73d51df0f93b5cc88b3e3250d81bb1f455

commit f0e8356d04d04600c072a1c0f0bdf274ff19ab8c
Author: sridhargaddam <sridhar.gaddam@enovance.com>
Date:   Mon Jul 27 03:46:48 2015 +0000

Update dhcp agent cache for network:dhcp ports
    
    When a network with a dhcp_enabled subnet is scheduled on a dhcp
    agent, dhcp driver creates the network:dhcp port for the subnet.
    However, the port info is not updated in dhcp agents internal cache.
    Subsequently if the user deletes the network:dhcp port, the port is
    properly deleted on the server side (i.e., in the database) and when
    the port_delete_end notification is sent to the dhcp agent, it simply
    ignores it as the port entry would be missing in the cache. This patch
    fixes this issue by updating the dhcp agents cache when dhcp driver
    creates the network:dhcp port for the subnets.
    
    Closes-Bug: #1478426
    Change-Id: I69f5834dd964a4320c606c4e0aa2cdba70416943

commit cb60d0bb4e0cc0cba68f59fdf5f4e89d6ec52950
Author: changzhi <changzhi@unitedstack.com>
Date:   Thu Jul 16 10:14:16 2015 +0800

Keep dns nameserver order consistency
    
    Currently, there is no dns servers prioritization for subnets
    for Neutron.
    
    Generally speaking, it is useful to keep the order of dns
    nameservers consistent. Add a new column named 'order' in table
    'dnsnameservers' and add nameserver into DB one by one.
    
    Closes-Bug: #1218629
    Implements: blueprint keep-dns-nameserver-orderconsistency
    Change-Id: Id937aea411397d39370368a4eb45be26c4eefa9e

commit b39e1469e824bc8bc79e1ecafa98825a94811c0b
Author: Salvatore Orlando <salv.orlando@gmail.com>
Date:   Tue Jun 23 04:54:28 2015 -0700

Add plural names for quota resources
    
    Introduce a 'plural_name' attribute in the BaseResource
    class in the neutron.quota.resource module. This will
    enable to specify the plural name of a resource when it's
    entered in the quota registry.
    
    This will come handy for managing reservations and also
    removes the need for passing the collection name when
    counting a resource.
    
    Also, the name of the 'resources' parameter for the
    _count_resource routine has ben changed to collection_name,
    as the previous one was misleading, since it led to believe
    it should be used for a collection, whereas it is simply
    the name of a collection.
    
    Change-Id: I0b61ba1856e9552cc14574be28fec6c77fb8783c
    Related-Blueprint: better-quotas

commit 3c584084c3c79489a7c81b323df5a15b44011e9f
Author: Salvatore Orlando <salv.orlando@gmail.com>
Date:   Thu Apr 16 11:56:27 2015 -0700

Introduce usage data tracking for Neutron
    
    This patch introduces application logic support for tracking
    Neutron resource usage data, thus introducing a different
    way of enforcing quota limits, which now relies on records
    tracking resource usage for each tenant.
    
    When these records go "out-of-sync" with actual resource usage,
    the quota usage table entry is marked "dirty".
    And it will be resynchronized the next time a resource count is
    requested. Changes in resource utilization are detected using
    SQLAlchemy events.
    
    This patch however does not automatically enable resource usage
    tracking for any plugin. Plugins must explicitly declare for which
    resources they wish to enable tracking. To this aim, this patch
    provides the @tracked_resources decorator.
    
    As some operators might wish to not use resource usage tracking, this
    patch adds the track_quota_usage configuration option. If set to
    False, DB-level usage tracking will not be performed, and
    resources will be counted as before, ie: invoking a plugin method.
    
    Usage tracking is performed using a new resource type,
    TrackedResource, which can work side by side with CountableResource,
    the one Neutron used so far. To this aim a ResourceRegistry class
    has been introduced for registering and managing resources. Most
    of the resource management code previously embedded in the
    QuotaEngine class is being moved to ResourceRegistry as a part of
    this patch.
    
    Partially implements blueprint better-quota
    
    Change-Id: If461399900973a38d7b82e0b3ac54fc052f09529

commit 1663f5c19756fee984f0aeea9befc3a823387c8e
Author: Salvatore Orlando <salv.orlando@gmail.com>
Date:   Tue Jun 2 16:13:35 2015 -0700

Create packages for quota modules
    
    This patch simply renames quota modules introducing two
    new packages:
    1) neutron.quota
    2) neutron.db.quota
    
    This paves the way for adding more quota related modules.
    Unit tests paths are changed accordingly, as well as references
    to moved modules.
    This patch hovewer preserves the ability of importing
    neutron.db.quota_db in order to avoid breaking repositories which
    use neutron as a requirement.
    
    Change-Id: I946e87f1b2ebb3e80d64aecfe58aeff9f81896f3
    Related-blueprint: better-quotas

commit 237fa342f9bb459e2c82301a810c8a4a87c38e79
Author: Cyril Roelandt <cyril@redhat.com>
Date:   Fri Jul 24 16:19:19 2015 +0200

Python 3: fix test_attributes
    
    In Python 3, strings have an __iter__ method, which makes convert_to_list fail.
    
    Change-Id: I2411ecd31d7d05ff6f0f004180edffc76d28573b
    Blueprint: neutron-python3

commit a8c50cc699385fa2c665fe6b36fc55ff9a9618e9
Author: Yushiro FURUKAWA <y.furukawa_2@jp.fujitsu.com>
Date:   Tue Jul 28 11:36:04 2015 +0900

Add FUJITSU vendor plugin in sub_projects
    
    Change-Id: Iee06e96d0887f7a973079194ec05b444c0874763

commit 1f76a9061db2fe096db3c4f15738549e284c9a61
Author: Cyril Roelandt <cyril@redhat.com>
Date:   Fri Jul 24 15:52:42 2015 +0200

Python 3: fix test_dhcp
    
    In Python 3, dhcp.LOG.process is not called when calling dhcp.LOG.debug. Since
    what we really want to know is whether dhcp.LOG.debug is called, tweak the test
    a little.
    
    Change-Id: I9c9d9a6162181d6e518a603193013c28e218cdee
    Blueprint: neutron-python3

commit 5874a36fb57d857671a5d32016b323d22867bb2c
Author: YAMAMOTO Takashi <yamamoto@midokura.com>
Date:   Fri Jul 3 23:59:46 2015 +0900

test_db_base_plugin_v2: Improve DBReferenceError generation
    
    The current coding, raising DBReferenceError directly, seems to
    confuse sqlalchemy a bit.  Instead, actually causes the error by
    tweaking the row being inserted.
    
    Change-Id: I17ec6dab19b0e573675559042b7529f7bdd2671b

commit d2650008b6029778f8bbc95457e2d5660dbb51ac
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Mon Jul 27 17:56:32 2015 +0000

Updated from global requirements
    
    Change-Id: Ib81ed61a31427abe8033081fadb39a3c3080fbd4

commit 619ac1c91aab0912aca325374c120b27fdef7579
Author: Cyril Roelandt <cyril@redhat.com>
Date:   Fri Jul 24 18:05:42 2015 +0200

Python 3: fix test_context
    
    In Python 3, b'...'.startswith must be given bytes.
    
    Change-Id: I4e83685ac6119db6f16d693df37955620271082f
    Blueprint: neutron-python3

commit 5df1a72c9517ebfc90998467e72c6d999119ee68
Author: Assaf Muller <amuller@redhat.com>
Date:   Sat Jul 25 16:14:32 2015 -0400

Fix KeyError: 'L3_ROUTER_NAT' in l3 scheduler functional test
    
    The issue was introduced by commit with change ID:
    Ic4df299bac83c80abf0890a81d2dd36d15993b33
    
    In Neutron-speak we define the 'core plugin' as something like ML2, while
    service plugins examples are L3, VPNaaS, etc. The code was initializing
    the L3 service plugin as the core plugin, which is unexpected behavior.
    The code will now use the DB core plugin base class as the core plugin,
    and not initialize the service plugins. The tests will manually and locally
    instantiate a L3 service plugin instance and use it.
    
    Change-Id: I2b7d2f6ccd5fe18e322e70b4e376db23d76b9092
    Closes-Bug: #1478273

commit 154ba235f8084a4c24c26c491eadcafe0fece436
Author: Pavel Bondar <pbondar@infoblox.com>
Date:   Mon Jul 27 16:00:56 2015 +0300

Cleanup IPAM tests
    
    Replace assert with self.assetTrue.
    Use self.assertIsInstance for comparing instance type.
    Pass arguments to assertEqual as (expected, observed).
    
    Change-Id: Ic0201276bdda7d99f9d1e25751eab8f9ebbb4a16

commit cc8a3792a88a0579f8621a87f643d6016c131874
Author: John Davidge <jodavidg@cisco.com>
Date:   Mon Jul 27 11:39:59 2015 +0100

Fix inconsistency of if/return logic in attributes.py
    
    In neutron/api/v2/attributes.py some methods use:
    
    if data is None:
        return
    return something
    
    Others use:
    
    if data is not None:
        return something
    
    Both have the same effect, but are inconsistent.
    
    This patch standardises the usage around the shorter version.
    
    Change-Id: Idc9e6eb1852d2565906fc2c8e8a7c0a63bc1a0dd
    Closes-Bug: 1478512

commit 287f60a13459d9c4a0bc1933b7a709dd502ac87f
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Mon Jul 27 06:07:28 2015 +0000

Imported Translations from Transifex
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: I6119ea9a2b1cb4ec1b0cc73f882d8f9d34fabe8d

commit 87fff61b06b1dfca7008e0482141d48329039f5a
Author: Ihar Hrachyshka <ihrachys@redhat.com>
Date:   Sat Jul 18 14:52:53 2015 +0200

[neutron-db-manage] revision: properly bootstrap a new branch
    
    If the intended branch is not present, bootstrap it:
    
    - create directory;
    - mark the new migration script with proper branch label;
    - make the script down_revision == None to indicate it's a new branch;
    
    One missing thing is making the script depends_on the previous release
    branch. This is currently unsupported by alembic though.
    
    Partially-Implements: blueprint online-schema-migrations
    Change-Id: Ib3b9dfcbdb56db99b07a8e54629dda5933e1c1f5

commit b3d4851f6370d9892a189c35d14b22dcbeb58200
Author: Salvatore Orlando <salv.orlando@gmail.com>
Date:   Tue May 19 09:49:26 2015 -0700

Add DB support for resource usage tracking
    
    This patch introduces database support for tracking Neutron
    resource usage data. A single DB model class tracks usage
    info for all neutron resources.
    
    The patch also provides a simple API for managing resource
    usage info, as well as unit tests providing coverage for
    this API.
    
    This patch also makes a slight change to the ContextBase
    class, adding the ability to explicitly set is_advsvc at
    initialization time. While this probably makes no difference
    for practical use of the context class, it simplifies
    development of DB-only unit tests.
    
    Related-Blueprint: better-quotas
    
    Change-Id: I62100551b89103a21555dcc45e84195c05e89800

commit e0ba53a09a70ab3cdd147093c0d83e6ef5a365e1
Author: Ivar Lazzaro <ivarlazzaro@gmail.com>
Date:   Thu Jun 18 16:02:11 2015 -0700

Decompose Apic ML2 mechanism driver
    
    As a part of the vendor decomposition effort, the
    apic ML2 driver code is removed and replaced by
    its version in the openstack/networking-cisco
    repo.
    
    Change-Id: Iffb5245b4c88b65afe62dd7435ee80489a654fee
    Partial-implements: blueprint core-vendor-decomposition

commit da3cfb1e88f84c73d2f0d6cf5f5fea2f849a90bf
Author: Assaf Muller <amuller@redhat.com>
Date:   Fri Jul 24 15:19:43 2015 -0400

Remove duplicate DHCP agent registration in unit test
    
    Looks like a copy/paste mistake.
    
    Change-Id: Ib8878e68f5348e03c9021ae3760b81f7cc73e68f

commit 257020a777c4b49910874214eebf18aee96c4ef4
Author: Cyril Roelandt <cyril@redhat.com>
Date:   Fri Jul 24 16:58:35 2015 +0200

Python 3: do not index dict_values objects
    
    Change-Id: I7260468b81d42415ac08ecda09973720b5b263a4
    Blueprint: neutron-python3

commit ced2e63cb8e287b9649edae7183b25a92097b3ed
Author: rossella <rsblendido@suse.com>
Date:   Wed Jan 14 15:11:36 2015 +0100

L2 agent RPC add new RPC calls
    
    This patch introduces two new RPC calls:
    * update_device_list
    * get_devices_details_list_and_failed_devices
    
    update_device_up and update_device_down are the RPC calls
    used by the L2 agent to notify the plugin that
    a device is up or down. These calls accept only one device.
    update_device_list accepts a list of devices that will
    be put up or down and returns a list of devices for which
    the operation failed.
    
    get_devices_details_list_and_failed_devices is a new RPC
    call that returns a list of devices details and a list of
    devices for which it was not possible to retrieve the
    details.
    
    Thanks to these new calls, the agent will be able to update
    the status of several devices using one RPC call
    and to retry the operation only for the devices that failed
    instead of performing a full resync.
    This will be implemented in another patch.
    
    This patch introduces the new calls only for the OVS agent.
    A following patch will take care of the other L2 agents.
    
    DocImpact
    Partially-Implements: blueprint restructure-l2-agent
    
    Change-Id: Idb4e81f4399cf66025ec7edfcb78801c15e493af

commit 28af36db595ff9e9c4d3befc94d1d68089c6f684
Author: Kyle Mestery <mestery@mestery.com>
Date:   Fri Jul 24 14:07:26 2015 +0000

Add Cathy Zhang as networking-sfc Lieutenant
    
    Change-Id: Ie20bccf4b328ba6c83224c665c0e1a3034697384
    Signed-off-by: Kyle Mestery <mestery@mestery.com>

commit e004e1ad9da5df6e7ce0daac1c2de7e5a94db1ee
Author: Sergey Belous <sbelous@mirantis.com>
Date:   Fri Jul 24 13:41:35 2015 +0300

Add error message when migrate from distributed router to centralized
    
    When trying to migrate from distributed router to centralized
    a NotImplementedError occurs with empty message.
    Need to concretize a message.
    
    Closes-Bug: #1477509
    Change-Id: I2b57ec5af38a0f87c1ab256cb8af66bc443be824

commit 38ed9ba08e7cc3c8d650bd15cd986159a3c45a46
Author: Salvatore Orlando <salv.orlando@gmail.com>
Date:   Fri Jul 24 05:21:43 2015 -0700

Avoid printing log options multiple times
    
    This patch ensures log_opt_values is invoked only once, thus
    avoiding annoying multiple dumps of options values.
    
    Note that is rpc_workers is greater than 0 a second dump will
    be logged. This patch does not address this as REST and RPC
    servers are going to be separated as a part of the feature/pecan
    work.
    
    Closes-Bug: #1477975
    
    Change-Id: Ia5dcb609241de6ad30d9831c5fb98a9e2be6ad7f

commit 2921f6dfa276cc6fbcab595b1273090039a00dd3
Author: Pavel Bondar <pbondar@infoblox.com>
Date:   Thu May 14 14:06:08 2015 +0300

Add Pluggable IPAM Backend Part 2
    
    Introduces new Pluggable IPAM backend.
    IP/subnet allocation calls are sent to IPAM driver.
    Calls to IPAM Driver are considered as call to third-party
    environment, so if any action fails, rollback action is called.
    
    Removes associate_neutron_subnet step from interface and reference
    driver. It is not needed any more because foreign key relationship
    between IPAM subnet and neutron subnet was removed.
    So IPAM subnet can store id of neutron subnet,
    which is not created yet.
    
    For now only reference IPAM driver is available.
    
    Temporarily disabled test_ipam_pluggable_backend from
    gate-neutron-python34. Current patch adds executing
    parts of test_db_base_plugin_v2, which is not py34 compatible yet.
    Might be enabled back once 204791 is merged.
    
    Partially-Implements: blueprint neutron-ipam
    
    Change-Id: Ic18461cf19d2eebf8fad5535eee0eb034959800e

commit 7033960d34c1987c71ac6c7466711846dfcc5763
Author: Cyril Roelandt <cyril@redhat.com>
Date:   Thu Jul 23 09:23:21 2015 +0000

Python 3: fix neutron.tests.unit.agent.dhcp.test_agent
    
    A simple "list vs dict_keys" issue was preventing two tests from succeeding.
    
    Change-Id: I9386ddc600005ebb1b3f5382f6e43c19d31d4213
    Blueprint: neutron-python3

commit 94a070c78edc3ec7b73973478d47a665534603f7
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Thu Jul 23 12:50:58 2015 +0000

Updated from global requirements
    
    Change-Id: I36e87e41ba3a99b43bc57e9c9586ec9494db62d7

commit 6ff8582896646f1e88d1a754cd476147e02c1834
Author: Hirofumi Ichihara <ichihara.hirofumi@lab.ntt.co.jp>
Date:   Fri Jul 17 14:32:21 2015 +0900

Metaplugin removal
    
    Metaplugin is removed in Liberty.
    Remove all metaplugin related codes.
    
    DocImpact
    APIImpact
    
    Co-Authored-By: Itsuro Oda <oda@valinux.co.jp>
    Change-Id: I9cf36e1fd3a009c175e0d475af407a30f4e5c408
    Closes-Bug: #1465126

commit 4f89d9be7317ee5c82716306420e1d5efbcb7b31
Author: shihanzhang <shihanzhang@huawei.com>
Date:   Tue Jul 14 19:20:46 2015 +0800

Fix handling of port-range-min 0 in secgroup RPC and agent
    
    For TCP/UDP protocol, port valid range is 0 to 65535, so for a
    security group rule, its valid range is also 0 to 65535. this
    patch makes two changes:
    1. if a security group rule port_range_min is 0, l2 agent also can
       get port_range_min real value 0 when it gets this rule for a
       device via RPC.
    2. For IptablesFirewallDriver, if port range is [0, xxxx], l2 agent
       also need add this rule to iptables.
    
    Change-Id: If93c54a31d973187889ead2c2797ffdd40a4393d
    Closes-bug: #1473965

commit b70bf5c1fed674b1121fe0bf336c17a67f8d2057
Author: Bertrand Lallau <bertrand.lallau@thalesgroup.com>
Date:   Mon Jul 20 15:12:49 2015 +0200

Fix a property comment in metadata_agent files
    
    Metadata Proxy UNIX domain socket mode allows 4 values not 3.
    
    Change-Id: I83787856acda48608e1f0997329a92876afed613

commit de9a50cdeaf594bfc0da75c3e6ed01ed33bb6ccc
Author: Numan Siddique <nusiddiq@redhat.com>
Date:   Tue Jul 7 00:19:03 2015 +0530

Add address scope API tests
    
    This patch adds the address scope api tests and
    also returns the address scope resource attr map
    in the get_extended_resources() function which was
    missed in the previous patch
    
    Co-Authored-By: vikram.choudhary <vikram.choudhary@huawei.com>
    Co-Authored-By: Ryan Tidwell <rktidwell85@gmail.com>
    Change-Id: I819f08dfb78346f92ba73e11daa7294518e7452a
    Partially-implements:  blueprint address-scopes

commit 3e168be46afe3293825649d5451c504e5d777ee5
Author: Cyril Roelandt <cyril@redhat.com>
Date:   Wed Jul 22 11:03:58 2015 +0000

Python 3: enable more tests
    
    Now that Routes 2.2 has been released, we can run some tests that were
    previously commented out.
    
    Change-Id: I46d8479ae4f29dc8b26143e7a49f88ff35198e9d
    Blueprint: neutron-python3

commit b4e42a341894177a1c870a48b2641bae6c36696e
Author: Yalei Wang <yalei.wang@intel.com>
Date:   Tue Jun 9 13:46:57 2015 +0800

Add new ovs DB API to inquire interfaces name list in a bridge
    
    In OVS, ports don't equal to interfaces when a bond port created. This patch
    add the new API get_iface_name_list to get the interfaces' name, and it's
    supplementary to the current get_port_name_list API.
    
    Change-Id: I29c220e099b8dcf78248e2d660c435578bb2932d
    Partial-Bug: #1460494

commit 1c439f3d071fb2072445d011890d1773503b153b
Author: armando-migliaccio <armamig@gmail.com>
Date:   Tue Jul 21 16:08:41 2015 -0700

Tweak wording for project inclusion process
    
    There may be projects that have not being created yet, so revise
    the wording a bit to provide clarity that new projects can also
    submit for inclusion right off the bat.
    
    Change-Id: I862dc3d1835472066c23c3df8e049ae17bf47c2b

commit 25baeccac9c6a5d15d51c81d06e033ce0d516730
Author: Cedric Brandily <zzelle@gmail.com>
Date:   Thu Jun 18 12:19:21 2015 +0000

Define fullstack router/network/subnet management fixture
    
    This change defines the generic fixture ClientFixture for managing
    neutron resources:
    
    * router create/cleanup
    * network create/cleanup
    * subnet create/cleanup
    * router interface add/cleanup
    
    And uses it in neutron.test.fullstack.test_l3_agent.
    
    Change-Id: I09fe40d65db60aeee1ff57a7e45c1978a5433517

commit 27503dad33bb045ac840f13a3e5fc0a5b603abb1
Author: sridhargaddam <sridhar.gaddam@enovance.com>
Date:   Fri Jun 19 16:17:01 2015 +0000

Fix race condition by using lock on enable_radvd
    
    For an HA Router, radvd is spawned only in the Master Node.
    KeepalivedStateChangeHandler after receiving the state notification
    on the unix domain socket, would either enable/disable the radvd
    process depending on the state of the HA Router. In parallel, if
    there is a request to add an interface to the router, router.process()
    would try to enable radvd in parallel. So there is a possible race
    condition as two threads try to enable radvd in parallel. This patch
    uses appropriate locking mechanism to prevent this race condition.
    
    Closes-Bug: #1466663
    Change-Id: I40df78cc57fcde5512336d9dfef88b3b06a69bcb

commit 4c41552e505e8d4eb8cf0202efe2b46eb23071eb
Author: Wei Wang <wangwei@unitedstack.com>
Date:   Mon Jul 20 22:55:31 2015 +0800

Fix note in devref/contribute.rst
    
    Now note in devref/contribute.rst is formated as a section,
    so it will appear at catalog which is pretty ugly.
    
    This fix uses note admonition to replace it and specifies Mitaka
    as the release name instead of Mxxx.
    
    Change-Id: Ic4afb086e7d4eace035ebe74d1244eabe1ff8915

commit f53a43fd5e0fe80d08d4bd5f89dc4fb1e96094a9
Author: Ihar Hrachyshka <ihrachys@redhat.com>
Date:   Sat Jul 18 14:52:53 2015 +0200

ensure_dir: move under neutron.common.utils
    
    There is nothing Linux or agent specific in the function. I need to use
    it outside agent code in one of depending patches, hence moving it into
    better location while leaving the previous symbol in place, with
    deprecation warning, for backwards compatibility.
    
    Change-Id: I252356a72f3c742e57c1b6127275030f0994a221

commit d6e36b4e2f5074c47c71bf32ba6762d573d5161b
Author: Henry Gessau <gessau@cisco.com>
Date:   Thu Jun 25 13:58:30 2015 -0400

Remove deprecated OVS and LB plugin DB tables
    
    Now that the openvswitch and linuxbridge monolithic plugins have been
    deprecated and replaced by ML2 mechanism drivers, we can remove their
    database tables.
    
    Also remove the migrate_to_ml2.py script which is no longer supported.
    
    Change-Id: Ia8d77cb7e4e4b3d4957365cc124ac71a59e62745
    Partially-Implements: blueprint reference-implementation-split
    Closes-Bug: #1468433

commit 73207ddd5e8b4be800b2d1603d73cabad30423ec
Author: YAMAMOTO Takashi <yamamoto@midokura.com>
Date:   Thu Jul 16 19:56:21 2015 +0900

ovs_lib: Fix native implementation of db_list
    
    Move the code to list records into the transaction.
    
    Closes-Bug: #1473038
    Closes-Bug: #1473049
    Closes-Bug: #1475253
    Change-Id: I9f367f5ba1ecc50b9bb94c6f52507033d0139611

commit 3f8594bbf6dec651233f50eb032af33064c117be
Author: fumihiko kakuma <kakuma@valinux.co.jp>
Date:   Mon Jul 13 14:53:42 2015 +0900

Stop use of oslo_utils.timeutils.strtime()
    
    oslo_utils.timeutils.strtime() is deprecated in version '1.6'.
    We use datetime.datetime.isoformat() or datetime.datetime.strftime()
    instead.
    
    Change-Id: Id6e8645362fe70b1427d45d5b44048fe47aba0f7
    Closes-Bug: #1475156

commit a45e04e1e1e965e3d5729212980d3c609d62a31a
Author: Louis Taylor <louis@kragniz.eu>
Date:   Mon Jul 20 17:20:29 2015 +0000

Port help text for dvr_base_mac from neutron.conf
    
    The help text for the option in the current static configuration file
    contained additional information which would be lost when we switch to
    generating the file. This patch copies it over to the oslo.config help
    parameter.
    
    Related-blueprint: autogen-neutron-conf-file
    
    Change-Id: Id03925b4bbbee697bf5372392c2345802a1863f8

commit 97be4b8697fea6212b64b5a0a57c5a462b7cc591
Author: Irena Berezovsky <irenab.dev@gmail.com>
Date:   Thu Jul 16 13:42:10 2015 +0000

Add documentation for SRIOV NIC agent (previously missing)
    
    Co-Authored-By: Moshe Levi <moshele@mellanox.com>
    
    Change-Id: I86abeb42d01b0541a4537b774833a104c6732310

commit 6226fb73a42a5d5f904d5a7fc5b467c72ddf5115
Author: Cyril Roelandt <cyril@redhat.com>
Date:   Mon Jul 20 14:41:39 2015 +0000

Python 3: fix neutron.tests.unit.agent.linux.test_async_process
    
    In Python 3, one cannot compare an integer to None.
    
    Change-Id: I8de3ea3752be837540ea65f1bb254a095927de44
    Blueprint: neutron-python3

commit 141560b4221b9b58fd34405a8f94e826f92f35ff
Author: nmagnezi <nmagnezi@redhat.com>
Date:   Mon Jul 13 16:23:28 2015 +0300

Adds garp_master_repeat and garp_master_refresh to keepalived.conf
    
    This patch aims to solve an issue when, in some cases, the L3 agent might
    start before the OVS agent during a node boot process.
    At such scenario, the L3 agent will configure the routers before the OVS agent
    done syncing with the server and starts processing ovsdb monitor updates.
    
    The result:
    1. L3 agent finishes configuring an HA router
    2. Keepalived spawned
    3. In case of transition to master state, it (keepalived) sends gratuitous ARPs
                                                                ^---The issue
    4. The OVS agent has just finished plugging its ports
    
    Meaning, the gratuitous ARP will be lost, but the router acting as master.
    Closes-Bug: #1453855
    
    Change-Id: I2cffa7c0ebad20bd50396265aef9fcfa64018744

commit 0a8369cc6944d3886d05f8f7734c6d5dfdf3aa6e
Author: Ritesh Anand <ritesh.anand@hp.com>
Date:   Fri Apr 24 12:29:22 2015 -0700

Added functional tests for L3 schedulers.
    
    Legacy mode agents considered.
    
    Following test cases are added:
    Common scenarios:
    1. No routers scheduled if no agents are present
    2. No routers scheduled if it is already hosted
    3. No routers scheduled if all agents are down
    4. Router scheduled to the agent if router is not yet hosted
    5. Router scheduled to the agent even if it already hosts a router
    
    Following scenario specific to least routers scheduler is added:
    1. Router is scheduled to agent hosting least routers
    
    For each of Chance and Least Router schedulers auto scheduling is also verified.
    
    A total of 22 test cases are added.
    
    Change-Id: Ic4df299bac83c80abf0890a81d2dd36d15993b33

commit 59a61c351d853f465775e0f5fa3cc904a6f37c3d
Author: Cedric Brandily <zzelle@gmail.com>
Date:   Fri May 8 23:28:37 2015 +0200

Always use BridgeDevice to manage linuxbridges
    
    BridgeDevice[1] class provides methods to manage linuxbridges through
    brctl. This change adds some methods to BridgeDevice in order to
    always use BridgeDevice to manage linuxbridges and respect DRY
    principle.
    
    [1] neutron.agent.linux.bridge_lib
    
    Change-Id: I4b9d755677bba0d487a261004d9ba9b11116101f

commit 91f86101e483e931bf1eefa020ee85a6093d81a3
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Sat Jul 18 16:06:06 2015 +0000

Updated from global requirements
    
    Change-Id: I1385cfc5d8838fbb73ba5c909537d072cba8d736

commit ce437729f9ac552939c5473c8c8fee52d214c8db
Author: Gary Kotton <gkotton@vmware.com>
Date:   Sat Jul 18 00:33:10 2015 -0700

Validate that context exists
    
    Commit 3e0328b992d8a90213a56ec5a4144677279bea66 broke external
    decomposed plugins due to the fact that it assumes that the
    context is set.
    
    This patch validates that the context is set.
    
    Co-Authored-By: Kevin Benton <blak111@gmail.com>
    
    Change-Id: I3320f27be7b0fed1d3b37a5c5459d91b2bc4f13b
    Closes-bug: #1475837

commit 04f71b22e7a52c6dd01d498bdbed286007a65aa3
Author: Ihar Hrachyshka <ihrachys@redhat.com>
Date:   Sat Jul 18 00:48:30 2015 +0200

neutron-db-manage: fix check_migration for branch-less migration directories
    
    I3823900bc5aaf7757c37edb804027cf4d9c757ab introduced support for
    multi-branch migration directories in neutron-db-manage. That broke
    check_migration for those projects without multiple branches.
    
    The tool should properly handle both types of directories for forseable
    future.
    
    Related-Bug: #1475804
    Change-Id: Ie4d20f5119018ffdebe2929b961c5ddb314ed734

commit aa4fa7b8195103fd1569672c9a71e33093be2e6a
Author: Carl Baldwin <carl.baldwin@hp.com>
Date:   Tue Jul 14 19:00:45 2015 +0000

Use only the lower 16 bits of iptables mark for marking
    
    Since a packet can only have one mark, and we will need to mark a
    packet for multiple purposes, we need to use a coordinated bitmask for
    the two cases of simple marking that we currently do in Neutron
    leaving the other bits for address scopes.
    
    DocImpact
    
    Change-Id: Id0517758d06e036a36dc8b8772e41af55d986b4e
    Partially-Implements: blueprint address-scopes

commit 5ed1c9115d97cb6e442c4c86ea5b5ac0ffbc19bb
Author: Cyril Roelandt <cyril@redhat.com>
Date:   Fri Jul 17 17:27:36 2015 +0000

Python 3: fix test_provider_configuration
    
    We cannot compare a dict_keys/dict_values object with a list.
    
    Change-Id: I6dbbe5eb4e98ccfc41109a5d93a22cda910774ee
    Blueprint: neutron-python3

commit 98771c19b6fe8c26aff05ea324e4db928cc747f9
Author: Mike Bayer <mike_mp@zzzcomputing.com>
Date:   Fri Jul 17 13:19:57 2015 -0400

Add address_scope_db to neutron/models/head.py
    
    The head.py file ensures that all relevant models are
    imported when ModelsMigrationSync tests are run in
    neutron/tests/functional/db/test_migrations.   This is
    one of the models that needs to be present else the
    "address_scopes" table comes out as missing.   The
    error is usually concealed by the fact that the module
    was imported as a side effect of other tests but
    is revealed if one runs test_migrations.py alone.
    
    Change-Id: I954d8385c479de663ef1a5ef439866d2d927bcf3

commit d82a2f75acda916389376e3566217827b218cff5
Author: rossella <rsblendido@suse.com>
Date:   Sun Jul 5 23:58:25 2015 +0200

OVS agent factor our port stats processing
    
    Move the port stats processing from the rpc loop to a new method
    get_port_stats
    
    Change-Id: I4a927f5c11328d854fbb5f76d560bbd9425651ea

commit 9976048b6044a266231621daf1a4e90199df75b8
Author: Cyril Roelandt <cyril@redhat.com>
Date:   Thu Jul 16 21:12:58 2015 +0000

Python3: Do not compare NoneType and integers
    
    In Python 2:
    >>> None > 0
    False
    
    In Python 3:
    >>> None > 0
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
    TypeError: unorderable types: NoneType() > int()
    
    This commit does not change the behaviour of the affected code, but fixes the
    TypeError that is raised in Python 3.
    
    Some tests have been added to the py34 section of tox.ini, but are currently
    commented out: these are tests that work with this patch and a fixed version of
    Routes.
    
    Change-Id: Ia00a2ad90206853f78ed93cf540bce54baab00e7
    Blueprint: neutron-python3

commit 1b3c7c6ee07fd79bee3b54ea0d4ca0a53bf0d9b7
Author: Cedric Brandily <zzelle@gmail.com>
Date:   Wed Jul 15 23:39:49 2015 +0200

Use oslo_log.helpers.log_method_call
    
    log[1] decorator is deprecated, this change replaces it with oslo_log
    log_method_call[2].
    
    [1] neutron.common.log
    [2] oslo_log.helpers.log_method_call
    
    Change-Id: I61cf3c010e1f33a45ff700f4e8d4824ebdb378c7

commit 9d800021293d8564ced1c071b6415d9a97b3ef49
Author: shihanzhang <shihanzhang@huawei.com>
Date:   Tue Jun 30 10:14:19 2015 +0800

Unplug the VIF if dhcp port is deleted
    
    if user delete the dhcp port, dhcp-agent should unplug
    the VIF for this dhcp port, then the driver do
    'reload_allocations' will raise a exception, dhcp-agent
    resync for this network and re-create dhcp port.
    
    Change-Id: I40b85033d075562c43ce4d0e68296211b3241197
    Closes-bug: #1469615

commit 24521055df02bb2bdb0e0d984a5c101a9c0bad64
Author: fumihiko kakuma <kakuma@valinux.co.jp>
Date:   Thu Jul 16 19:34:12 2015 +0900

Python 3: Wrap map() in a list call
    
    map() returns an iterator in python 3. In a case that a list is expected,
    we wrap map() in a list call.
    
    Change-Id: I623d854c410176c8ec43b732dc8f4e087dadefd9
    Blueprint: neutron-python3

commit eb9226214fbf3d7a1812ca454c7c304769e262dc
Author: Gal Sagie <gal.sagie@huawei.com>
Date:   Mon Jul 6 16:22:39 2015 +0300

Devref documentation for client command extension support
    
    Change-Id: I51d5c26467b0e10e215838a02e6be81b6bc07ea9
    Closes-Bug: #1470622
    Depends-On: If71c9e2bbf888b1a68d3b7dc351f7df02f1a380f

commit c5cb76315f0af0ab03185575bec91210f61c13e5
Author: Kevin Benton <blak111@gmail.com>
Date:   Thu Jul 16 18:45:30 2015 -0700

Alter unit test to match bug and cleanup ext logic
    
    The unit test for bug #1443342 was only testing that a side effect
    leading to the bug didn't occur (comparing object identities). This
    patch updates the unit test to fully assert that the bug itself
    doesn't occur without checking implementation details.
    
    This also eliminates the branching that led to the original issue by
    using setdefault to always return a dict to update.
    
    Related-Bug: #1443342
    Change-Id: I6c48681aa49c17bbadffa12bad1eea272c483437

commit 2c98f6ee17f0fc589d327cc78487fe708779f964
Author: Sam Morrison <sorrison@gmail.com>
Date:   Thu Jun 18 11:13:33 2015 +1000

Allow overriding of the neutron endpoint URL in metadata agent
    
    Allow operators to set the endpoint url for neutron in the config
    overriding the url that comes from the keystone catalog.
    
    Change-Id: I93f81ef1be2de1038d9a899b0c4becdb5a8e8775
    DocImpact
    Closes-Bug: #1466258

commit 4570c1cd4928a0fb5c9203fb669dedac465a6623
Author: Carl Baldwin <carl.baldwin@hp.com>
Date:   Thu Jul 2 21:43:25 2015 +0000

Allow passing table argument to construct IpRouteCommand
    
    The various methods of IpRouteCommand also work with a non-default
    table.  Instead of passing an explicit table argument to each command,
    this change allows constructing an instance of IpRouteCommand which
    always works on the given table much like we pass the namespace on
    creation instead of passing it to each command individually.
    
    Change-Id: I503aa986208347ccc1cb5f37bdb36f77553eee70
    Partially-Implements: blueprint address-scopes

commit 704c79cd8994f6dd3d18e38c079ec676921455c2
Author: Carl Baldwin <carl.baldwin@hp.com>
Date:   Mon Jul 13 18:44:38 2015 +0000

Make external_gateway_nat_rules easier to understand
    
    Future patches will change these snat rules for address scopes.  I
    found it much easier to understand the changes needed after formatting
    these like this.
    
    Change-Id: I8356e438334f8c1b6fdb497650a3b63835c612cf
    Partially-Implements: blueprint address-scopes

commit d5ebd36a37d65475bf52bbeeda995cc8fabae629
Author: Carl Baldwin <carl.baldwin@hp.com>
Date:   Thu Jul 9 19:19:00 2015 +0000

Remove perform_snat_action indirection
    
    This indirection seems complicated to me.  I don't know the history
    behind it but it made some of the address scope work more difficult
    than I think it needs to be.
    
    Change-Id: I1e716135b542c09ec852f6ab7af5153a65803ba3
    Partially-Implements: blueprint address-scopes

commit e0eed14a1e8e63a8b6bbcc6f6a474036c1ef52f9
Author: Eugene Nikanorov <enikanorov@mirantis.com>
Date:   Thu Jul 17 14:23:49 2014 +0400

Flavor Framework implementation
    
    This patch introduces API and DB plugin for flavor framework.
    API adds Flavors and Service Profiles which are resources
    available only for admins to operate.
    
    This framework then should be leveraged by advanced services.
    
    Included tempest API tests in neutron tree
    
    Implements: blueprint neutron-flavor-framework
    Change-Id: I99ba0ce520ae3d8696eca5c994777c7d5ba3d4b1
    Co-Authored-By: Doug Wiegley <dougw@a10networks.com>
    Co-Authored-By: Madhusudhan Kandadai <madhusudhan.kandadai@hp.com>

commit 5f249bd465a5cb7fc9d407dce27ac280cf375431
Author: Yusuke Ide <idzzyzzbi@gmail.com>
Date:   Sat Jul 4 15:38:58 2015 +0900

Add breakages in public API of devref
    
    In wiki it is intended to keep track of neutron changes that may affect
    external plugins and drivers. The information should be kept in a living
    document in the devref area of the neutron code tree.
    
    Change-Id: Ic73ffd02fbaea48fcb6ad29dd5c9e91870064cb1
    Closes-Bug: #1470598

commit 3e0328b992d8a90213a56ec5a4144677279bea66
Author: Kevin Benton <blak111@gmail.com>
Date:   Mon Jun 15 02:18:36 2015 -0700

Network RBAC DB setup and legacy migration
    
    This patch implements the database model required for the network
    RBAC work. In addition it migrates the current network and subnet
    'shared' attributes to leverage the new table.
    
    'shared' is no longer a property of the DB model because its status
    is based on the tenant ID of the API caller. From an API perspective
    this is the same (tenants will see networks as 'shared=True' if the
    network is shared with them). However, internal callers (e.g. plugins,
    drivers, services) will not be able to check for the 'shared' attribute
    on network and subnet db objects any more.
    
    This patch just achieves parity with the current shared behavior so it
    doesn't add the ability to manipulate the RBAC entries directly. The
    RBAC API is in the following patch.
    
    Partially-Implements: blueprint rbac-networks
    Change-Id: I3426b13eede8bfa29729cf3efea3419fb91175c4

commit f52866f5a847a4740bbc1a324334c3a16a54769c
Author: Ihar Hrachyshka <ihrachys@redhat.com>
Date:   Thu Jul 16 14:37:37 2015 +0200

[devref] db_layer: expand on how new migration scripts look like
    
    Most of the text is stolen from the corresponding spec:
    
    Ib27c6eb8c901536f1f30d0911dedd4db13d76e9f
    
    Co-Authored-By: Mike Bayer <mike_mp@zzzcomputing.com>
    Change-Id: Ib10c13f841f7cebb90c57f4b0d08fc2c3701da97

commit d04335c448aa15cf9e1902e22ed4cd17b6ed344b
Author: Kevin Benton <blak111@gmail.com>
Date:   Thu Jul 16 02:07:48 2015 -0700

Add oslo db retry decorator to non-CRUD actions
    
    The previously added decorators to the create and update handlers
    in the API layer only applied to actions that followed the standard
    create/update path. However, for API operations like add_router_interface,
    a different path is followed that wasn't covered by a retry decorator.
    
    This patch adds the decorator to handle deadlocks in those operations as
    well.
    
    Closes-Bug: #1475218
    Change-Id: Ib354074e6a3f68cedb95fd774f905d94ca16a830

commit 4acf32026023cbd85295d8c8021b1b305a55435a
Author: Jakub Libosvar <libosvar@redhat.com>
Date:   Thu Jul 16 10:45:22 2015 +0200

Change prefix for namespace fixture
    
    With fullstack in game namespace fixtures are not used only in
    functional tests. This patch changes prefix to be "test-" instead of
    "func-" to describe better its purpose.
    
    Change-Id: Ie9a22f51dbd45247550d7cd538339ba199d93c26

commit b5127bf50f95780ee5444c3a359ffea4884c1287
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Thu Jul 16 06:09:56 2015 +0000

Imported Translations from Transifex
    
    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure
    
    Change-Id: If95ecf8eb6a7e4b01340b3bb735f62aedf4e518f

commit e155ace68badd746fd51aedb124e1d36ae0efaea
Author: YAMAMOTO Takashi <yamamoto@midokura.com>
Date:   Thu Jul 16 14:21:10 2015 +0900

OVS-agent: Fix a docstring typo
    
    Change-Id: Ib917d8c77060acaec491c459eb3c0a434f7610af

commit e2fb74e1964a2f9cb1777c8f8a34a70f1b733be0
Author: Cyril Roelandt <cyril@redhat.com>
Date:   Wed Jul 15 11:54:51 2015 +0000

Python 3: do not use types.ClassType
    
    In Python 3, one should just use 'type'. Still, the use of "ClassType" does not
    seem necessary here, so just fix the tests.
    
    Change-Id: I5574926fc338110cc989bf185fa454ec26f4d530
    Blueprint: neutron-python3

commit 701b119d9ce880940b85f9143e97e05c1c2378a0
Author: Carl Baldwin <carl.baldwin@hp.com>
Date:   Thu Jul 9 22:05:05 2015 +0000

Create dvr base class and stop passing around snat_ports
    
    The one thing that I see that the two dvr classes have in common is
    the ability to map internal ports to snat ports.  The dvr local router
    needs it to set up a redirect to the central part.  The central part
    needs it to create the port for the internal network.
    
    This change renames the mapping method to something more logical and
    removes snat_ports as an argument to two methods because it is a quick
    O(1) operation to get it from the router dict and passing it around
    just tangles things up.
    
    Change-Id: Icc099c1a97e3e68eeaf4690bc83167ba30d8099a

commit bafde2e41b64262c9821c983a6e50bba7ca780f3
Author: Neil Jerram <Neil.Jerram@metaswitch.com>
Date:   Wed Jul 15 12:19:23 2015 +0100

Correct two spelling mistakes in Neutron devrefs
    
    Change-Id: Ia15c82363972845c70e773d85aa3be3beb2e0eb5

commit 56c3c8b38210662a047cd385094b40aac5f15f36
Author: Cedric Brandily <zzelle@gmail.com>
Date:   Tue Jul 7 12:23:12 2015 +0000

Improve check_migration command error message
    
    This change adds some details (expected heads) to the error raised by
    neutron-db-manage check_migration command in order to help debugging.
    
    Change-Id: Icfc6fc5722b5a3b7c4a36131553eeba0941d12e3

commit bc38335d5899b0a8bf195e30e264ff01f166ec7f
Author: shihanzhang <shihanzhang@huawei.com>
Date:   Tue Jul 14 17:32:48 2015 +0800

Avoid using logging in signal handler
    
    In some cases, logging can grab locks and thusly attempt to reschedule,
    which will fail in signal handlers. this patch removes the actions
    from the signal handers, just set a flat if it got a signal, then in
    rpc_loop, check the flag and perform appropriate actions.
    
    Change-Id: I7a477e1c95b63fa8070ec9d08656156571421bb6
    Partial-Bug: #1029727

commit d0820e716f5e86602477bfc2269ecc7af8b4f305
Author: Cedric Brandily <zzelle@gmail.com>
Date:   Tue Jun 16 09:42:35 2015 +0200

Galera multi-writers compliant sync_allocations
    
    Currently sync_allocations[1] uses with_lockmode('update) which implies
    possible deadlocks with Galera multi-writers. This change decorates the
    method in order to catch and retry sync_allocations.
    
    [1] neutron.plugins.ml2.drivers.type_tunnel
    
    Change-Id: Ic01614cb5daf174848cf14a6aa4b38c4ed40fe1e

commit 07681411df1efaf3d0f0cb2a4436d519ad95f2cb
Author: Aviram Bar-Haim <aviramb@mellanox.com>
Date:   Wed Jul 15 10:41:12 2015 +0300

Fix SR-IOV mechanism driver tests directory
    
    This patch adds mising __init__ to mech_sriov/mech_driver/ tests directory.
    
    Trivial Fix
    
    Change-Id: Ie048eaeed6cfa923e09c4260a56f654a74307715

commit 38c85a88549adf60628a575402189272fa3e0cc1
Author: Sergey Vilgelm <sergey@vilgelm.info>
Date:   Wed Jul 8 15:51:14 2015 +0300

Switch to the oslo_utils.fileutils
    
    fileutils is graduated in the oslo.utils library.
    
    Implements: blueprint graduate-fileutils[1]
    [1] https://blueprints.launchpad.net/oslo-incubator/+spec/graduate-fileutils
    
    Depends-On: I51ba9076e1fbc16145ee2311f47b7768c16dcb20 (requirements)
    
    Change-Id: I933d02aa48260069149d16caed02b020296b943a

commit fa690cfc90a84e8e948621a94557dcf6f09f2678
Author: YAMAMOTO Takashi <yamamoto@midokura.com>
Date:   Wed Jul 15 12:48:38 2015 +0900

Fix a regression in a recent IPAM change
    
    The change I81806a43ecc6f0a7b293ce3e70d09d1e266b9f02
    effectively removed _delete_port from NeutronDbPluginV2.
    Unfortunately, it's still used directly by l3_dvr_db.
    
    Closes-Bug: #1474639
    Change-Id: I6ffb1d2d6f072ac1669637943eacad182244ca5c

commit 9eed4167b63f0c0ad6c7ceeedc644e511c8dac75
Author: Swaminathan Vasudevan <swaminathan.vasudevan@hp.com>
Date:   Mon Jun 29 16:19:49 2015 -0700

Fix update_port_postcommit and port not found with DVR
    
    Updating DVR Router interface ports was throwing
    errors in the l2pop mechanism drivers function
    update_port_postcommit.
    
    PortContext's portbinding information does not show
    the status of the ports. For DVR Router interface
    ports the DVRPortbinding table contains the status
    information for the ports.
    
    In the case of the update_port method, there was
    no code related to DVR that retreives the port
    binding information from the DVRPortBinding table.
    
    This was working before, since in the driver_context,
    the PortContext was just returning the port status for
    all router interfaces.
    
    With the recent refactor to the driver_context, this
    behavior changed and the PortContext was returning the
    _binding.status for the DVR router interface ports and
    the _port.status for the non DVR ports.
    
    When the update_port function calls update_port_postcommit
    with PortContext for DVR router interface ports, l2pop
    was throwing an error saying that Portbinding does not
    have the attribute 'status'.
    
    This was causing addition of any second subnet to the
    same network with respect to IPv6 to fail.
    Because in the case of IPv6, when you add additional
    subnets to the existing network, it just updates the port
    with the IPv6 prefix instead of creating additional port.
    
    In the case of IPv4 still we could see that there are
    two different ports created for each subnet we try to
    add.
    
    This patch fixes the above issue in l2pop and allows the
    DVR router interface ports to be successfull.
    
    Also the _find_ipv6_router_port_by_network was returning
    all the ports for DVR including the DVR CSNAT internal
    ports which are not part of the router interface ports.
    
    This patch also fixes this problem by returning false,
    when it finds a DVR SNAT port.
    
    Closes-Bug: #1465434
    
    Change-Id: Id243a4b3f30071226411ace6d12550fc099901cc

commit 5d07ec908cd7bee1c332ee3be6aee17e8386b9ea
Author: Ihar Hrachyshka <ihrachys@redhat.com>
Date:   Mon Jul 13 11:49:42 2015 +0200

Tighten exception handler for import_object
    
    oslo_utils raise ImportError if import fails. We should propagate other
    failures to callers. Otherwise we may hide issues.
    
    Also report exact failure from import_object in case L3 agent fails to
    import interface_driver.
    
    As part of the job, consolidated code to load interface driver into
    common function.
    
    Also, stopped checking for specific log messages in dhcp and l3 agent
    unit tests: it's too fragile and actually not something we need a unit
    test for.
    
    Not to introduce more work for people who handle py3 porting effort,
    added the unit test into the list of those that are executed for py34
    job until the whole suite is ready for python3.
    
    Change-Id: I10cdb8414c9fb4ad5cfd3f3b2630811f50ffb0c7

commit 65bb9241e72216c705f31bbd7e523e0951dec0e0
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Tue Jul 14 14:50:46 2015 +0000

Updated from global requirements
    
    Change-Id: Ibcb49412a012f79be2f7fd697349ddbf43bd7b9b

commit 519c6264526b9da5ed3af9be3c460adee2c88fa0
Author: Kyle Mestery <mestery@mestery.com>
Date:   Tue Jul 14 13:28:52 2015 +0000

bugs: Update info about current bug czar
    
    Eugene stepped down as bug czar a month or so ago, update it to reflect
    the fact I've been triaging bugs since then and will be the contact
    point now.
    
    Change-Id: I598ac4ea742e39987e5554184e0df4fc718104ab
    Signed-off-by: Kyle Mestery <mestery@mestery.com>

commit 15f5d1ba6f9cc9f1e39d3b1ef066d473c1795d29
Author: Gal Sagie <gal.sagie@huawei.com>
Date:   Tue Jul 14 14:32:33 2015 +0300

Add another Lieutenant contact for Dragonflow
    
    Add another lieutenant contact for Dragonflow
    
    Change-Id: I57c6d91951e2b481f4d913d239a97171807ada5c

commit c7acfbabdc13ed2a73bdbc6275af8063b8c1eb2f
Author: Ihar Hrachyshka <ihrachys@redhat.com>
Date:   Mon Jun 22 16:23:36 2015 +0200

[neutron-db-manage] support separate migration branches
    
    New migration rule scheme is introduced. Now, changes are classified
    into the following branches:
    
    - expand (additive changes only)
    - contract (contraction changes, including data migration)
    
    Make 'neutron-db-manage revision' generate two separate migration
    scripts, one per branch.
    
    Now that we support multiple heads, renamed HEAD file in HEADS. We still
    don't allow more branching, so keep validation for the number of
    branches.
    
    For backwards compatibility, calling to 'upgrade head' applies both
    branches in proper order.
    
    Note that advanced services will be moved to the new migration scheme in
    separate patches for respective repos.
    
    This patch does not introduce autogenerate support for multiple branches
    for 'revision' command (that depends on a new alembic version yet
    unreleased; but alembic/master already has everything to support us).
    
    The patch does not implement 'expand' or 'contract' commands that are
    anticipated by the spec proposal. Those will come in consequent patches.
    
    Upgrade impact is backwards compatible: those who are interested in
    reducing downtime while applying some migration rules can opt in it by
    modifying their upgrade practices, while everything should still work
    the old way for those who don't care.
    
    blueprint online-schema-migrations
    
    DocImpact
    UpgradeImpact
    
    Change-Id: I3823900bc5aaf7757c37edb804027cf4d9c757ab

commit 69ad73aaf21a36c5dfd64cfd1a4982d45cc6fe81
Author: Akihiro Motoki <amotoki@gmail.com>
Date:   Mon Jul 13 10:30:47 2015 +0900

Disable python3 tests failing due to Routes < 2.0
    
    At now, global-requirements has an entry:
    Routes!=2.0,!=2.1,>=1.12.3
    and this leads to Routes < 2.0 which is not compatible
    with Python 3. This blocks updating of global requirements [1].
    To avoid the situation, this commit disables python 3 related
    error due to Routes version.
    
    Closes-Bug: #1474266
    Related to blueprint neutron-python3
    
    [1] https://review.openstack.org/#/c/182746/
    
    Change-Id: If5e6355505361cbefe04487b6d47ab9cc6ba861c

commit 6cb0bdc5923a80454b31873736005fad406ef5de
Author: Takashi NATSUME <natsume.takashi@lab.ntt.co.jp>
Date:   Tue Jul 14 09:56:13 2015 +0900

Fix typo of 'receive' in test_dhcp_ipv6.py
    
    Change-Id: I67e278232d1d100c183128565d843271b463107a

commit e0950b7f2c2e38c1f72a93009d1e51ed93ab4eb3
Author: Takashi NATSUME <natsume.takashi@lab.ntt.co.jp>
Date:   Tue Jul 14 10:16:53 2015 +0900

Fix typo 'adress'
    
    Fix typo 'adress_scope' to 'address_scope'
    in neutron/extensions/address_scope.py.
    Fix typo 'test_remove_adresses_by_interface' to
    'test_remove_addresses_by_interface'
    in neutron/tests/unit/agent/linux/test_keepalived.py
    
    Change-Id: If5496911b63a9f199c9be389ab3fd938c21d091e

commit 7f6fe19f3a4066071375266118cf1bf1d0d8c5f9
Author: YAMAMOTO Takashi <yamamoto@midokura.com>
Date:   Tue Jul 14 11:42:41 2015 +0900

Add sub-project lieutenant for networking-midonet
    
    Defines clear point of contacts for networking-midonet.
    
    Change-Id: I6cbe63c279bc9d265a420b358a8e9ed0c355f914

commit 69952c0765955b88c4d45e74d24531a8ce2d35f9
Author: gong yong sheng <gong.yongsheng@99cloud.net>
Date:   Mon Jul 13 14:43:10 2015 +0800

Lower log level for extending network/subnet/port
    
    These extensions are too normal and happens lots, So there is
    no need to use info level.
    
    Change-Id: Ic6700bc1874efff8e7ecb63fe6d6c7151578e64d
    Closes-bug: 1473859

commit 5745536aa84132e27ae082a217f1d5fe164be1e3
Author: Kenji Yasui <k-yasui@ti.jp.nec.com>
Date:   Mon Jul 13 07:59:03 2015 +0000

Cleanup unused method get_plugin_version
    
    This patch removes get_plugin_version because it's left over
    from the original plugin api and is not in the current api.
    
    Change-Id: Icc9f4e6074b30edfe46364819f812731ad514b47

commit fc9afcd98169f68576f17e933bbfe5bfcd0957cc
Author: Kevin Benton <blak111@gmail.com>
Date:   Mon Jul 13 15:27:54 2015 -0700

Remove db-access semaphore in ML2
    
    With the addition of the deadlock retry decorator in
    I635cc49ca69f589f99ab145d4d51e511b24194d2 and the change
    to instantaneous deadlock feedback under the pymysql driver,
    this semaphore should no longer be necessary. Removing it
    will allow us to benefit from processing multiple requests
    simultaneously.
    
    Change-Id: If5dc76a2974d13d45f0cc88419bcccb3332576cf

commit 63f58b525ef330223b54cd2e92bbceeffce1eb22
Author: Saksham Varma <sakvarma@cisco.com>
Date:   Mon Jul 13 13:51:33 2015 -0700

Moving out cisco n1kv extensions
    
    Moving out Cisco N1Kv extensions to the openstack/networking-cisco
    as part of the second phase vendor-core decomposition
    
    Change-Id: Ib95309c7fa00c2afc3ebbfbbcb06ef430e90d6be
    Depends-on: I408619a82497392a287dce6677673071ffc714f1
    Closes-Bug: #1474129

commit 1cccb37817dfe865610716012deb2f0f3209a58e
Author: Carl Baldwin <carl.baldwin@hp.com>
Date:   Thu Jul 9 21:26:49 2015 +0000

Remove self.snat_ports, a dvr thing, from router base class
    
    This was overlooked in splitting out dvr code from the router base
    class.  It is dvr only.  Also, it doesn't need to be an instance
    variable and was not use consistently.
    
    Change-Id: I0eff381c1613e3824c8da0f0ccba65dd3e884cbf

commit 1f272f9c7e22d52d71c3954fc0e683f082d75e07
Author: Dustin Lundquist <dustin@null-ptr.net>
Date:   Fri Jul 10 12:36:44 2015 -0700

Include comment in DHCP ip6tables rules
    
    Change-Id: I28531186c45477939618a01f17f6efed43f71c09

commit c6d0e45c9fb07fab4edf9be3a11ca00c8ffd0b84
Author: Yoni Shafrir <yshafrir@redhat.com>
Date:   Wed Dec 17 09:25:55 2014 +0200

Fixed L3 agent manual scheduling for HA routers
    
    When a router is manually scheduled we check if a router can be scheduled
    to the given L3 agent. In this check we were missing handling for
    HA router, instead we raised an exception as a last resort.
    
    In addition, we create an HA port on the newly scheduled agent.
    The HA port is created within the router's namespace on that agent.
    Previously when manually scheduling this was not done at all.
    
    This patch takes care of HA routers by allowing them to be
    manually scheduled to a L3 agent if the router is not already
    scheduled to that given L3 agent.
    
    The patch also adds an HA port in the router's namespace on the newly
    scheduled L3 agent.
    
    In addition the patch also removes the 'max_l3_agents_per_router'
    enforcement when manually schedulling a router on a agent. This is
    done as the admin should be able to schedule a router on an agent
    if he desires, moreover this is consistent with the
    'min_l3_agents_per_router' that is not enforced when manually
    descheduling a router from an agent.
    
    Co-Authored-By: gong yong sheng <gong.yongsheng@99cloud.net>
    Co-Authored-By: Nir Magnezi <nmagnezi@redhat.com>
    Closes-Bug: #1401095
    
    Change-Id: I1e2d281cfec50e7fff4ec68659882fc7c0cb4a29

commit 4cdc71e7d0e5220a5f12ee2dfea1ff3db045c041
Author: Dustin Lundquist <dustin@null-ptr.net>
Date:   Mon Jul 6 13:53:46 2015 -0700

Ensure floating IPs only use IPv4 addresses
    
    Description:
    Presently Neutron doesn't validate the address family of floating IP
    addresses or the internal addresses they are associated with. It merely
    associates the first IP of the floating IP's port with the first IP of
    the internal port, unless a specified fixed IP is specified. This can
    lead to incorrect or poorly defined behavior when IPv6 is present.
    
    The existing L3 agent implementation only manages IPv4 NAT rules. While
    IPv6 NAT and NAT protocol translation are possible, the existing
    implementation does not support these configurations.
    
    Presently a floating IP can be created on an IPv6 only external network
    or associated with an IPv6 fixed IP, but the L3 agent is unable to bind
    these configurations.
    
    Implementation:
    When creating and updating a floating IP, only consider IPv4 addresses
    on both the floating IPs port and the internal port he floating IP is
    associated with. Additionally disallow creating floating IPs on networks
    without any IPv4 subnets, since these floating IPs could not be
    allocated an IPv4 address.
    
    DocImpact
    APIImpact
    
    Co-Authored-By: Bradley Jones <jones.bradley@me.com>
    Change-Id: I79b28a304b38ecdafc17eddc41213df1c24ec202
    Related-Bug: #1437855
    Closes-Bug: #1323766
    Closes-Bug: #1469322

commit 2d390876b99c7ee227543663aa7345ba4bef714c
Author: Akihiro Motoki <amotoki@gmail.com>
Date:   Sat Jul 11 06:01:38 2015 +0900

Lower log level of errors caused by user requests to INFO
    
    When webob exception is returned, error level log is
    always recorded even though we return 4xx (client error)
    to users. 4xx error in response code means errors due to
    user requests, so error level log is not appropriate.
    This commit lowers the log level to INFO for such events.
    
    Currently only case I see is webob.exc.HTTPNotFound returned
    by the policy engine when a user requests an operation
    prohibited by the policy, but I think there is no reason
    we deal with 404 specially in neutron.api.v2.resource.
    
    Change-Id: I9f042a90c9bf528be7cb835d7fe818ed1879054b
    Closes-Bug: #1473556

commit 75859529cf878dcc1b59768fac2b8a2ad14822df
Author: Wei Wang <wangwei@unitedstack.com>
Date:   Mon Apr 13 18:25:11 2015 +0800

Fix bug that resources in attr_map may point to same object
    
    The assignment of attr_map may cause resources' attr_map point
    to a same object. So once one resource's attr_map update, it maybe
    affecte others.
    
    Change-Id: Ica2c3082f9579b297f8c6323e04f8fd17c4da222
    Closes-Bug: #1443342

commit 3d262feb07e033174c0cbb9348221580e45b03f5
Author: Carl Baldwin <carl.baldwin@hp.com>
Date:   Thu Jul 9 21:14:39 2015 +0000

Use _is_this_snat_host and remove _get_gw_port_host
    
    The _is_this_snat_host utility should be used consistently.  After
    replacing a call to _get_gw_port_host with _is_this_snat_host,
    _get_gw_port_host is left as just a simple helper method for
    _is_this_snat_host.  The indirection is excessive and so they are
    combined.
    
    Change-Id: I880c5fdc9db9ba1304dba74a6e12f3df604793e5

commit 3fc52dee3cdc336d2fa4e2887e5096c2a00b1987
Author: Carl Baldwin <carl.baldwin@hp.com>
Date:   Thu Jul 9 21:08:19 2015 +0000

Move more snat code to dvr class that does snat
    
    A few methods were left in the wrong class when splitting up the dvr
    classes.  This commit reduces the amount of dependency between the
    two.
    
    Change-Id: Id1b4f4e99a5c51576eddadd5eb0c973c0d5b46b8

commit 454ced5e0f8bb01ef7d64c9f507bf2b35d8fc553
Author: Sean Mooney <sean.k.mooney@intel.com>
Date:   Fri Jul 10 10:37:13 2015 -0400

Add constants for vhost-user vif
    
    This change amends the portbinging extention to include
    defintions of the VIF_TYPE_VHOST_USER and its related
    VIF_DETAILS attributes
    
    Change-Id: Idda3631b766ea9d7329d3b4beb6eb34a73870684
    Closes-Bug: #1473278

commit 45f3bb810fcdded68fdb40645025fc5aee0aba72
Author: Pavel Bondar <pbondar@infoblox.com>
Date:   Mon Jul 6 18:36:22 2015 +0300

Add Pluggable IPAM Backend Part 1
    
    Add methods for allocating/deallocating ips using IPAM driver.
    Methods are covered by unit tests and currently used only by them.
    
    For pluggable IPAM case ipam driver may execute calls to third-party servers.
    It means we can't rely on database transaction rollback in case of failure.
    So if any bulk ip allocation/deallocation fails rollback should be done
    on third-party servers as well.
    Any completed ip allocation should be explicitly deallocated in case of
    failure, and vise versa for failure on deallocation.
    Try-except block is used to do manual rollback actions.
    After rollback actions are done, exception is reraised and local db
    transaction rollback occurs.
    
    Pluggable IPAM was divided into two parts to keep review size small.
    Following patches are expected to use these methods for ip address
    allocation.
    
    Partially-Implements: blueprint neutron-ipam
    
    Change-Id: I8bb836c9883e189b065698ae0a862b2d909d5cbf

commit bad95ee97ffc89fc11ed3e123cb031b1af0a253b
Author: Carl Baldwin <carl.baldwin@hp.com>
Date:   Thu Jul 9 18:44:16 2015 +0000

Ensure that update_fip_statuses gets called
    
    Calling it even when ex_gw_port is None will update fip statuses to
    down when the gateway port is removed.
    
    Change-Id: I0250fda7269bbd79839bf6e7c141f196adc1bd3b
    Closes-Bug: <TODO> (bug needs confirmation, found this by inspection)

commit 2759f130b4e0ee2e9bbc5f6871114d4fc41f63f1
Author: Jakub Libosvar <libosvar@redhat.com>
Date:   Tue Jun 9 10:51:10 2015 +0000

Introduce connection testers module
    
    This module provides tools for testing simple connectivity between two
    endpoints via given technology. Current patch implements endpoints
    connected through either linux bridge or openvswitch bridge.
    Connectivity can be tested using icmp, arp, tcp and udp protocols.
    
    Change-Id: I00e19fd9b80dc6f6743eb735523bd8f5ff096136

commit 324787c0b4bf6b8208c781a4c79dc7f14e67d8d6
Author: Cedric Brandily <zzelle@gmail.com>
Date:   Wed Jul 8 15:38:37 2015 +0000

Correct fcntl.flock use in Pidfile.unlock
    
    This change corrects Pidfile.unlock[1] implementation, indeed currently
    it uses fcntl.flock response as a condition but fcntl.flock is a "void"
    function.
    
    [1] neutron.agent.linux.daemon
    
    Closes-Bug: #1472725
    Change-Id: If2320f29095ed388f9f6fe59d4d9b80d04adaa85

commit 2feb44d81d2b48180f8481abcdc7ffe6857d473a
Author: Fawad Khaliq <fawad@plumgrid.com>
Date:   Wed Jul 8 03:02:12 2015 -0700

Add sub-project lieutenant for networking-plumgrid
    
    Since networking-plumgrid has been approved [1] in
    governance to be part of Neutron. So as per the
    concept of Lieutenants for Neutron, this patch defines
    clear point of contact for networking-plumgrid.
    
    [1] https://review.openstack.org/#/c/197168/
    
    Change-Id: I01706b69aac5ac3970913320ff717dc561ea4f8f

commit 3b0fe59745b2b78daf40a51892c83b0a69e33a21
Author: gong yong sheng <gong.yongsheng@99cloud.net>
Date:   Thu Jun 25 12:38:40 2015 +0800

Add extra subnet route to ha router
    
    Add scope in HA virtual route mode to
    represent on link scope route from extra subnet.
    
    Co-Authored-By: Assaf Muller <amuller@redhat.com>
    
    Change-Id: I6ce000a7aa8e4b9e61a35a86d3dc8c0b7beaa3a9
    Closes-bug: 1414640

commit 46608806aa7a9c60214e28429ca5a8b87b2a15de
Author: Oleg Bondarev <obondarev@mirantis.com>
Date:   Thu Jul 2 18:18:52 2015 +0300

DVR: cleanup stale floating ip namespaces
    
    During l3 agent periodic resync NamespaceManager takes care
    of cleaning up stale router namespaces. This is true
    for qrouter- and snat- namespaces. However stale fip-
    namespaces also need to be cleaned up.
    The patch adds fip-ns handling to the NamespaceManager.
    
    Closes-Bug: #1470909
    Change-Id: Ib6a8ae2ff66c0e1dd0978838c3f274748898f73e

commit 8a084805544a4676aeb4a9182032297897e590e0
Author: Brian Haley <brian.haley@hp.com>
Date:   Thu Jul 2 15:56:51 2015 -0400

Install more-specific ICMPv6 rule in DVR routers
    
    The Openflow rule added in install_dvr_process_ipv6() is dropping
    all ICMPv6 traffic, not just the Router Advertisement the comment
    mentions. This is causing things like ping6 to fail to VMs on DVR
    compute nodes because the reply packets are getting dropped in the
    local DVR router before being sent to br-tun.
    
    Change-Id: I14741dd4293e7cfb99cb6bba03cf583ca3ea82ef
    Closes-bug: 1471000

commit 0a3279107ffe483348cdf5ed4614537e72cbf62a
Author: Assaf Muller <amuller@redhat.com>
Date:   Tue Jun 30 14:56:28 2015 -0400

Move pylint dep from tox.ini to test-requirements
    
    This allows us to pin pylint from global requirements.
    
    Closes-Bug: #1470186
    Depends-On: Ibad8cd2911efbe075ea2629c543f6ce1f216c938
    Change-Id: I31cc18e0b4cd32728f5814aa9dbf403104f72c72

commit a60e5660d2e77a1d337aba69c3624ef976897e53
Author: Fawad Khaliq <fawad@plumgrid.com>
Date:   Tue Jun 30 02:22:54 2015 -0700

Register extraroute extension
    
    Added extraroute extension for PLUMgrid Plugin
    
    Change-Id: I00519cf9482651212ab430f31b90d3b4d901ee32

commit f4e1289d8d381b775f7a6e5f98c507a99fd42b54
Author: Kahou Lei <kahou82@gmail.com>
Date:   Wed Jun 3 16:39:11 2015 -0700

populate port security default into network
    
    Previously, the default value would be populated into attr by API
    controller, but some codes in plugin or service plugins call plugin
    to create network directly, such as l3, which will have no default
    value populated.
    This patch fixes it by populating default port_security value into
    network data.
    
    In addition, for network without port-security set, we also give the
    default value to populate the return network dict object, which will
    let the extension construct the response dictionary gracefully for
    those existing network.
    
    Co-Authored-By: gong yong sheng <gong.yongsheng@99cloud.net>
    
    Change-Id: I73abc98d83372f6259f17680806e6541458e2077
    Closes-bug: #1461519
    Closes-Bug: #1461647
    Closes-Bug: #1468588

commit 7c273fe2188e0fc3738cb4320affce28e99335ad
Author: Cedric Brandily <zzelle@gmail.com>
Date:   Mon Jun 15 22:20:16 2015 +0200

Abstract sync_allocations
    
    Currently gre/vxlan type drivers have specific sync_allocations
    implementations to perform the same feature. This change abstracts
    (vxlan) implementation and moves it to TunnelTypeDriver[1] in order to
    share implementation between gre/vxlan; this change also adds some
    unittests.
    
    Current gre/vxlan and new implementations of sync_allocations are not
    Galera-compliant with multi-writers, a follow-up will update it to
    fully support Galera.
    
    [1] neutron.plugins.ml2.drivers.type_tunnel
    
    Change-Id: I188a7cf718d811084475f6783d844588de5d60ea

commit 9b56ef34f76eb1aaf129c1e34df1a6ccfa172c2c
Author: Angus Lees <gus@inodes.org>
Date:   Fri May 15 16:41:33 2015 +1000

Just use {0,1,2} rather sys.std*.fileno()
    
    Sometimes sys.std* have been monkeypatched to something other than real
    filehandles, and the fileno() method may be missing or return a
    misleading value (eg: during test cases).
    
    This change just hard codes the real 0/1/2 file descriptor numbers
    rather than trying to find another more stable symbolic name - the
    values are well known and as portable as the os.dup2() call being used.
    
    Strongly related to this, this change also moves the relevant flush()
    calls before any fork/dup2 funny business, to ensure python buffers are
    flushed and only the expected data hits the fds.
    
    Change-Id: I635b3a6a7413ea85d0eac55d9a6e1dbc7402376f

commit ae4efdc240d1b08d07e88ffa6a7210815680479c
Author: Angus Lees <gus@inodes.org>
Date:   Fri May 15 16:39:58 2015 +1000

Make Daemon pidfile arg optional
    
    Some uses of Daemon don't need a pidfile (eg: privsep).
    
    Change-Id: Ic49e841f2f80000f1fd2f2738ab24e703b370d73

commit aeca3ccefc4808eedf88681efc11b4ffad710d01
Author: Angus Lees <gus@inodes.org>
Date:   Fri May 15 16:21:44 2015 +1000

Different approach to indicate failure on SystemExit
    
    The handlers added via addOnException can only add further detail and
    can't alter the result of the test case.  The previous code called
    `self.fail()` on SystemExit, but the resulting AssertionError wasn't
    actually caught by the test machinery and escaped out - aborting the
    test run and exiting non-zero (good) but without the usual test failure
    reporting (details, etc) nor continuing on to the next test case (bad).
    
    This change indicates failure on SystemExit by setting the
    `force_failure` attribute to True.  This attribute is checked very late
    in the test running process and *does* allow the exception handler to
    override the regular test result and indicate a failure "cleanly".
    
    The unittest mocking arms race continues!
    
    While experimenting with one (since abandoned) approach, I observed
    different behaviour with sys.exit(1) vs sys.exit(0) (would print failure
    stacktrace as expected, but then went on to exit the overall process
    with exitcode 0).  Although any exit status behaves correctly with the
    final approach taken, this change also adds an explicit unittest
    exercising the sys.exit(0) case.
    
    Change-Id: I18767f5757c35b8e9ae8e61fef3d7f786ed56bdb

commit a04f44412bca2fce75ee32d16c71f6787b8a1682
Author: sridhargaddam <sridhar.gaddam@enovance.com>
Date:   Mon Mar 30 05:11:01 2015 +0000

Add sanity_check for keepalived ipv6 support
    
    Currently Neutron does not validate the version of Keepalived.
    In order to support configuring IPv6 default route, the minimum
    version [1] of keepalived that is required is 1.2.10
    This patch validates the required support in keepalived.
    
    Although keepalived changelog mentions that IPv6 virtual_routes and
    static_routes are supported in version 1.2.8, it is seen that in
    v1.2.8 IPv6 default route is not supported. Support for default route
    is added in keepalived v1.2.10. Observations on v1.2.8 are captured
    at the following link - http://paste.openstack.org/show/165403/
    
    [1] - http://www.keepalived.org/changelog.html
    
    Closes-Bug: #1415756
    Change-Id: I768ae233d2c2e24df93a4736ef6d8f4005770fa5

commit d5b600a7a20c65d8c4ebb1205d4c9741bb89aaf3
Author: Assaf Muller <amuller@redhat.com>
Date:   Wed Jun 3 08:58:04 2015 -0400

Fullstack testing devref follow up
    
    Change-Id: Ie6e7741474a76c115eacff34e50fb50a83477766

tags:

added: in-feature-pecan

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-08-03: Change abandoned on neutron (master)

Change abandoned by yalei wang (<email address hidden>) on branch: master
Review: https://review.openstack.org/203992
Reason: https://review.openstack.org/#/c/200279/

fixed it.

Assaf Muller (amuller) on 2015-12-16

Changed in neutron:
status:	In Progress → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #1473179

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.