Some ovs_lib unit tests take a significant amount of time

Bug #1459811 reported by Assaf Muller
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Madhu Mohan Nelemane

Bug Description

When running:

tox -e py27 neutron.tests.unit.agent.common.test_ovs_lib.OVS_Lib_Test

The following tests:
neutron.tests.unit.agent.common.test_ovs_lib.OVS_Lib_Test.test_create
neutron.tests.unit.agent.common.test_ovs_lib.OVS_Lib_Test.test_reset_bridge

Take 20 and 10 seconds respectively on a VM of mine.

Revision history for this message
Terry Wilson (otherwiseguy) wrote :

Those times make it seem like somehow maybe the ovsdb backend is being used, so mocking out the execute function doesn't really have any effect. But that seems odd for a unit test.

I believe all of these unit tests are actually duplicated by functional tests anyway, so it might be best to just delete the unit tests since they only test called_once_with stuff and don't apply to the OVSDB implementation as well.

Changed in neutron:
assignee: nobody → Terry Wilson (otherwiseguy)
Changed in neutron:
assignee: Terry Wilson (otherwiseguy) → Madhu Mohan Nelemane (mmohan-9)
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/208860

Revision history for this message
Madhu Mohan Nelemane (mmohan-9) wrote :

Detalis of tests removed.
=====================
1. Unit tests: reset_bridge(), create() and destroy()
------------------------------------
 The code for these functions are really just redirecting calls to ovsdb
with no other code to be tested.
Hence, IMO they may be ommitted from unit tests.

Also Functional tests: test_bridge_lifecycle_baseovs() and test_bridge_lifecycle_ovsbridge()
verify reset_bridge(), create() and destroy() calls.

===========================
2. Unit tests: test_set_controller(), test_del_controller() and test_get_controller()
-----------------------------------------------
These tests only use the mocking. Also, the code under these functions are just redirecting calls to ovsdb.
And these are however functionally tested in test_controller_lifecycle() in tests.functional.agent.test_ovs_lib.py

So I feel these (test_set_controller(), test_del_controller() and test_get_controller()) are redundant as unit tests.

=============================
3. Unit tests: test_set_protocols(), test_set_standalone_mode(), test_set_secure_mode()
---------------------------------------------------
The function set_protocols() calls set_db_attributes() which calls ovsdb.db_set().The functions set_standalone_mode() and set_secure_mode() call _set_bridge_fail_mode() which in turn calls ovsdb.set_fail_mode()

So, the functions are themselves not doing much and transferring control to ovsdb. Again here, IMO the unit tests are not helping much as there is almost no code to verify apart from ovsdb calls.

=============================
4. Unit tests: test_get_bridges(), test_add_patch_port() and test_get_datapath_id()
---------------------------------------------------
were removed as they are not testing anything apart from redirection to the ovsdb library.

============================
5. Unit tests _test_get_vif_port_set(), test_add_tunnel_port() and
-------------------------------------------------
have some custom logic implementation in ovs_lib module and having unit tests for these functions will be useful. Hence these tests are added back to unit tests.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/208860
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=320d7a83ba269b16874f19e39a33bdc1d815ed5d
Submitter: Jenkins
Branch: master

commit 320d7a83ba269b16874f19e39a33bdc1d815ed5d
Author: Madhu Mohan Nelemane <email address hidden>
Date: Tue Aug 4 09:21:52 2015 +0200

    Redundant tests removed from ovs-lib unit tests:

    The idea here was to remove redundant unit tests.
    The approach here has been that if the function being tested does not
    implement any custom logic (apart from calling ovsdb), the unit test
    does not help.

    Refer to the bug description for more details of the specific tests
    removed.

    Change-Id: I35dc60bb714566c33f5cee5aab3e5b83bd0610e3
    Closes-Bug: #1459811

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/218710

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (155.6 KiB)

Reviewed: https://review.openstack.org/218710
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2c5f44e1b3bd4ed8a0b7232fd293b576cc8c1c87
Submitter: Jenkins
Branch: feature/pecan

commit f35d1c5c50dccbef1a2e079f967b82f0df0e22e9
Author: Adelina Tuvenie <email address hidden>
Date: Thu Aug 27 02:27:28 2015 -0700

    Fixes wrong neutron Hyper-V Agent name in constants

    Change Id03fb147e11541be309c1cd22ce27e70fadc28b5 moved the
    AGENT_TYPE_HYPERV constant from common.constants to
    plugins.ml2.drivers.hyperv.constants but change the value of the
    constant from 'HyperV agent' to 'hyperv'. This patch changes
    the name back to 'HyperV agent'

    Change-Id: If74b4b2a84811e266c8b12e70bf6bfe74ed4ea21
    Partial-Bug: #1487598

commit de604de334854e2eb6b4312ff57920564cbd4459
Author: OpenStack Proposal Bot <email address hidden>
Date: Sun Aug 30 01:39:06 2015 +0000

    Updated from global requirements

    Change-Id: Ie52aa3b59784722806726e4046bd07f4a4d97328

commit f0415ac20eaf5ab4abb9bd4839bf6d04ceee85d0
Author: armando-migliaccio <email address hidden>
Date: Fri Aug 28 13:53:04 2015 -0700

    Revert "Add support for unaddressed port"

    This implementation may expose a vulnerability where a malicious
    user can sieze the opportunity of a time window where a port
    may land unaddressed on a shared network, thus allowing him/her
    to suck up all the tenant traffic he/she wants....oh the shivers.

    This reverts commit d4c52b7f5a36a103a92bf9dcda7f371959112292.

    Change-Id: I7ebdaa8d3defa80eab90e460fde541a5bdd8864c

commit 013fdcd2a6d45dbe4de5d6e7077e5e9b60985ef9
Author: Assaf Muller <email address hidden>
Date: Fri Aug 28 16:41:07 2015 -0400

    Improve logging upon failure in iptables functional tests

    This will help us nail down a more accurate and efficient logstash
    query.

    Change-Id: Iee4238e358f7b056e373c7be8d6aa3202117a680
    Related-Bug: #1478847

commit 622dea818d851224a43d5276a81d5ce8a6eebb76
Author: Ivar Lazzaro <email address hidden>
Date: Mon Aug 17 17:17:42 2015 -0700

    handle gw_info outside of the db transaction on router creation

    Move the gateway interface creation outside the DB transaction
    to avoid lock timeout.

    Change-Id: I5a78d7f32e8ca912016978105221d5f34618af19
    Closes-bug: 1485809

commit 5b27d290a0a95f6247fc5a0fe6da1e7d905e6b2d
Author: Assaf Muller <email address hidden>
Date: Wed Aug 26 10:07:03 2015 -0400

    Remove ml2 resource extension success logging

    This is the cause of a tremendous amount of logs, for no
    perceivable gain. A normal dvr run in the gate shows this debug
    message around 120K times, which is way too much.

    Closes-Bug: #1489952

    Change-Id: I26fca8515d866a7cc1638d07fa33bc04479ae221

commit 8d3faf549cba2f58c872ef4121b2481e73464010
Author: huangpengtao <email address hidden>
Date: Fri Aug 28 23:20:46 2015 +0800

    Replace "prt" variable by "port"

    the local variable prt is meaningless,
    and port is used popular.

    Change-Id: I20849102cf5b4d84433c46791b4b1e2a22dc4739

commit ee374e7a5f4dea538fcd942f5...

tags: added: in-feature-pecan
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-3 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.