Some ovs_lib unit tests take a significant amount of time
Bug #1459811 reported by
Assaf Muller
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Low
|
Madhu Mohan Nelemane |
Bug Description
When running:
tox -e py27 neutron.
The following tests:
neutron.
neutron.
Take 20 and 10 seconds respectively on a VM of mine.
Changed in neutron: | |
assignee: | Terry Wilson (otherwiseguy) → Madhu Mohan Nelemane (mmohan-9) |
Changed in neutron: | |
status: | New → In Progress |
Changed in neutron: | |
milestone: | none → liberty-3 |
status: | Fix Committed → Fix Released |
Changed in neutron: | |
milestone: | liberty-3 → 7.0.0 |
To post a comment you must log in.
Those times make it seem like somehow maybe the ovsdb backend is being used, so mocking out the execute function doesn't really have any effect. But that seems odd for a unit test.
I believe all of these unit tests are actually duplicated by functional tests anyway, so it might be best to just delete the unit tests since they only test called_once_with stuff and don't apply to the OVSDB implementation as well.