ML2 DVR port binding not covered by unit tests

[Robert Kukura]

While working on cleaning up the duplicated DB schema and logic introduced to support DVR's distributed bindings (bug 1367391), I discovered much much of the ML2 port binding support for DVR was not covered by existing unit tests. Ideally, tests covering this would be written and merged before the fix for bug 1367391 to ensure that the the cleanup work does not make unexpected behavioral changes.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/182134

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/182134
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=922dae45d0a223f9256bdff1faa65d469cbc9275
Submitter: Jenkins
Branch: master

commit 922dae45d0a223f9256bdff1faa65d469cbc9275
Author: Robert Kukura <email address hidden>
Date: Wed Apr 1 17:11:59 2015 -0400

    Add unit tests for ML2 DVR port binding and fix PortContext inconsistencies

    Extends the existing ML2 port binding unit tests to cover the
    distributed port bindings used for DVR. Within the test mechanism
    driver, bindings are tracked per-host, and additional assertions are
    added.

    Fixes issues with PortContext attributes that were exposed by these
    new tests. Adds new vif_type, original_vif_type, vif_details, and
    original_vif_details PortContext attributes, similar to the exising
    host, original_host, status, and original_status attributes, to
    reflect host-specific details of distributed (or normal) port
    bindings. Also fixes original_host and original_status to return None
    when in the context of an operation other than an update, and fixes
    original_host to reflect the specific host being bound for a
    distributed port.

    Closes-bug: 1453943
    Closes-bug: 1453955
    Change-Id: I467db0d48e4b82fdaad8d851e294e639a84a8160

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/241616

[OpenStack Infra (hudson-openstack)]

Change abandoned by Erik Colnick (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/241616
Reason: Not convinced this was actually an issue in kilo. Abandoning.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Erik Colnick (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/241616
Reason: This particular change is not backwards compatible owing to modification in the abstract interface for PortContext, which will break other existing implementations of the interface.