fwaas iptables driver does not work with plugins without DVR support

[Akihiro Motoki]

fwaas iptables does not work with plugins without dvr extension support because fwaas iptables expects router_info.router has "distributed" attribute. The attribute is only populated when dvr extension is supported. As the original intention, iptables firewall implemention should work without dvr support.
(I see this bug in nec plugin at least.)

-3614-4f0c-b112-2d06ce4c1511 for tenant 80ea3f02f2414ee89e520944a1da5a58) from (pid=15023) create_firewall /opt/stack/neutron-fwaas/neutron_fwaas/services/firewall/drivers/linux/iptables_fwaas.py:55
2015-04-25 18:36:30.838 ERROR neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas [req-732eb7ca-2d7c-4bb3-9265-f4633f197b06 demo 80ea3f02f2414ee89e520944a1da5a58] Failed to create firewall:
 35021da7-3614-4f0c-b112-2d06ce4c1511
2015-04-25 18:36:30.838 TRACE neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas Traceback (most recent call last):
2015-04-25 18:36:30.838 TRACE neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas File "/opt/stack/neutron-fwaas/neutron_fwaas/services/firewall/drivers/linux/iptables_fwaas.py", line 58,
 in create_firewall
2015-04-25 18:36:30.838 TRACE neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas self._setup_firewall(agent_mode, apply_list, firewall)
2015-04-25 18:36:30.838 TRACE neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas File "/opt/stack/neutron-fwaas/neutron_fwaas/services/firewall/drivers/linux/iptables_fwaas.py", line 153
, in _setup_firewall
2015-04-25 18:36:30.838 TRACE neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas agent_mode, router_info)
2015-04-25 18:36:30.838 TRACE neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas File "/opt/stack/neutron-fwaas/neutron_fwaas/services/firewall/drivers/linux/iptables_fwaas.py", line 76,
 in _get_ipt_mgrs_with_if_prefix
2015-04-25 18:36:30.838 TRACE neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas if not router_info.router['distributed']:
2015-04-25 18:36:30.838 TRACE neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas KeyError: 'distributed'
2015-04-25 18:36:30.838 TRACE neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas
2015-04-25 18:36:30.839 ERROR neutron_fwaas.services.firewall.agents.l3reference.firewall_l3_agent [req-732eb7ca-2d7c-4bb3-9265-f4633f197b06 demo 80ea3f02f2414ee89e520944a1da5a58] Firewall Driver Er
ror for create_firewall for firewall: 35021da7-3614-4f0c-b112-2d06ce4c1511

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/177542

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/177894

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/177542
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=649fab93cedb6b1c3be57ff57ed4278de2916514
Submitter: Jenkins
Branch: master

commit 649fab93cedb6b1c3be57ff57ed4278de2916514
Author: Akihiro Motoki <email address hidden>
Date: Sat Apr 25 20:51:06 2015 +0900

    Make iptables firewall work with L3 plugin without DVR support

    iptables firewall implementation expects 'distributed' attribute
    is populated in router_info.router, but this attribute is only
    populated when L3 plugin supports DVR extension. This commits
    take into account the case where 'distributed' attribute does
    not exist in router_info.router.

    Change-Id: I2b0c208d74923f9ea0fc35bcea00e11152bbdb3d
    Closes-Bug: #1448439

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/177894
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=cdcd5a7b69475ec93afa9c4cbb1dbe91c21a5e47
Submitter: Jenkins
Branch: stable/kilo

commit cdcd5a7b69475ec93afa9c4cbb1dbe91c21a5e47
Author: Akihiro Motoki <email address hidden>
Date: Sat Apr 25 20:51:06 2015 +0900

    Make iptables firewall work with L3 plugin without DVR support

    iptables firewall implementation expects 'distributed' attribute
    is populated in router_info.router, but this attribute is only
    populated when L3 plugin supports DVR extension. This commits
    take into account the case where 'distributed' attribute does
    not exist in router_info.router.

    Change-Id: I2b0c208d74923f9ea0fc35bcea00e11152bbdb3d
    Closes-Bug: #1448439
    (cherry picked from commit 649fab93cedb6b1c3be57ff57ed4278de2916514)