ml2 doesn't return port_id to RPC callers in all cases

[Kevin Benton]

Whenever an RPC caller of get_device_details uses something that is not a port ID, that same identifier is passed back to it in the port ID field of the response. The 'device' field already represents what the caller asked using, so this should be corrected to use the port id.

I know the IVS agent uses this for sure and the linux bridge agent will require this as well since it doesn't have OVSDB.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/173145

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/173145
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=76fa87e12eb69c962dd85a3399d3dbce0c5a3271
Submitter: Jenkins
Branch: master

commit 76fa87e12eb69c962dd85a3399d3dbce0c5a3271
Author: Kevin Benton <email address hidden>
Date: Mon Mar 30 11:49:40 2015 -0700

    Pass correct port ID back to RPC caller

    The previous response to get_device_details calls was returning
    whatever the caller requested as the port_id in the response.
    This was only correct in the case where the port_id was used
    directly. In cases where device names were passed in, there was
    no way to retrieve the full port ID.

    This corrects that behavior by using the port ID from the database
    and adds tests to ensure the behavior remains correct.

    Closes-Bug: #1443714
    Change-Id: Ibfc7b6659a29e892dfe6e83bd9340feb40e920dd

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072