_device_to_port_id broken for many devices

Bug #1443710 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Kevin Benton

Bug Description

The _device_to_port_id method in ML2 accepts either an interface name, a port UUID, or a MAC address and returns the corresponding port ID.

The part that takes an interface name currently only works if the interface prefix is 'tap'. This is broken in the cases where security group filtering is used ('qvo' prefix) and snat interfaces ('sg-').

This is okay in the cases where the external id is loaded directly into the database, but it doesn't work for vswitches that don't have OVSDB or when scripts have re-added the interface to the vswitch without the external ID.

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/173137

Changed in neutron:
status: New → In Progress
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → liberty-1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/173137
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3e4e932a4d9dbfac908cf03c221b350e645d8b17
Submitter: Jenkins
Branch: master

commit 3e4e932a4d9dbfac908cf03c221b350e645d8b17
Author: Kevin Benton <email address hidden>
Date: Mon Mar 30 11:29:44 2015 -0700

    Fix _device_to_port_id for non-tap devices

    This adjusts the _device_to_port_id function in ML2
    to recognize other interfaces that belong to Neutron
    under different name prefixes.

    Adds unit tests to achieve full converage of _device_to_port_id
    method.

    Closes-Bug: #1443710
    Change-Id: I80284ee67e5876cf5689e49e1592ca1351ae5fa1

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (neutron-pecan)

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.