iptables and ipset manager code should not register config options each time the object is created

[Kyle Mestery]

When reviewing this patch, Armando and I determined the registration of config options at object creation was incorrect. Brian pointed out the iptables code does the same thing. This bug will track the cleanup of this for Liberty.

[1] https://review.openstack.org/#/c/170328/

[Miguel Angel Ajo (mangelajo)]

I believe we could have the registration per-objects when the objects are going to be single, or in a very reduced amount, and capture any double registration exception.

Another option is to register at module level, I guess.

Ideally we should do things one way or another, so I guess the 2nd option makes more sense looking at config registration globally.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/172549

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/172549
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c72559f32dc7cabcd5614ae07e0da2e2248c2785
Submitter: Jenkins
Branch: master

commit c72559f32dc7cabcd5614ae07e0da2e2248c2785
Author: Brian Haley <email address hidden>
Date: Fri Apr 10 15:51:43 2015 -0400

    Move iptables and ipset config registration into modules

    Do not do this on a per-object basis, but instead in the module.

    Change-Id: Ib1cc604c7c0135ca62a6194d8e20a3c29d3c5ed6
    Closes-bug: #1441163

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072