Move values for network_type to plugins.common.constants.py

Bug #1441043 reported by Romil Gupta
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Romil Gupta

Bug Description

It is quite confusing to have values for network type in common.constants.py
instead of having in plugins.common.constants.py.

Currently, the plugins/common/constants.py consists network_type constants
like VLAN, VXLAN, GRE etc. but values for network type like ranges
are defined in common.constants.py which is not good, it is better to have
both things at the same place.

Also, it's better to move out few methods which are predominantly used in plugins
from common.utils.py to plugins.common.utils.py.

Changed in neutron:
assignee: nobody → Romil Gupta (romilg)
status: New → In Progress
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → liberty-1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/166879
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7f406805d93298d0e65d340c2a06ba0d2dd6ff76
Submitter: Jenkins
Branch: master

commit 7f406805d93298d0e65d340c2a06ba0d2dd6ff76
Author: Romil Gupta <email address hidden>
Date: Mon Mar 23 08:05:41 2015 -0700

    Move values for network_type to plugins.common.constants.py

    It is quite confusing to have values for network type in common.constants.py
    instead of having in plugins.common.constants.py.

    Currently, the plugins/common/constants.py consists network_type constants
    like VLAN, VXLAN, GRE etc. but values for network type like ranges
    are defined in common.constants.py which is not good, it is better to have
    both things at the same place.

    This patch set addresses the same.

    Moved out few methods which are predominantly used in plugins
    from common.utils.py to plugins.common.utils.py.

    Removed constants which were used in neutron-fwaas from
    plugins.common.constants.py: https://review.openstack.org/#/c/168709/

    Closes-Bug: #1441043

    Change-Id: Iecfb15c541ed5d3cce95ba48f072af7fa60ac6f1

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (neutron-pecan)

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.