Restricting shell scripts to sh only kills productivity

[Maru Newby]

Neutron's pep8 tox env checks for bash usage [1], but it's increasingly common to ignore the check because sh doesn't support very useful things like arrays. Given that bash usage is almost entirely dev-only, I'm not sure why we should be requiring lowest-common-denominator vs simply requiring that dev platforms have bash. netbsd includes bash in its ports collection, after all.

1: https://github.com/openstack/neutron/blob/master/tools/misc-sanity-checks.sh#L26

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/170939

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/171256

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/170939
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e37dcd4c76e3ab61c585b116c34d32382c592b9f
Submitter: Jenkins
Branch: master

commit e37dcd4c76e3ab61c585b116c34d32382c592b9f
Author: Maru Newby <email address hidden>
Date: Tue Apr 7 15:00:25 2015 +0000

    Remove check for bash usage

    Arbitrarily restricting ourselves from using bash because developers on
    platforms like netbsd don't want to install bash from ports doesn't
    make sense. Any non-trivial shell script is likely to use features
    like arrays or string manipulation that are poorly supported (if at
    all) by sh, and the continued bumping of the number of expected bash
    scripts is an indication that the check is not serving its purpose
    anyway.

    Along with removing the check, all shebang references to /bin/bash
    have been replaced with /usr/bin/env bash in an attempt to be more
    compatible across different hosts.

    Change-Id: Ief72dc380cc88af38959c330897e2c127e33c332
    Closes-Bug: #1440824

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072