Floating IPs should be associated with the first fixed IPv4 address

[Andrew Boik]

If a port attached to an instance has multiple fixed IPs and a floating IP is associated without specifying a fixed ip to associate, the behavior in Neutron is to reject the associate request. The behavior in Nova in the absence of a specified fixed ip, however, is to pick the first one from the list of fixed ips on the port.

This is a problem if an IPv6 address is the first on the port because the floating IP will be NAT'ed to the IPv6 fixed address, which is not supported. Any attempts to reach the instance through its floating address will fail. This causes failures in certain scenario tests that use the Nova floating IP API when dual-stack IPv4+IPv6 is enabled, such as test_baremetal_basic_ops in check-tempest-dsvm-ironic-pxe_ssh in https://review.openstack.org/#/c/168063

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/168701

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168701
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c5dfd2c3ef773b29666fae3fe75bf7548044dbf5
Submitter: Jenkins
Branch: master

commit c5dfd2c3ef773b29666fae3fe75bf7548044dbf5
Author: Andrew Boik <email address hidden>
Date: Sun Mar 29 10:18:48 2015 -0400

    Associate floating IPs with first v4 fixed IP if none specified

    In the absence of a specified fixed address with which to associate a
    floating IP, the first IPv4 address on the port should be associated.
    Without the check for IPv4, IPv6 ports can be associated with a (IPv4)
    floating IP, which is not supported.

    Change-Id: Ib66a9109cc1c7999474daca5970d0af1f70886e4
    Closes-Bug: 1437855

[Joe Gordon (jogo)]

This helps fix IPv6 support so this may be a good candidate for a kilo backport once stable/kilo is open

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/178442

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178442
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e7519b44dd10b19c401f9a27eef548a2efc8e9e2
Submitter: Jenkins
Branch: stable/kilo

commit e7519b44dd10b19c401f9a27eef548a2efc8e9e2
Author: Andrew Boik <email address hidden>
Date: Sun Mar 29 10:18:48 2015 -0400

    Associate floating IPs with first v4 fixed IP if none specified

    In the absence of a specified fixed address with which to associate a
    floating IP, the first IPv4 address on the port should be associated.
    Without the check for IPv4, IPv6 ports can be associated with a (IPv4)
    floating IP, which is not supported.

    Change-Id: Ib66a9109cc1c7999474daca5970d0af1f70886e4
    Closes-Bug: 1437855
    (cherry picked from commit c5dfd2c3ef773b29666fae3fe75bf7548044dbf5)