setup-neutron fails due to flat provider network validation

[Dan Prince]

We are currently seeing the following CI failures:

+ setup-neutron -n /tmp/tmp.b9glMWpPyO
/home/dprince/tripleo-incubator/openstack-tools/lib/python2.7/site-packages/novaclient/v1_1/__init__.py:30: UserWarning: Module novaclient.v1_1 is deprecated (taken as a basis for novaclient.v2). The preferable way to get client class or object you can find in novaclient.client module.
  warnings.warn("Module novaclient.v1_1 is deprecated (taken as a basis for "
2015-03-26 22:01:10 - root - ERROR - Unexpected error during command execution
Traceback (most recent call last):
  File "/home/dprince/tripleo-incubator/openstack-tools/lib/python2.7/site-packages/os_cloud_config/cmd/setup_neutron.py", line 77, in main
    keystone_client=keystone_client)
  File "/home/dprince/tripleo-incubator/openstack-tools/lib/python2.7/site-packages/os_cloud_config/neutron.py", line 46, in initialize_neutron
    net = _create_net(neutron_client, network_desc, network_type, admin_tenant)
  File "/home/dprince/tripleo-incubator/openstack-tools/lib/python2.7/site-packages/os_cloud_config/neutron.py", line 95, in _create_net
    return neutron.create_network({'network': network})
  File "/home/dprince/tripleo-incubator/openstack-tools/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 99, in with_params
    ret = self.function(instance, *args, **kwargs)
  File "/home/dprince/tripleo-incubator/openstack-tools/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 534, in create_network
    return self.post(self.networks_path, body=body)
  File "/home/dprince/tripleo-incubator/openstack-tools/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 295, in post
    headers=headers, params=params)
  File "/home/dprince/tripleo-incubator/openstack-tools/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 208, in do_request
    self._handle_fault_response(status_code, replybody)
  File "/home/dprince/tripleo-incubator/openstack-tools/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 182, in _handle_fault_response
    exception_handler_v20(status_code, des_error_body)
  File "/home/dprince/tripleo-incubator/openstack-tools/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 67, in exception_handler_v20
    status_code=status_code)
BadRequest: Invalid input for operation: physical_network 'ctlplane' unknown for flat provider network.

[Dan Prince (dan-prince)]

I think this may be related to Neutron commit dbe37d571474ca759e57e61308cd3926a00b481e

[Dan Prince (dan-prince)]

Patch/Fix is here:

https://review.openstack.org/168207

[Dan Prince (dan-prince)]

We've landed a temprevert fix to work around the issue in TripleO CI: https://review.openstack.org/#/c/168205/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168207
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3f0c2b552a28b2e9cb8b80dc1691680f65d812db
Submitter: Jenkins
Branch: master

commit 3f0c2b552a28b2e9cb8b80dc1691680f65d812db
Author: Dan Prince <email address hidden>
Date: Thu Mar 26 22:19:58 2015 -0400

    Revert "Fix validation of physical network name for flat nets"

    This reverts commit dbe37d571474ca759e57e61308cd3926a00b481e.

    This validation change broke TripleO's os-cloud-config
    setup-neutron script.

    Change-Id: I94c419b26ba93c67c9064fc110c8986c1ff68897
    Closes-bug: #1437116

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072